InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,472 Commits 6 Branches 0 Tags
d6a7a6bd9c7f183a7712731ac3e32e997fdd9135
Commit Graph

11472 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
wnwen@chromium.org
d6a7a6bd9c android: Allow anonymous pipes for benchmarking 
In a typical scenario we would not want to run the build server if
autoninja is run as part of a script (see https://crrev.com/c/6278629),
but specifically for benchmarking, we want to allow callers who
explicitly set AUTONINJA_STDOUT_NAME to still run the build server, as
these callers need the build server to run to properly time and
benchmark, even if all the output is discarded.

R=agrieve@chromium.org

Bug: 393136861
Change-Id: I97f556c2238eacc5cc8240287f4c6da0160efb71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6499328
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
 2025-04-29 12:32:32 -07:00
recipe-roller
85b059fe00 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716230913990375921

recipe_engine:
05f1abb5b3
  05f1abb (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 9f2cd408ac98 to 4a13ff8ec3a4

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c73a3fc1db4c6fee5076ae6e8a3a0a87949c6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497450
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-29 11:38:37 -07:00
Vadim Shtayura
eefd2ed010 [cipd] Update lucicfg to v1.45.0. 
This picks up PACKAGE.star support.

R=iannucci@chromium.org

Change-Id: I7f1169084c9a5b543fae41a84842b094ca8e9684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6496449
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@google.com>
 2025-04-29 11:30:36 -07:00
Andrew Lamb
550706e9f4 Revert "git-cache: contains_revision returns False if sentient file exists" 
This reverts commit 5a267a66a6.

Reason for revert: Causing gclient sync failures: https://ci.chromium.org/ui/p/chromeos/builders/staging/staging-amd64-generic-msan-fuzzer/b8716255278944170913

Bug: 41488725
Original change's description:
> git-cache: contains_revision returns False if sentient file exists
>
> If git_cache.populate() gets interrupted midway, it can possibly leave
> a git mirror in a state where only some commits are available. Cloning
> such a repo results in an empty repository and causes subsequent git
> checkout to fail.
>
> If the sentient file exists, it indicates that the bootstrapping
> process was interrupted. This CL updates git_cache.contains_revision()
> such that it returns False if the sentient file exists. Then,
> the caller can call mirror.populate() to re-populate the repo/rev.
>
> Bug: 41488725
> Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Scott Lee <ddoman@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>

Bug: 41488725
Change-Id: I50f3ce5f0b6802db5969546d43a4fe1ab2dcf3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497449
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Andrew Lamb <andrewlamb@chromium.org>
 2025-04-29 09:38:37 -07:00
Gavin Mak
4edb194e91 Set rootRepo custom-keyed-value push option on upload 
This associates a CL with its superproject.

Bug: 401148931
Change-Id: I7fe7bd91485e6e1066963b25f1b95980db6d3381
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6476918
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-04-29 09:30:41 -07:00
recipe-roller
43d3eba89b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716298232676626273

recipe_engine:
95805c3153
  95805c3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2cb1ac029774 to 94e82b5e2ea9

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ed4e7e609b93e52a1fb4592e2f10415c1f2a908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6497023
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-28 17:51:14 -07:00
recipe-roller
c3f63ba875 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716318364658264689

recipe_engine:
93db2be6a5
  93db2be (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 426147c8f9cf to eb1acfb1fe32

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1fc3ff2d6c4c4f95cbc6990807bbd51c679ff0b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6495264
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-28 12:29:19 -07:00
Scott Lee
5a267a66a6 git-cache: contains_revision returns False if sentient file exists 
If git_cache.populate() gets interrupted midway, it can possibly leave
a git mirror in a state where only some commits are available. Cloning
such a repo results in an empty repository and causes subsequent git
checkout to fail.

If the sentient file exists, it indicates that the bootstrapping
process was interrupted. This CL updates git_cache.contains_revision()
such that it returns False if the sentient file exists. Then,
the caller can call mirror.populate() to re-populate the repo/rev.

Bug: 41488725
Change-Id: I24fd24e300f5a9f9349589496d6b5f3dacf71fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6491733
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2025-04-28 10:47:52 -07:00
Yiwei Zhang
2f575c52fc presubmit: do not include long_text in uploaded findings 
The long_text includes stack_trace[1] which is very verbose and not
providing much value. If user really need stacktrace or long_text,
they can access it by going to the build page.

[1]: https://screenshot.googleplex.com/5dcPwjNrtizEVBK

Change-Id: I2c5a5c2703875906f4ccaa1c8b1e83fe3a2f6115
Bug: 404837554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6486346
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-04-28 10:37:40 -07:00
Aleksei Khoroshilov
998f7bfaf2 Improve ensure_gsutil reliability 
The current gsutil download code silently fails when the connection
drops mid-download, as read() returns an empty buffer instead of raising
an exception. This may lead to errors such as "zipfile.BadZipFile: File
is not a zip file" on Chromium sync with freshly-bootstrapped
depot_tools when downloading gcs deps.

This change solves this by hardening the process:
- Use retry mechanism with exponential backoff for gsutil download
- Switch to urlretrieve, which looks at Content-Length
- Compare MD5 of the downloaded file with the value from API
- Move exponential_backoff_retry from git_cache.py to gclient_utils.py

Change-Id: I25242948399e01373eb2afd9352e5c78a889051d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6485485
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Aleksei Khoroshilov <akhoroshilov@brave.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2025-04-28 10:31:42 -07:00
Friedrich Hauser
a3cdfed6c4 Revert "Use bundled python to run gn" 
This reverts commit fa8fc854e1.

Reason for revert: Most likley culprit for consistent failure
to generate orderfiles (see crbug.com/414312048).

Bug: 414312048

Original change's description:
> Use bundled python to run gn
>
> Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-04-28 03:33:13 -07:00
Fumitoshi Ukai
fa8fc854e1 Use bundled python to run gn 
Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2025-04-28 00:22:14 -07:00
Yiwei Zhang
1fcc527019 presubmit: make upload_findings_from_result public 
So that it can be used in downstream recipes like:
https://source.chromium.org/chromium/infra/infra_superproject/+/main:build/recipes/recipes/run_presubmit.py

Change-Id: I39336f4ae7f8ce4208836ed20d912a7d9ad06fec
Bug: 404837554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6486487
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-24 22:46:45 -07:00
recipe-roller
c551fe48ca Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716672574412617873

recipe_engine:
29c3ddcf21
  29c3ddc (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6106d9038752 to fd48b8efe637

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6f149bfe928d6c41cea0b8e65a739663c452b72e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6489740
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-24 14:39:19 -07:00
Allen Li
f55de362c1 [git_auth] Check and fix auth on GCE 
Bug: 410713357
Change-Id: I6d39641451d78c192321b77477a5e0f741715f85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6485110
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-24 14:21:42 -07:00
Ben Pastene
e62c712cec Only upload findings from presubmit recipe if on a tryserver 
Chrome's first use of appending location data to a PRESUBMIT.py check
made Chrome's "all" PRESUBMIT.py builders fail:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-presubmit

That's presumably because they're trying to upload findings in a
context without a gerrit CL. This should hopefully fix that.

Bug: 413427415
Change-Id: Ib2cab5d2668fa4562e6b2f365811983c93d0591e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6489610
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-04-24 14:13:46 -07:00
Scott Lee
9ae4995888 fix doc-string in GetFilesSplitByOwners 
Forgot to upload a new patchset with the fix before the submit
in https://crrev.com/c/6484531

Bug: 412904761
Change-Id: I811bd31aeab62f3732a7fb21789b66ee8aa66336
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6489290
Auto-Submit: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-24 14:02:15 -07:00
recipe-roller
cda5c51504 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716684524795976577

recipe_engine:
7a1a9e927f
  7a1a9e9 (sshrimp@google.com)
      Add a list tasks function to swarming module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I823520baf79de3cab10eeb89bb3780879b33c180
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6489728
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-24 11:33:48 -07:00
Scott Lee
b128c9967e split: update SelectReviewersForFiles to work with repository root 
The current implementation relies on the current working directory,
when it traverses the file tree to find the nearest OWNERS. It also
causes an infinite loop when it cannot find any OWNERS.

This CL changes the implementation so that it works
no matter what the cwd is.

Bug: 412904761
Change-Id: Ic4e25217aa64bd2eb6514ccdd486fe3b57a82312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6484531
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-24 08:36:02 -07:00
Scott Lee
829b580b57 set verbose=False for mirror.populate in _UpdateMirrorIfNotContains() 
In https://crrev.com/c/6442501, apply_patch_ref() was updated to
refresh the git cache when applying patches in gclient. However,
it causes an excessive number of logs to be created, particularly
for src/v8, as the repo has a huge number of branches.

This CL simply sets the verbose option with False,
ignoring the value in options.verbose.

Bug: 407795715
Change-Id: Ibf32ff67d23f41b398cca82372c17d7ca331db26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6486489
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2025-04-24 08:26:06 -07:00
recipe-roller
e1c9b12b81 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716700256893464081

recipe_engine:
2d2fd8172d
  2d2fd81 (olivernewman@google.com)
      [swarming] Pass through timestamp fields

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1268d4b8529fcc903e0dbd79322843b2392e2ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6485484
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-24 07:20:41 -07:00
Yiwei Zhang
aacf07dc8b presubmit: upload result as findings even when presubmit succeeds 
The presubmit script could succeed with warnings. We do want to show
those warnings in the Gerrit CL as well.

Change-Id: Iab6e420261d8cfc8baad18b3b2b8b6f9718776a8
Bug: 404837554
Recipe-Manual-Change: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6486226
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
 2025-04-23 19:49:27 -07:00
recipe-roller
cb4b983398 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8716753733088577745

recipe_engine:
855a980644
  855a980 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from eafff38687d8 to ae028be837da

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I34e994c686d5b68c4c4fce1bc32886f30158f979
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6485828
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-04-23 17:12:42 -07:00
Scott Lee
a7460c638b git_common: raise CalledProcessError with the given cwd, if set 
For example, SCM.Capture() calls git_common.run() with `cwd=value`,
which then gets passed to subprocess.Popen2().
: https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:scm.py;l=705-710;drc=e0c47c138ad4b0e6224a29e597dba5ca53e63ee0

Change-Id: I4b7e14e9f3fb10c1e779fc53d82aa7922194bd36
Bug: 412904761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6484452
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Scott Lee <ddoman@chromium.org>
 2025-04-23 13:10:41 -07:00
Gavin Mak
474ecb8462 Add --ignore-dep-type option to gclient sync 
This option is already available for gclient revinfo. Adding it
to gclient sync means we get to reuse the filtering logic
already being used for revinfo.

Bug: 411662322
Change-Id: I6bd5e1cffe583247a497358ada1e0b82d0be986d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6481194
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-04-23 10:32:11 -07:00
Yiwei Zhang
cc03c34e35 presubmit: upload findings only if resultdb is enabled 
Code findings will be uploaded to resultdb. If resultdb is not
enabled, exception will be thrown.

Bug: 404837554
Change-Id: I76ff82d6ecdd987fe08fdd703b67a1171d85eed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6479007
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-23 10:12:31 -07:00
Yiwei Zhang
e5cd6f84f0 include file_path in CheckJsonParses PRESUBMIT check 
This is to test new feature added in
https://issues.chromium.org/404837554

Bug: 404837554
Change-Id: I3da40202091e08d9104f2b69d2a372ed786b3d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6478701
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-04-22 16:39:21 -07:00
Allen Li
8f0df9fecf Roll git-credential-luci 
To pick up new info subcommand

Change-Id: I6f2189601930a67f51a831359d297fb82c6a0d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469938
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-22 14:29:58 -07:00
Yiwei Zhang
94eb88d04c presubmit: upload presubmit result as code findings 
The recipe will convert presubmit result to finding as long as it has
location data.

Change-Id: I8e0ce4cf5f66d6236f10c21a6db87d293b3fe379
Bug: 404837554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469944
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-22 14:14:57 -07:00
Yiwei Zhang
d49e17e19f presubmit: add location data to presubmit result 
This will help us to display preusbmit result as findings both in
Gerrit and in Cider workspaces.

Change-Id: I0f5a9c503c1b14dc8dcbf9794cc556ef215a46a2
Bug: 404837554
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469939
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-22 12:26:12 -07:00
Chan Li
5d891d2a8d [depot_tools] release led 
To include https://crrev.com/c/6449820

Change-Id: Iad55431fbe733cfaf558d382e38592b60ed30513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6476466
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 2025-04-21 11:46:46 -07:00
Devon Loehr
f6cb81eb4f [git cl split] Refactor description handling 
As part of an effort to make split_cl.py less monolithic, this
collects the parts of SplitCl related to the CL description, and
puts them into a separate function.

Bug: 389069356
Change-Id: I2d01c09799182cd57bcdd60bb000b59e3bc71aa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6470263
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Devon Loehr <dloehr@google.com>
 2025-04-18 07:10:31 -07:00
Allen Li
828d536eef [doc] Add some cred helper info 
Change-Id: Ie93ec79cf1708a07d48bb37042c7fac6036d9b62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6471152
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-17 15:16:07 -07:00
Gavin Mak
74c5a68653 Only check mirror existence for actual SHA-1 commit hashes 
Refine the post-mirror-update check in `_UpdateMirrorIfNotContains` to
verify only when the hash revision is a SHA-1 hash. This fixes a
regression where syncing refs under refs/changes/* fails because the
check was incorrectly applied to non-hash revision strings.

Bug: 407864212, 341208163
Change-Id: I07dfe29fa7f27f6c69fa281762779e305e83b91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469936
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-04-17 13:51:19 -07:00
Devon Loehr
a4b9f2a0c1 [git cl split] Refactor summary and validation in SplitCl 
As part of an effort to make split_cl.py more monolithic, this
separates out the code which summarizes the splitting, prompts
the user to edit it, and validates it afterwards.

This also fixes a bug where interactively-edited files bypassed branch validation.

Bug: 389069356
Change-Id: I498596a5ed624190fb355951049252c8b1d615fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469475
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2025-04-17 13:44:27 -07:00
Devon Loehr
aefad4bb1b [git cl split] Refactor git commands out of SplitCl 
As part of an effort to make split_cl.py less monolithic, this
separates out the part of SplitCl which gathers basic information
about the git repository.

Bug: 389069356
Change-Id: Ib005e352aa024dab8ff69417865d2d766732af0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6471062
Commit-Queue: Devon Loehr <dloehr@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2025-04-17 13:43:50 -07:00
Devon Loehr
3d62d2bdb5 [git cl split] Refactor splitting computation into separate function 
As part of a cleanup effort to make this script's major functions
less monolithic, this moves the part of SplitCL responsible for
computing a splitting into its own function.

Bug: 389069356
Change-Id: I1f8571d7bf27018da6c25263a05ad098e7d05836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6469473
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Devon Loehr <dloehr@google.com>
 2025-04-17 12:33:41 -07:00
Allen Li
463ce5a855 [git-credential-luci] Redirect to batch file on Windows 
I believe Git will try to run the file without extension (this bash
file) directly, which causes issues.

Bug: 410753790
Change-Id: I3a43dfd84e6459f64a023d3c656d8d3ff3b7bd5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6463456
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-04-16 15:10:39 -07:00
Allen Li
1fb0e39429 [git_auth] Add short blurb with manual setup instructions 
Might be useful for some folks, try adding this.

Bug: 410825515
Change-Id: I367298b8276758c25167aa520556fb63a175127f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6459926
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-16 14:28:14 -07:00
Allen Li
5d5475cdee [git_auth] Minor wording consistency fix 
Make it consistent with the other line that uses "yet"

Change-Id: I6cae354b61ac673bb4d93a878daf01cebbf67a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6459922
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-04-15 15:15:03 -07:00
Allen Li
d28539d200 [git_auth] Move gitcookies to free backup name 
Bug: 410576093
Change-Id: Ib2d9db97f4e4e1e8cfe1914ba7ffb881f9e16bbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6453918
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-04-15 14:54:46 -07:00
Allen Li
9d75b76ca5 [git_auth] Clarify which email to use 
Change-Id: Ic17568c3b6fd35772b3c7d5c9db8e62e207fb7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6456193
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-04-15 14:44:33 -07:00
Allen Li
c92c5fbe99 [git_auth] Always configure chrome-internal 
Most users who access this have SSO, but there are some people with,
e.g., read access without SSO.

So we may as well configure this always I guess, even if it's
nonfunctional for many people since they have no permission to any
repos on chrome-internal.

Change-Id: Ia560a64e7771f1438fb1527389a310bbbe951477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6456192
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-15 14:08:44 -07:00
Andrew Grieve
73a3fbf1fa autoninja.py: Make use_android_build_server enabled by default 
We're switching the GN arg to be default-enabled for local builds.

Bug: 404503040
Change-Id: I710b8fa38bf4ce97d592861b28a49b0bc867b702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6454372
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
 2025-04-15 07:03:49 -07:00
Allen Li
0aa5b44d94 [git_auth] Hint users to run with --global 
Some users just run creds-check which doesn't fix submodules.

Bug: 408501013
Change-Id: Iddb19e922aff8cb265638588595403ac193ead52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6449740
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-04-14 16:09:40 -07:00
Allen Li
0a7f853f9d [git_auth] Split repo configuring into standalone method 
Refactoring to enable running this logic recursively on submodules.

Change-Id: I3515d1659e1b619d262a62be91f0fe835f6df0d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6448584
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-04-14 14:59:48 -07:00
Allen Li
f3a8e0a209 [git_auth] Add _run_gerrit_host_configuration helper 
Refactoring to improve readability

Change-Id: I159565840f7c869d47a70beb22000d01c6279a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6448580
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-14 14:39:46 -07:00
Allen Li
3b66d05bd8 [git_auth] Inject Changelist dependency into ConfigWizard 
Otherwise it creates a dependency cycle.  This is needed if we want to
recurse into submodules.  Maybe this should be refactored more, but
this should be an improvement for now.

Change-Id: I4641e9ce1952bba81f717acbeefd59dd687d87ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6448579
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-04-14 13:33:58 -07:00
Tommy Chiang
f088ff9f1b [cpplint] add nolint region support 
Both the internal and community maintained cpplint support regional
nolint annotation NOLINTBEGIN/NOLINTEND.

Bug: 409733462
Change-Id: If738e8f6b8b30e88adec74383fecd8198fe70fbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6446042
Auto-Submit: Tommy Chiang <ototot@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Tommy Chiang <ototot@google.com>
 2025-04-11 16:26:40 -07:00
Arthur Milchior
cd6685b6c0 [siso]Adding import 
`shutil` was used in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6420348
but not imported, leading to error message when executing
_is_google_corp_machine

Bug: None
Change-Id: I0bec8986f531a31905dabaadd20af68c1cd5536f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6449462
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
 2025-04-11 07:15:47 -07:00