InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

[git_auth] Add _run_gerrit_host_configuration helper

Browse Source 
Refactoring to improve readability

Change-Id: I159565840f7c869d47a70beb22000d01c6279a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6448580
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
This commit is contained in:
Allen Li
2025-04-14 14:39:46 -07:00
committed by LUCI CQ
parent 3b66d05bd8
commit f3a8e0a209
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
git_auth.py
View File

@@ -481,11 +481,11 @@ class ConfigWizard(object):
# Internal state
self._user_actions = []
def run(self, *, force_global: bool):
def run(self, *, force_global: bool) -> None:
with self._handle_config_errors():
self._run(force_global=force_global)
def _run(self, *, force_global: bool):
def _run(self, *, force_global: bool) -> None:
self._println('This tool will help check your Gerrit authentication.')
self._println(
'(Report any issues to https://issues.chromium.org/issues/new?component=1456702&template=2076315)'
@@ -498,6 +498,12 @@ class ConfigWizard(object):
self._println('SSO helper is available.')
self._set_config('protocol.sso.allow', 'always', scope='global')
self._println()
self._run_gerrit_host_configuration(force_global=force_global)
self._println()
self._println('Successfully finished auth configuration check.')
self._print_actions_for_user()
def _run_gerrit_host_configuration(self, *, force_global: bool) -> None:
remote_url = self._remote_url_func()
if _is_gerrit_url(remote_url):
if force_global:
@@ -520,9 +526,6 @@ class ConfigWizard(object):
'Looks like we are running outside of a Gerrit repository,')
self._println('so we will check your global Git configuration.')
self._run_outside_repo()
self._println()
self._println('Successfully finished auth configuration check.')
self._print_actions_for_user()
def _run_outside_repo(self) -> None:
global_email = self._check_global_email()