InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,983 Commits 6 Branches 0 Tags
3ad54e4fef93b6703e8b3d3839c6f9881dbffb74
Commit Graph

11983 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Android Open Source Project
3ad54e4fef repo: Update from upstream 
- 622a5bf9c2937fbfc631ccc30d5debf74010361d init: change --manifest-depth default to 1 by Mike Frysinger <vapier@google.com>

GitOrigin-RevId: 622a5bf9c2937fbfc631ccc30d5debf74010361d
Change-Id: If3639895ae80dadf8586da8033e0591a3b68da78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7396404
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Copybara Service <copybara-worker-blackhole@google.com>
 2026-01-06 10:49:36 -08:00
Gavin Mak
b084cd665f Fix CheckForCommitObjects to check missing gitlink changes 
https://crrev.com/c/7234371 made some optimizations to the check
but caused it to start missing changes that modified DEPS but not
the corresponding gitlink.

Fix the check by doing a full tree scan when DEPS is updated.

Bug: 469784282
Change-Id: Ibdcdcb1af5a330e4d9e96daecd28e06bc1436022
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7362007
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josiah Kiehl <kiehl@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2026-01-06 10:36:28 -08:00
Gennady Tsitovich
90eb3fe8ba Add --allow-conflicts option to git cl cherry-pick 
This CL adds a new --allow-conflicts flag to the `git cl cherry-pick`
command. This allows users to create cherry-pick CLs on Gerrit even if
they result in merge conflicts. The created CL will be in a WIP state,
allowing the user to resolve conflicts in the Gerrit UI or locally.

Additionally, this CL:
- Updates `CMDcherry_pick` to print a regex-friendly warning if the
  created cherry-pick contains conflicts:
  "Warning: Change <URL> contains merge conflicts"
  (needed for the Chrome Cherry Picker)
- Fixes some existing test failures in `gerrit_util_test.py` related to
  authentication mocking in the current environment.
- Adds unit tests for the new flag in both `git_cl_test.py`
  and `gerrit_util_test.py`.

Bug: 439992429
Change-Id: I306e21329688a31a63c9996f1405f5ef5ad07108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7319362
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gennady Tsitovich <gtsitovich@google.com>
 2026-01-06 03:47:38 -08:00
Alex Ovsienko
e04940f5e8 siso: always set the collector address, do not assume default behavior. 
Bug: b/455433899
Change-Id: Ib8c0c3041cac5491e70986c0e7a60d386a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7367697
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2026-01-06 00:14:32 -08:00
Alex Ovsienko
daf2602023 siso: introduce flag check for collector by checking its help page. 
Bug: b/473530378, b/455433899
Change-Id: I09f53cd181cc3cd516e2fa035616efb06a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7365204
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2026-01-05 22:01:04 -08:00
Alex Ovsienko
6e87d87cd5 siso: add test case where collector returns false to make sure the collector flag does not get appended. 
Bug: b/455433899
Change-Id: Id1cb3b6b0eabcbc8997b66be1849beba6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7367695
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2026-01-05 19:28:07 -08:00
recipe-roller
ffa2705be4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8693480376888585425

recipe_engine:
a4653f8b5d
  a4653f8 (olivernewman@google.com)
      [swarming] Expose tags on TaskResult class

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6f47f74c50c85e8bc8ff5fc87b2d944171d02d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7396693
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2026-01-05 13:30:49 -08:00
recipe-roller
17d7b7e779 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8693513095504278257

recipe_engine:
bb4d415c66
  bb4d415 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 5e300e7145cd to 353e493012d2

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9598c0fe4c41394cc285d4fa4d0f7b8456f972bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7389072
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2026-01-05 04:53:14 -08:00
Alex Ovsienko
d80f3ba240 siso: have checks for collector presence in the flags verification. 
Bug: b/455433899
Change-Id: Ia366d343e14f10d0cebf32c5a12bedd06a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7387808
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2026-01-05 01:43:39 -08:00
Junji Watanabe
0847ade509 Revert "siso: enable collector by default when metrics collection is on." 
This reverts commit a4318057fe.

Reason for revert: This seems to break builds with old Siso version.

Original change's description:
> siso: enable collector by default when metrics collection is on.
>
> Bug: b/455433899
> Change-Id: Icdc8f0fb516ed9782f85a935d733b9f26a6a6964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7366313
> Commit-Queue: Alex Ovsienko <ovsienko@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>

Bug: b/455433899
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I819a7271979e122d39a283dc376fc80fc741125b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7394760
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
 2026-01-04 23:01:08 -08:00
Alex Ovsienko
a4318057fe siso: enable collector by default when metrics collection is on. 
Bug: b/455433899
Change-Id: Icdc8f0fb516ed9782f85a935d733b9f26a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7366313
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2026-01-04 17:12:01 -08:00
recipe-roller
967382fdcd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8694736782810129329

recipe_engine:
4063867bd7
  4063867 (jbettis@google.com)
      Fix index out of range error

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6d1936714c6d14534cb3cfe5d299700022c16283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7301487
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-12-22 16:41:38 -08:00
recipe-roller
522a0d7bc3 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8695016752459418833

recipe_engine:
cdde04afdd
  cdde04a (iannucci@chromium.org)
      [TurboCI] Fix fake to have more internal coherency.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I905d08d09ee00f4b5dde596afc58e6b7d2a36fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7281347
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-12-19 14:32:00 -08:00
Robert Iannucci
2b5f71d194 Fixup bot_update for new proto changes. 
This is the depot_tools counterpart to
https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/7275338

R=gbeaty@google.com

Change-Id: Ic98cc7c6196278f4f40b1fb421e0045aa2579af2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7277679
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@google.com>
 2025-12-19 11:10:58 -08:00
Garrett Beaty
d76f3b043d Update lucicfg to 1.46.2 
1.46.2 updates the findRoot implementation to look for the repo boundary
of a cider workspace by looking for the .citc directory in the parent
directory since it gets created as a sibling to the top-level repo
rather than inside the repo. This allows for correctly computing the
path within the repo to the starlark package.

Bug: 468387469
Change-Id: I1a513086f6f27198618d0cb76351bb40d2a1b219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7279490
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2025-12-19 09:58:32 -08:00
Alex Ovsienko
24755bc6ee Disable pytest for vscode integration. 
vscode gets confused about which test provider to use. As such, disable pytests as most of our tests are in unittest.

Change-Id: I42c0b54b2d2b8d081137dbd23a171ff56a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7273065
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-12-18 15:48:19 -08:00
Lukasz Anforowicz
49e90f2d01 Update python version requested by depot_tools/yapf. 
Fixed: 469798122
Change-Id: I210ef6f00aeb6923220011695b89faeae8dd8e80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7270985
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
 2025-12-18 14:27:16 -08:00
recipe-roller
123c56438b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8695117416537464737

recipe_engine:
8de157ed85
  8de157e (olivernewman@google.com)
      [warnings] Use relative paths in warning reports

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie3f2fbfc413a9b67b55ce7ad99e1a84119a4c1af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7275340
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-12-18 11:52:51 -08:00
Lily Chen
2fb3dfc9f8 Add got_revision mapping for boringssl 
Start tracking 'got_revision' for boringssl. This is necessary because the presubmit recipe module expects to get a non-zero number of `got_revision_properties` for the project, and not having this map entry causes the (newly added) boringssl presubmit builder to crash:
See https://ci.chromium.org/ui/p/boringssl/builders/try/presubmit/b8695219221091273601/overview

Recipe-Nontrivial-Roll: build
Change-Id: I00034c42b835b12c62484ebae50a15b41c3c5c63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7266531
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Lily Chen <chlily@chromium.org>
 2025-12-18 09:43:01 -08:00
Allen Li
70179d9d84 gerrit_util: Check user has set usehttppath for reauth 
This is in the Git config so it's easy to go unnoticed.

Bug: 462126685
Change-Id: I1ccd21efce580aebfcc8a5a6bef2f7d78e5e75d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7265723
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-12-17 16:58:11 -08:00
Alex Ovsienko
30e928fe1c Fix possibly unbound Body by assigning preassigning them the else case and overriding them in the if case. 
The current case will work until eiether the has_chunk_header above or below the _process_diff function changes, and then it will cause runtime crash as one cannot concat string and None.

Change-Id: I81737328f609e636bcee5087a2bc4aa96a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7260374
Reviewed-by: Brian Egizi <begizi@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-17 16:09:22 -08:00
Alex Ovsienko
02f1c0f8b7 siso: rewrite the entire siso test to pytest. 
With this tests will be easier to read and support.

Also have improved parameterized tests.

The reason why pytest was picked is because as my knowledge goes this is the most up to date and supported unit test framework in Python. The current parameterized tests state is primitive, and the parameterized library was last updated 2 years ago. pytest will help us adopt best practices that later perhaps we could spread to other unit tests in depot_tools.

Bug: 459690822
Change-Id: I67d16b56ff3c4dbd260ea0b07354ef766a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7246550
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2025-12-17 16:05:19 -08:00
equinoxtian
7b56ac47e6 Fix .cipd_impl.ps1 failure because of execution policy 
The introduction of the `-File` parameter for invoking .cipd_impl.ps1
made its execution dependent on the system's PowerShell ExecutionPolicy,
causing failures in restricted environments.

This CL solves following problems:

1. Failures when the depot_tools path contains whitespace.

2. Make cipd.bat behave consistently with how it did before introducing
   '-File'

Bug: 428834916
Change-Id: Idf16bfeb5d5188dc4a13ab3200f692d99b3d33af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7257554
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Sam Lewis <samclewis@google.com>
Commit-Queue: Sam Lewis <samclewis@google.com>
 2025-12-17 11:03:54 -08:00
Allen Li
d3d038869a git_auth: Handle conflicting stale local config (reland) 
As we prefer configuring the global config, it's possible to leave
stale local config behind if the user is swapping between emails.

Originally:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7213753

Fixed to skip clearing local config when not inside a repo (as that errors).

Bug: 466343784
Change-Id: I8b34d24ba3966c66aeebaf11bd0368dfb4b0da28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7265721
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-12-16 17:19:31 -08:00
Alex Ovsienko
3523d11c22 Enable unit test integration for vscode users. 
.vscode folder will be picked up for every vscode that opens this project, and the config makes it so that tests are ran with vpython3.

Change-Id: Ide0566287dde36b914dd55053daba4d36a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7262695
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2025-12-16 16:09:00 -08:00
recipe-roller
e77a606b2c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8695290432141183969

recipe_engine:
58ce65fff2
  58ce65f (mohrr@google.com)
      Reland "Reland "[proto_support] Add support for inline proto de...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id415278a5d555abb1b1fbb7e561d979afe249754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7264407
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-12-16 13:59:40 -08:00
Lauren Minchin
276d76ecbd Add presubmit check for AyeAye analyzers in depot_tools 
Bug:467912454
Change-Id: I0ba63bea18533e89e1da00f4bb073d5d749bc007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7252696
Commit-Queue: Lauren Minchin <lminchin@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-12-16 05:05:01 -08:00
Alex Ovsienko
d29cc8d7bb FIx missing import of urllib.error. Also remove unneeded time import. 
Change-Id: I708e13ea6fd56ceec2cd6faa0928448b6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7260375
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Nico Weber <thakis@google.com>
 2025-12-15 18:27:40 -08:00
Alex Ovsienko
3aee16b5f6 Fix unintended comma in clang format exception raising. 
Change-Id: I56bc5a8c2a778172617ac2ce2bd7fb776a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7259616
Auto-Submit: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2025-12-15 09:47:10 -08:00
Alex Ovsienko
c34ff73940 siso: finish making all function type strict with type hints. 
Change-Id: I704549b7d8d27675de0100e7ab6bf9476a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7260155
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2025-12-15 02:20:54 -08:00
Alex Ovsienko
5e033c9735 siso: disable linter on staticly inferable check that original_sigint_handler is callable. 
Change-Id: I6429a0f91a52449438938e4c82df51e96a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7259440
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-15 02:15:21 -08:00
Alex Ovsienko
01b382b301 Simplify build_telemetry by having it load config immediately when initializing class. 
This avoid check for possibly null self._config as now it's always non null.

Change-Id: I74075fec96898996f10d1f2589fe3c9f6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7259442
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2025-12-15 00:17:56 -08:00
Alex Ovsienko
a9534daf99 Remove startswith('win') from autoninja and siso. 
Windows can only be win32, and that holds to this day: https://docs.python.org/3.15/library/sys.html#sys.platform. Using this allows us to use better vscode integration of system checking and lines greyouts: https://screenshot.googleplex.com/8gkNyfPKMB9GPeU.

Change-Id: If9ab97bc30ab80df96b1aced0e78b0706a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7259617
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2025-12-15 00:00:49 -08:00
Garrett Beaty
883e6b91c0 Enable setting a TurboCI check ID when deapplying a patch 
This will enable Browser try builders to create source checks when
deapplying the patch to try and exonerate failed tests.

Bug: b/443496677
Change-Id: I96a6cf3acb9e67c0b4cc7bd8132cd8d6de5f06c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7237784
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
 2025-12-12 10:18:12 -08:00
Josiah Kiehl
4244c70855 Handle Windows command line limits in CheckForCommitObjects. 
On Windows, the command line has a character limit of 8191. When checking for commit objects in submodules, the `git ls-tree` command can become very long if many files are affected, potentially exceeding this limit.

This change modifies `CheckForCommitObjects` to check the estimated length of the `git ls-tree` command when running on Windows. If the command line with all affected files would exceed the limit, it falls back to using a recursive `ls-tree` (`-r`) instead of listing each file individually. This prevents command line overflow errors on Windows.

Change-Id: I6a340baefee57f5933473add0601a42ff1e61bb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7254474
Auto-Submit: Josiah Kiehl <kiehl@google.com>
Commit-Queue: Josiah Kiehl <kiehl@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-12-11 18:23:44 -08:00
Alex Ovsienko
cd4db8fd7f Add coverage library to vpython3 so that we can have better insight in how we stand wrt our test coverage in depot_tools. 
Bug: b/459690822
Change-Id: I17d67e0530755fa9c07bbc4dabf6d81b6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7244730
Auto-Submit: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-10 09:45:57 -08:00
Alex Ovsienko
ecbf89e1da siso: remove redundant test and consolidate dead then healthy tests. 
Bug: b/459690822
Change-Id: I7e3a342d3e5be7b5802275cdce0db2ec6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7244732
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-09 22:48:30 -08:00
Alex Ovsienko
a6671ce6c7 siso: consolidate collector kill tests for posix and windows. 
Bug: b/459690822
Change-Id: If23c54307a76ecba19e856da145e66736a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7244731
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2025-12-09 22:19:50 -08:00
Alex Ovsienko
ff6558d2ee siso: remove usage of platform library from siso.py 
Bug: b/455433899
Change-Id: Iff65cbfd920c93114b784bce8ded91ec6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7237760
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Philipp Wollermann <philwo@google.com>
 2025-12-09 21:48:33 -08:00
Josiah Kiehl
7c09ebfd12 Optimize CheckForCommitObjects by batching git ls-tree operations 
Significantly reduces the execution time of presubmit checks by
optimizing CheckForCommitObjects.

For CLs with fewer than 1000 affected files, run `git ls-tree` only on
specific files instead of scanning the full tree. This yields a ~70x
speedup (~0.97s -> ~0.01s) for typical CLs.

Change-Id: Ia8b89dbb14a5129ba79944282deba52a3558bdf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7234371
Commit-Queue: Josiah Kiehl <kiehl@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-12-09 15:07:14 -08:00
Ben Joyce
0861b0e55c Add structured test id experiment for presubmit tests 
Presubmit tests need a module scheme and module name arg added
for the new structured test id format.

Support for the structured test ids was added in:

https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7173696

The experiment will be enabled on presubmit builders in:

https://chromium-review.googlesource.com/c/chromium/src/+/7230947

This is similar to the change adding the module scheme and name in: https://source.corp.google.com/h/chromium/chromium/tools/build/+/main:recipes/recipe_modules/chromium_tests/resultdb.py;drc=c4623988e11815a8111f7cea4fbaeb3e63712f25;l=221

Bug: 418015486
Change-Id: Iaf42e5cf173754302648ab7e27fc39b8b8c8732b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7231163
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Benjamin Joyce (Ben) <bjoyce@google.com>
 2025-12-09 13:38:00 -08:00
Josiah Kiehl
b48cbb3e60 Optimize CheckForCommitObjects presubmit check 
This CL optimizes CheckForCommitObjects in two ways:
- Fast Path: If the raw `git ls-tree` output does not contain `160000` (gitlink mode), return early. This avoids parsing entirely for repositories without submodules at the cost of about 3ms.
- Iterative Parsing: For repositories with submodules, use an iterative find loop to locate gitlink entries instead of splitting the entire tree content.

On the Chromium repo:
- Speed: The parsing step is ~7.7x faster (0.04s vs 0.30s).
- Memory: Saves ~78 MB of memory per run by avoiding the creation of ~300,000 string objects during the split.

I also added tests now that it's more than a simple loop.

Change-Id: I903effc50aaedb9130772491ad38385b22477d58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7231149
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josiah Kiehl <kiehl@google.com>
 2025-12-09 10:55:42 -08:00
Josiah Kiehl
82130f468a Speed up presubmit by caching code-owners check 
Currently, presubmit queries the gerrit server every run to check if the
code-owners plugin is enabled.

This CL caches that result in a /tmp file per repository.

This saves as much as 1.5s per `git cl presubmit`.

Change-Id: I1a3631074d1bcbb1a254caa6654fd8434f069aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7227749
Commit-Queue: Josiah Kiehl <kiehl@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2025-12-09 10:50:31 -08:00
Lauren Minchin
f520a9305e Add canned check for AyeAye analyzers 
Bug:b/464253715
Change-Id: I86bff67eac3aeae00cac9798cb9237e7c5364b10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7237916
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Lauren Minchin <lminchin@google.com>
 2025-12-09 10:46:52 -08:00
recipe-roller
3f0c3aaedc Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8695944110102097041

recipe_engine:
48fcf7d9a2
  48fcf7d (mnck@google.com)
      Revert "Reland "[proto_support] Add support for inline proto de...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2b58a10eba7b50313de83c06b16a5c34666945da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7241230
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-12-09 08:49:10 -08:00
Alex Ovsienko
6cd31a3b57 siso: have siso.py control if collector creates socket file. 
Bug: b/455433899
Change-Id: Ic02cd97ef3db59263859eeab5cd70f986a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7231248
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-09 01:16:10 -08:00
Alex Ovsienko
fc502860ed siso: integrate collector call. 
Bug: b/455433899

Change-Id: Id72ff71e1b4269b828658c90461ba4b46a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7205886
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-09 01:01:29 -08:00
recipe-roller
4c6437f269 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8696023386706400977

recipe_engine:
17a07aa09c
  17a07aa (mohrr@google.com)
      Reland "[proto_support] Add support for inline proto defs"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I097e9e27b8cc294b6aaca215326d077201c6dbf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7237783
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-12-08 11:50:14 -08:00
Alex Ovsienko
ac1b095b09 siso: do not restart the collector if projects don't match. 
The correct project is set at runtime by siso.

Bug: b/455433899
Change-Id: Ibe1d348729e53425f27812e83a5c7f466a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7234199
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2025-12-07 20:39:43 -08:00
Alex Ovsienko
f8cc59a94b siso: create _start_collector function. 
It will run only when collector subcommand is present and attempt at handling the start and restart when needed.

Bug: b/455433899
Change-Id: I9a8b8001aec29b6ca3db61ec6150deb86a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7183447
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-12-07 15:57:33 -08:00