InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 02:31:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

siso: add test case where collector returns false to make sure the collector flag does not get appended.

Browse Source 
Bug: b/455433899
Change-Id: Id1cb3b6b0eabcbc8997b66be1849beba6a6a6964
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7367695
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
This commit is contained in:
Alex Ovsienko
2026-01-05 19:28:07 -08:00
committed by LUCI CQ
parent ffa2705be4
commit 6e87d87cd5
1 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/siso_test.py
View File

@@ -181,6 +181,25 @@ def test_apply_telemetry_flags_sets_expected_env_var(siso_subcmd_present: Any,
assert env.get("GOOGLE_API_USE_CLIENT_CERTIFICATE") == "false"
def test_apply_telemetry_flags_collector_not_present(mocker: Any) -> None:
def mock_subcommand(_: str, subcmd: str) -> bool:
if subcmd == "collector":
return False
return True
mocker.patch("siso._is_subcommand_present", side_effect=mock_subcommand)
args = ["ninja", "-C", "out/Default", "--metrics_project", "some_project"]
env = {}
want = [
"ninja", "-C", "out/Default", "--metrics_project", "some_project",
"--enable_cloud_monitoring", "--enable_cloud_profiler",
"--enable_cloud_trace", "--enable_cloud_logging"
]
got = siso.apply_telemetry_flags(args, env, "siso_path")
assert got == want
@pytest.mark.parametrize("args, env, want", [
pytest.param(
["--metrics_project", "proj1"], {}, "proj1", id="metrics_project_arg"),