mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
137adde33d
Some methods currently support a single platform only, but we may be able to support multiple platforms. This patch prepares the option-structs for multi-platform support, but (for now) returning an error if multiple options are provided. We need a similar check on the daemon-side, but still need to check on the client, as older daemons will ignore multiple platforms, which may be unexpected. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
95 lines
2.5 KiB
Go
95 lines
2.5 KiB
Go
package client
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
|
|
cerrdefs "github.com/containerd/errdefs"
|
|
ocispec "github.com/opencontainers/image-spec/specs-go/v1"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
func TestImageImportError(t *testing.T) {
|
|
client, err := NewClientWithOpts(WithMockClient(errorMock(http.StatusInternalServerError, "Server error")))
|
|
assert.NilError(t, err)
|
|
_, err = client.ImageImport(context.Background(), ImageImportSource{}, "image:tag", ImageImportOptions{})
|
|
assert.Check(t, is.ErrorType(err, cerrdefs.IsInternal))
|
|
}
|
|
|
|
func TestImageImport(t *testing.T) {
|
|
const (
|
|
expectedURL = "/images/create"
|
|
expectedOutput = "outputBody"
|
|
)
|
|
tests := []struct {
|
|
doc string
|
|
options ImageImportOptions
|
|
expectedQueryParams url.Values
|
|
}{
|
|
{
|
|
doc: "no options",
|
|
expectedQueryParams: url.Values{
|
|
"fromSrc": {"image_source"},
|
|
"repo": {"repository_name:imported"},
|
|
},
|
|
},
|
|
{
|
|
doc: "change options",
|
|
options: ImageImportOptions{
|
|
Tag: "imported",
|
|
Message: "A message",
|
|
Changes: []string{"change1", "change2"},
|
|
},
|
|
expectedQueryParams: url.Values{
|
|
"changes": {"change1", "change2"},
|
|
"fromSrc": {"image_source"},
|
|
"message": {"A message"},
|
|
"repo": {"repository_name:imported"},
|
|
"tag": {"imported"},
|
|
},
|
|
},
|
|
{
|
|
doc: "with platform",
|
|
options: ImageImportOptions{
|
|
Platform: ocispec.Platform{
|
|
Architecture: "amd64",
|
|
OS: "linux",
|
|
},
|
|
},
|
|
expectedQueryParams: url.Values{
|
|
"fromSrc": {"image_source"},
|
|
"platform": {"linux/amd64"},
|
|
"repo": {"repository_name:imported"},
|
|
},
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.doc, func(t *testing.T) {
|
|
client, err := NewClientWithOpts(WithMockClient(func(req *http.Request) (*http.Response, error) {
|
|
assert.Check(t, assertRequest(req, http.MethodPost, expectedURL))
|
|
query := req.URL.Query()
|
|
assert.Check(t, is.DeepEqual(query, tc.expectedQueryParams))
|
|
return mockResponse(http.StatusOK, nil, expectedOutput)(req)
|
|
}))
|
|
assert.NilError(t, err)
|
|
result, err := client.ImageImport(context.Background(), ImageImportSource{
|
|
Source: strings.NewReader("source"),
|
|
SourceName: "image_source",
|
|
}, "repository_name:imported", tc.options)
|
|
assert.NilError(t, err)
|
|
defer func() {
|
|
assert.NilError(t, result.Close())
|
|
}()
|
|
|
|
body, err := io.ReadAll(result)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(string(body), expectedOutput))
|
|
})
|
|
}
|
|
}
|