Hash the container ID, mount source and destination together to form a
layer name.
This ensures the generated names are filesystem-friendly and don't
exceed path length limits while maintaining uniqueness across different
mount points and containers.
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
The http.Client passed into client.WithHTTPClient() is modified by the
constructor in-place: the value of its Transport field is mutated and
wrapped in an OpenTelemetry decorator. This can lead to very surprising
behaviour when a second client is constructed reusing the same
http.Client value. If the http.Client is configured for TLS, the second
client will fail to detect that and will incorrectly dial the Engine API
socket as cleartext HTTP. Copy the provided http.Client so our
modifications don't leak out to unexpected places.
Signed-off-by: Cory Snider <csnider@mirantis.com>
Minor enhancement / follow-up to c8aaeea285c63f9add09e01bd8260d1bce61a97d;
make sure we never attempt to find `go.mod` files in other locations.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When attempting to read a (malformed) resolv.conf with a very long line,
a obscure error would be produced that didn't provide much context to
identify the problem;
Handler for POST /v1.51/containers/mariadb11/start returned error: bufio.Scanner: token too long
This patch adds some additional error-handling to detect this situation,
and includes the filename of the resolv.conf to help the user locating
the file that failed to be parsed.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The "param" field was only used to generate the error-message, and the
produced error-message was missing a space so we may as well just inline it.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Add nil check before calling EventsService.Close() to prevent panic
when daemon.EventsService is not initialized during shutdown.
Signed-off-by: jinda.ljd <jinda.ljd@alibaba-inc.com>
Clarify what the /images/{name}/tag endpoint does by explaining that
it creates an additional reference (tag) to the source image, and that
existing tags will be overwritten.
The previous description "Tag an image so that it becomes part of a
repository" was unclear about what the operation actually does.
Fixes#22402
Signed-off-by: majiayu000 <1835304752@qq.com>
Document that when a health check command exceeds its configured
timeout, the process is forcibly terminated. This clarifies the
behavior for users who need predictable handling of hung health
check commands.
Fixes#45927
Signed-off-by: majiayu000 <1835304752@qq.com>
The API documentation incorrectly stated that the Data field for
secrets and configs should use Base64-url-safe-encoded format
(RFC 4648 section 5). However, Docker actually uses standard base64
encoding (RFC 4648 section 4).
This caused confusion when users tried to use URL-safe base64 encoding
and received "illegal base64 data" errors.
Update the documentation to correctly reference RFC 4648 section 4
(standard base64) instead of section 5 (URL-safe base64).
Fixes#37671
Signed-off-by: majiayu000 <1835304752@qq.com>
Update the memory stats documentation to clarify differences between
cgroups v1 and v2:
- Add cgroups v2 formula for calculating used_memory using inactive_file
instead of cache field which is not available in v2
- Update memory_stats.stats description to explain that field names
differ between v1 (cache, rss, mapped_file) and v2 (file, anon, inactive_file)
Fixes#43810
Signed-off-by: majiayu000 <1835304752@qq.com>
The API documentation had incorrect descriptions for these fields:
- `/version` endpoint's `Arch` field was described generically but actually
returns the Go runtime's GOARCH value
- `/info` endpoint's `Architecture` field incorrectly stated it returns
GOARCH, but it actually returns the OS-reported hardware architecture
(equivalent to `uname -m`)
This commit corrects the descriptions to accurately reflect the
implementation.
Fixes#49594
Signed-off-by: majiayu000 <1835304752@qq.com>
