Commit Graph

54807 Commits

Author SHA1 Message Date
Sebastiaan van Stijn
5bfc628e97 client: make ImageImportResult an interface
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-11-03 18:01:42 +01:00
Sebastiaan van Stijn
5fc866fbfd client: make ImageLoadResult an interface
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-11-03 16:28:35 +01:00
Sebastiaan van Stijn
1051c7f89e client: Client.ImageLoad: move description of platform parameter
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-11-03 16:28:35 +01:00
Sebastiaan van Stijn
bb27db85fb Merge pull request #51382 from thaJeztah/add_replace
go.mod: add back replace rules
2025-11-03 16:28:27 +01:00
Sebastiaan van Stijn
b30eb86b31 go.mod: add back replace rules
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-11-03 16:08:47 +01:00
Rob Murray
0b8fa46230 Merge pull request #51369 from dohrisalim/issue#50159
integration-cli: migrate TestAPIStatsContainerNotFound to integration tests
2025-11-03 14:46:21 +00:00
Albin Kerouanton
ada61040e0 Merge pull request #51379 from AkihiroSuda/validate-rootlesskit-net
dockerd-rootless.sh: reject DOCKERD_ROOTLESS_ROOTLESSKIT_NET=host
2025-11-02 16:57:45 +01:00
Albin Kerouanton
7aa44d98cb Merge pull request #51380 from AkihiroSuda/fix-dockerd-rootless.sh
dockerd-rootless.sh: restore missing `exit 1`
2025-11-02 16:56:07 +01:00
Salim Dohri
9b749d7c85 integration-cli: migrate TestAPIStatsContainerNotFound to integration tests
Migrate TestAPIStatsContainerNotFound from the deprecated integration-cli
test suite to the modern integration test framework in integration/container.

The test verifies that the container stats API returns a NotFound error
for non-existent containers, testing both streaming and non-streaming modes.

Changes made:
- Migrated test to integration/container/stats_test.go using standard
  Go testing patterns
- Refactored to use test array pattern for better test organization
- Removed test from integration-cli/docker_api_stats_test.go
- Removed unused imports from integration-cli file
- Removed Windows skip as it may not be necessary

Signed-off-by: Salim Dohri <dohri.salim@gmail.com>
2025-11-02 10:46:22 +01:00
Akihiro Suda
b6dab24a43 dockerd-rootless.sh: restore missing exit 1
Fix a regression in 7e63d2a (PR 51149)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2025-11-02 16:56:00 +09:00
Akihiro Suda
76b1d304e4 dockerd-rootless.sh: reject DOCKERD_ROOTLESS_ROOTLESSKIT_NET=host
`rootlesskit --net=host` does not work with Docker.

Alternative ways to run Rootless Docker without the network overhead:
- Use https://github.com/rootless-containers/bypass4netns
- Or, use `docker run --net=host` with a PR 47103 (WIP)

See issue 51363

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2025-11-02 16:43:43 +09:00
Sebastiaan van Stijn
5ac561ff8c Merge pull request #51373 from thaJeztah/no_exclude
go.mod: remove "exclude" rules
2025-10-31 19:32:08 +01:00
Paweł Gronowski
bb45a3f4a0 Merge pull request #51371 from thaJeztah/min_api_version
daemon/config: export "min-api-version" through daemon.json
docker-v29.0.0-rc.2 v2.0.0-beta.1
2025-10-31 19:30:04 +01:00
Paweł Gronowski
5493dae4d8 Merge pull request #51372 from vvoland/vendor-client
vendor: github.com/moby/moby/client v0.1.0-beta.3
2025-10-31 19:25:04 +01:00
Sebastiaan van Stijn
5369540dd2 go.mod: remove "exclude" rules
These unfortunately prevent "go install github.com/moby/moby/v2/cmd/dockerd@XXX"
from working. Let's see if that works if we remove these. We may want to
add them back for the GA release of v29, but OTOH, nobody should have the
v2 module as dependency, so maybe it's not the end of the world.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-31 19:20:52 +01:00
Sebastiaan van Stijn
9b8419f6ed daemon/config: export "min-api-version" through daemon.json
Allows the minimum API version to be set through the daemon.json,
e.g. "min-api-version": "1.24"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-31 19:15:18 +01:00
Paweł Gronowski
3d772829ba vendor: github.com/moby/moby/client v0.1.0-beta.3
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-31 19:14:15 +01:00
Paweł Gronowski
64df04c897 Merge pull request #51370 from vvoland/vendor-api
vendor: github.com/moby/moby/api v1.52.0-beta.4
client/v0.1.0-beta.3
2025-10-31 19:11:57 +01:00
Paweł Gronowski
93c273dc11 vendor: github.com/moby/moby/api v1.52.0-beta.4
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-31 18:57:59 +01:00
Paweł Gronowski
3d96d16e7a Merge pull request #51338 from vvoland/drop-replace
client: Drop replace rules
api/v1.52.0-beta.4
2025-10-31 18:55:28 +01:00
Paweł Gronowski
56bd456694 Drop replace rules
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-31 18:41:46 +01:00
Sebastiaan van Stijn
ba3f5f56dc Merge pull request #51368 from vvoland/hack-vendor-dropreplace
hack/vendor: Make dropreplace vendor latest version
2025-10-31 18:23:12 +01:00
Sebastiaan van Stijn
42eb0aa973 Merge pull request #51360 from AkihiroSuda/deprecate-cgroup1
Deprecate cgroup v1
2025-10-31 17:41:23 +01:00
Paweł Gronowski
1e56b87f7f hack/vendor: Make dropreplace vendor latest version
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-31 17:24:21 +01:00
Paweł Gronowski
76ba3b6a4b Merge pull request #51366 from vvoland/client-removeimagecreate
client: Remove ImageCreate in favor of ImagePull/ImageImport
2025-10-31 16:36:38 +01:00
Sebastiaan van Stijn
455e4e523f Merge pull request #51269 from austinvazquez/refactor-client-network
client: refactor create network api implementation to define options/result struct
2025-10-31 15:46:53 +01:00
Paweł Gronowski
73455ce01a client: Remove ImageCreate in favor of ImagePull/ImageImport
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-31 14:48:54 +01:00
Sebastiaan van Stijn
560dfb13c9 Merge pull request #51362 from vvoland/inspcet-config-nonnil
api/container_inspect: Ensure Config is not nil in inspect response
2025-10-31 13:49:01 +01:00
Paweł Gronowski
fd1593c067 api/container_inspect: Ensure Config is not nil in inspect response
Ensure that the JSON response for the `GET /containers/{name}/json`
outputs an empty object instead of a nil config.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-31 12:41:39 +01:00
Paweł Gronowski
3287abc965 Merge pull request #51187 from thaJeztah/bump_test_cli
Dockerfile: update integration-cli CLI to v25.0.5
2025-10-31 11:51:12 +01:00
Sebastiaan van Stijn
6aea8c2591 Dockerfile: update integration-cli CLI to v25.0.5
Now that we're raising the minimum API version, we can also update
the CLI used in our integration-cli tests.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-31 09:22:40 +01:00
Akihiro Suda
4bcd446f03 Deprecate cgroup v1
Fix issue 51111

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2025-10-31 17:00:33 +09:00
Austin Vazquez
a087d03e0c client: refactor create network api implementation to wrap options/results
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
2025-10-30 23:45:18 -05:00
Sebastiaan van Stijn
d96f50518f Merge pull request #51359 from thaJeztah/move_version_types
api/types: move Version to api/types/system
2025-10-31 03:15:17 +01:00
Sebastiaan van Stijn
b77f2055f7 Merge pull request #51219 from ricardobranco777/selinux
integration/container: Make tests runnable on SELinux enabled daemon
2025-10-31 02:46:39 +01:00
Sebastiaan van Stijn
12c9de37e9 api/types: move Version to api/types/system
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-31 02:09:38 +01:00
Sebastiaan van Stijn
f6ee11fe60 Merge pull request #51357 from thaJeztah/internalize_pushresult
api/types: remove PushResult type, and move internal
2025-10-31 02:02:06 +01:00
Austin Vazquez
ec3b3a235d Merge pull request #51358 from thaJeztah/add_deprecated_version_fields
client: ServerVersionResult: add back legacy fields
2025-10-30 19:45:33 -05:00
Sebastiaan van Stijn
3d28cb8bbd client: ServerVersionResult: add back legacy fields
Short term solution; we need to decide whether these should be kept
or removed.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-31 01:21:10 +01:00
Sebastiaan van Stijn
d7bd5092d9 Merge pull request #51356 from robmry/compat-replace-nil-pointer
API compat: replace nil values when adding fields
2025-10-31 01:13:20 +01:00
Sebastiaan van Stijn
ebe464ea45 api/types: remove PushResult type, and move internal
This type was used as Aux message for docker push, was not documented,
and only present for Docker Content Trust (which is deprecated).

This patch removes it from the API module, and moves the type internal.
We can stop sending this Aux message once DCT is fully phased out.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-31 00:47:23 +01:00
Rob Murray
43b48f1929 Merge pull request #51355 from corhere/api-macaddr-marshaltext
api/t/network: represent MAC addrs as byte slices
2025-10-30 23:43:12 +00:00
Sebastiaan van Stijn
466f2d2e5d Merge pull request #51354 from vvoland/bye-namegen
Move namesgenerator to internal
2025-10-31 00:25:03 +01:00
Rob Murray
22c037982c API compat: replace nil values when adding fields
Signed-off-by: Rob Murray <rob.murray@docker.com>
2025-10-30 22:48:32 +00:00
Sebastiaan van Stijn
97a1d44f05 Merge pull request #51342 from thaJeztah/client_platforms
client: prepare option-structs for multiple platforms
2025-10-30 22:18:58 +01:00
Cory Snider
19f4c27d81 api/t/network: represent MAC addrs as byte slices
Make invalid states unrepresentable by moving away from stringly-typed
MAC address values in API structs. As go.dev/issue/29678 has not yet
been implemented, provide our own HardwareAddr byte-slice type which
implements TextMarshaler and TextUnmarshaler to retain compatibility
with the API wire format.

When stdlib's net.HardwareAddr type implements TextMarshaler and
TextUnmarshaler and GODEBUG=netmarshal becomes the default, we should be
able to make the type a straight alias for stdlib net.HardwareAddr as a
non-breaking change.

Signed-off-by: Cory Snider <csnider@mirantis.com>
2025-10-30 17:11:38 -04:00
Paweł Gronowski
433023a03d Move namesgenerator to internal
It's frozen and only kept for historical/legacy purposes.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2025-10-30 19:41:58 +01:00
Paweł Gronowski
5a871b8299 Merge pull request #51156 from corhere/client-pkg-jsonmessage
client/pkg/jsonmessage: refactor in terms of `api/types/jsonstream`
2025-10-30 19:33:21 +01:00
Sebastiaan van Stijn
72f6cec125 Merge pull request #51333 from thaJeztah/new_client
client: deprecate NewClientWithOpts in favor of New
2025-10-30 18:23:46 +01:00
Sebastiaan van Stijn
d1f70d4f54 client: deprecate NewClientWithOpts in favor of New
Use a more idiomatic name so that it can be used as `client.New()`.

We should look if we want `New()` to have different / updated defaults
i.e., enable `WithEnv` as default, and have an opt-out and have API-
version negotiation enabled by default (with an opt-out option).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-10-30 18:09:44 +01:00