InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

client: fix some missing error checks in tests (ineffassign)

Browse Source 
client/client_test.go:367:5: ineffectual assignment to err (ineffassign)
        _, err = client.Ping(t.Context(), PingOptions{
           ^
    client/client_test.go:381:5: ineffectual assignment to err (ineffassign)
        _, err = client.Ping(t.Context(), PingOptions{
           ^
    client/client_test.go:425:5: ineffectual assignment to err (ineffassign)
        _, err = client.Ping(t.Context(), PingOptions{
           ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-12-18 15:17:24 +01:00
parent 8f3bfa3f34
commit f39912a30e
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
client/client_test.go
View File

@@ -367,6 +367,7 @@ func TestNegotiateAPIVersionOverride(t *testing.T) {
_, err = client.Ping(t.Context(), PingOptions{ _, err = client.Ping(t.Context(), PingOptions{
NegotiateAPIVersion: true, NegotiateAPIVersion: true,
}) })
assert.NilError(t, err)
assert.Check(t, is.Equal(client.ClientVersion(), expected)) assert.Check(t, is.Equal(client.ClientVersion(), expected))
} }
@@ -381,6 +382,8 @@ func TestNegotiateAPIVersionConnectionFailure(t *testing.T) {
_, err = client.Ping(t.Context(), PingOptions{ _, err = client.Ping(t.Context(), PingOptions{
NegotiateAPIVersion: true, NegotiateAPIVersion: true,
}) })
assert.Check(t, is.ErrorType(err, IsErrConnectionFailed))
assert.Check(t, is.ErrorContains(err, `failed to connect to the docker API at tcp://no-such-host.invalid`))
assert.Check(t, is.Equal(client.ClientVersion(), expected)) assert.Check(t, is.Equal(client.ClientVersion(), expected))
} }
@@ -425,6 +428,7 @@ func TestNegotiateAPIVersionWithEmptyVersion(t *testing.T) {
_, err = client.Ping(t.Context(), PingOptions{ _, err = client.Ping(t.Context(), PingOptions{
NegotiateAPIVersion: true, NegotiateAPIVersion: true,
}) })
assert.NilError(t, err)
assert.Check(t, is.Equal(client.ClientVersion(), expected)) assert.Check(t, is.Equal(client.ClientVersion(), expected))
} }