From f39912a30e6700063de98c2c28102222b2a8273f Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Thu, 18 Dec 2025 15:17:24 +0100 Subject: [PATCH] client: fix some missing error checks in tests (ineffassign) client/client_test.go:367:5: ineffectual assignment to err (ineffassign) _, err = client.Ping(t.Context(), PingOptions{ ^ client/client_test.go:381:5: ineffectual assignment to err (ineffassign) _, err = client.Ping(t.Context(), PingOptions{ ^ client/client_test.go:425:5: ineffectual assignment to err (ineffassign) _, err = client.Ping(t.Context(), PingOptions{ ^ Signed-off-by: Sebastiaan van Stijn --- client/client_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/client/client_test.go b/client/client_test.go index 9b53167eec..dec0d69000 100644 --- a/client/client_test.go +++ b/client/client_test.go @@ -367,6 +367,7 @@ func TestNegotiateAPIVersionOverride(t *testing.T) { _, err = client.Ping(t.Context(), PingOptions{ NegotiateAPIVersion: true, }) + assert.NilError(t, err) assert.Check(t, is.Equal(client.ClientVersion(), expected)) } @@ -381,6 +382,8 @@ func TestNegotiateAPIVersionConnectionFailure(t *testing.T) { _, err = client.Ping(t.Context(), PingOptions{ NegotiateAPIVersion: true, }) + assert.Check(t, is.ErrorType(err, IsErrConnectionFailed)) + assert.Check(t, is.ErrorContains(err, `failed to connect to the docker API at tcp://no-such-host.invalid`)) assert.Check(t, is.Equal(client.ClientVersion(), expected)) } @@ -425,6 +428,7 @@ func TestNegotiateAPIVersionWithEmptyVersion(t *testing.T) { _, err = client.Ping(t.Context(), PingOptions{ NegotiateAPIVersion: true, }) + assert.NilError(t, err) assert.Check(t, is.Equal(client.ClientVersion(), expected)) }