InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #50415 from thaJeztah/push_no_empty_body_step1

Browse Source 
client: always send (empty) body on push
This commit is contained in:
Sebastiaan van Stijn
2025-07-16 19:45:17 +02:00
committed by GitHub
parent 55f0bd8ee9 b1ce0c89f0
commit c1e5ab4e50
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
client/image_push.go
View File

@@ -72,5 +72,15 @@ func (cli *Client) tryImagePush(ctx context.Context, imageID string, query url.V
hdr.Set(registry.AuthHeader, registryAuth)
}
}
return cli.post(ctx, "/images/"+imageID+"/push", query, nil, hdr)
// Always send a body (which may be an empty JSON document ("{}")) to prevent
// EOF errors on older daemons which had faulty fallback code for handling
// authentication in the body when no auth-header was set, resulting in;
//
// Error response from daemon: bad parameters and missing X-Registry-Auth: invalid X-Registry-Auth header: EOF
//
// We use [http.NoBody], which gets marshaled to an empty JSON document.
//
// see: https://github.com/moby/moby/commit/ea29dffaa541289591aa44fa85d2a596ce860e16
return cli.post(ctx, "/images/"+imageID+"/push", query, http.NoBody, hdr)
}