mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
daemon: Daemon.killWithSignal(): don't discard handleContainerExit error
Daemon.handleContainerExit() returns an error if snapshotting the container's state to disk fails. There's not much we can do with the error if it occurs, but let's log the error if that happens, instead of discarding it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
@@ -111,7 +111,13 @@ func (daemon *Daemon) killWithSignal(container *containerpkg.Container, stopSign
|
||||
defer cancel()
|
||||
s := <-container.Wait(ctx, containerpkg.WaitConditionNotRunning)
|
||||
if s.Err() != nil {
|
||||
daemon.handleContainerExit(container, nil)
|
||||
if err := daemon.handleContainerExit(container, nil); err != nil {
|
||||
log.G(context.TODO()).WithFields(log.Fields{
|
||||
"error": err,
|
||||
"container": container.ID,
|
||||
"action": "kill",
|
||||
}).Warn("error while handling container exit")
|
||||
}
|
||||
}
|
||||
}()
|
||||
} else {
|
||||
|
||||
Reference in New Issue
Block a user