InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

volume/testutils: simplify fakePluginGetter

Browse Source 
Embed the interface to simplify the mock

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2024-11-21 11:33:19 +01:00
parent 803534fb4e
commit 821d974789
1 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
volume/testutils/testutils.go
View File

@@ -189,9 +189,12 @@ func (p *fakePlugin) ScopedPath(s string) string {
type fakePluginGetter struct {
plugins map[string]plugingetter.CompatPlugin
plugingetter.PluginGetter
}
// NewFakePluginGetter returns a plugin getter for fake plugins
// NewFakePluginGetter returns a plugin getter for fake plugins. It only
// implements [plugingetter.PluginGetter.Get], and panics when calling
// any other method.
func NewFakePluginGetter(pls ...plugingetter.CompatPlugin) plugingetter.PluginGetter {
idx := make(map[string]plugingetter.CompatPlugin, len(pls))
for _, p := range pls {
@@ -200,7 +203,7 @@ func NewFakePluginGetter(pls ...plugingetter.CompatPlugin) plugingetter.PluginGe
return &fakePluginGetter{plugins: idx}
}
// This ignores the second argument since we only care about volume drivers here,
// Get ignores the second argument since we only care about volume drivers here,
// there shouldn't be any other kind of plugin in here
func (g *fakePluginGetter) Get(name, _ string, mode int) (plugingetter.CompatPlugin, error) {
p, ok := g.plugins[name]
@@ -211,18 +214,6 @@ func (g *fakePluginGetter) Get(name, _ string, mode int) (plugingetter.CompatPlu
return p, nil
}
func (g *fakePluginGetter) GetAllByCap(capability string) ([]plugingetter.CompatPlugin, error) {
panic("GetAllByCap shouldn't be called")
}
func (g *fakePluginGetter) GetAllManagedPluginsByCap(capability string) []plugingetter.CompatPlugin {
panic("GetAllManagedPluginsByCap should not be called")
}
func (g *fakePluginGetter) Handle(capability string, callback func(string, *plugins.Client)) {
panic("Handle should not be called")
}
// FakeRefs checks ref count on a fake plugin.
func FakeRefs(p plugingetter.CompatPlugin) int {
// this should panic if something other than a `*fakePlugin` is passed in