InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

libnetwork/datastore: MockStore.AtomicPut: remove redundant nil check (govet)

Browse Source 
libnetwork/datastore/mockstore_test.go:70:12: nilness: tautological condition: non-nil != nil (govet)
            if mData != nil && mData.Index != previous.LastIndex {
                     ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2024-11-05 16:30:46 +01:00
parent 473b1d419c
commit 738fb74a1a
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libnetwork/datastore/mockstore_test.go
View File

@@ -62,14 +62,16 @@ func (s *MockStore) AtomicPut(key string, newValue []byte, previous *store.KVPai
if previous == nil {
if mData != nil {
return nil, types.InvalidParameterErrorf("atomic put failed because key exists")
} // Else OK.
}
// Else OK.
} else {
if mData == nil {
return nil, types.InvalidParameterErrorf("atomic put failed because key exists")
}
if mData != nil && mData.Index != previous.LastIndex {
if mData.Index != previous.LastIndex {
return nil, types.InvalidParameterErrorf("atomic put failed due to mismatched Index")
} // Else OK.
}
// Else OK.
}
if err := s.Put(key, newValue); err != nil {
return nil, err