mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
integration-cli: TestEventsFilterType: remove test for "build" events
Commit 6aea8c2591 updated this part of the
test to account for BuildKit now being used as default, which doesn't use
regular containers to "commit" to an image, and therefore doesn't produce
events as part of the build.
However, it changed it to filter for `build` type events, which .. don't
exist. The test passed because it only checked for number of events produced,
which is approximated by checking the number of lines in the output. In
this case, the output would be empty, so "events" was a slice of strings
with length 1; an empty string.
Given that BuildKit doesn't produce meaningful events to test for, we could
either disable BuildKit, to test the legacy builder, or just remove this
part of the test. Let's do the latter.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
@@ -583,18 +583,6 @@ func (s *DockerCLIEventSuite) TestEventsFilterType(c *testing.T) {
|
||||
assert.Check(c, is.Contains(e, "labelfiltertest"))
|
||||
}
|
||||
|
||||
out = cli.DockerCmd(c,
|
||||
"events",
|
||||
"--since", since,
|
||||
"--until", daemonUnixTime(c),
|
||||
"--filter", fmt.Sprintf("label=%s", label),
|
||||
"--filter", "type=build",
|
||||
).Stdout()
|
||||
events = strings.Split(strings.TrimSpace(out), "\n")
|
||||
|
||||
// Events generated the build
|
||||
assert.Equal(c, len(events), 1, "Events == %s", events)
|
||||
|
||||
out = cli.DockerCmd(c,
|
||||
"events",
|
||||
"--since", since,
|
||||
|
||||
Reference in New Issue
Block a user