From 33eb3b8d78d50c5aba97eaa577756ac12e2c6606 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Wed, 10 Dec 2025 01:50:45 +0100 Subject: [PATCH] integration-cli: TestEventsFilterType: remove test for "build" events Commit 6aea8c2591d40c96d90a2da0a1d499799cdcabad updated this part of the test to account for BuildKit now being used as default, which doesn't use regular containers to "commit" to an image, and therefore doesn't produce events as part of the build. However, it changed it to filter for `build` type events, which .. don't exist. The test passed because it only checked for number of events produced, which is approximated by checking the number of lines in the output. In this case, the output would be empty, so "events" was a slice of strings with length 1; an empty string. Given that BuildKit doesn't produce meaningful events to test for, we could either disable BuildKit, to test the legacy builder, or just remove this part of the test. Let's do the latter. Signed-off-by: Sebastiaan van Stijn --- integration-cli/docker_cli_events_test.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/integration-cli/docker_cli_events_test.go b/integration-cli/docker_cli_events_test.go index f48da09448..295d445b0f 100644 --- a/integration-cli/docker_cli_events_test.go +++ b/integration-cli/docker_cli_events_test.go @@ -583,18 +583,6 @@ func (s *DockerCLIEventSuite) TestEventsFilterType(c *testing.T) { assert.Check(c, is.Contains(e, "labelfiltertest")) } - out = cli.DockerCmd(c, - "events", - "--since", since, - "--until", daemonUnixTime(c), - "--filter", fmt.Sprintf("label=%s", label), - "--filter", "type=build", - ).Stdout() - events = strings.Split(strings.TrimSpace(out), "\n") - - // Events generated the build - assert.Equal(c, len(events), 1, "Events == %s", events) - out = cli.DockerCmd(c, "events", "--since", since,