mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
container: TestReplaceAndAppendEnvVars: assert with gotest.tools
Assert the actual results match the expected one, which should make the test more complete, and reduces some noise by removing a `t.Log`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
@@ -8,24 +8,14 @@ import (
|
||||
)
|
||||
|
||||
func TestReplaceAndAppendEnvVars(t *testing.T) {
|
||||
var (
|
||||
d = []string{"HOME=/", "FOO=foo_default"}
|
||||
// remove FOO from env
|
||||
// remove BAR from env (nop)
|
||||
o = []string{"HOME=/root", "TERM=xterm", "FOO", "BAR"}
|
||||
)
|
||||
origEnv := []string{"HOME=/", "FOO=foo_default"}
|
||||
// remove FOO from env
|
||||
// remove BAR from env (nop)
|
||||
overrides := []string{"HOME=/root", "TERM=xterm", "FOO", "BAR"}
|
||||
|
||||
env := ReplaceOrAppendEnvValues(d, o)
|
||||
t.Logf("default=%v, override=%v, result=%v", d, o, env)
|
||||
if len(env) != 2 {
|
||||
t.Fatalf("expected len of 2 got %d", len(env))
|
||||
}
|
||||
if env[0] != "HOME=/root" {
|
||||
t.Fatalf("expected HOME=/root got '%s'", env[0])
|
||||
}
|
||||
if env[1] != "TERM=xterm" {
|
||||
t.Fatalf("expected TERM=xterm got '%s'", env[1])
|
||||
}
|
||||
env := ReplaceOrAppendEnvValues(origEnv, overrides)
|
||||
expected := []string{"HOME=/root", "TERM=xterm"}
|
||||
assert.DeepEqual(t, env, expected)
|
||||
}
|
||||
|
||||
func BenchmarkReplaceOrAppendEnvValues(b *testing.B) {
|
||||
|
||||
Reference in New Issue
Block a user