InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

pkg/parsers: deprecate ParseUintListMaximum, ParseUintList

Browse Source 
These utilities have been moved internal to pkg/sysinfo in
2282279180, and are no longer
used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-01-06 18:04:31 +01:00
parent 3ca5ca4dbc
commit 064cdf475c
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/parsers/parsers.go
View File

@@ -34,6 +34,8 @@ func ParseKeyValueOpt(opt string) (key string, value string, err error) {
// 03,1-3 <- this is gonna get parsed as [1,2,3]
// 3,2,1
// 0-2,3,1
//
// Deprecated: ParseUintListMaximum was only used internally and will be removed in the next release.
func ParseUintListMaximum(val string, maximum int) (map[int]bool, error) {
return parseUintList(val, maximum)
}
@@ -52,6 +54,8 @@ func ParseUintListMaximum(val string, maximum int) (map[int]bool, error) {
// 03,1-3 <- this is gonna get parsed as [1,2,3]
// 3,2,1
// 0-2,3,1
//
// Deprecated: ParseUintList was only used internally and will be removed in the next release.
func ParseUintList(val string) (map[int]bool, error) {
return parseUintList(val, 0)
}

10
pkg/parsers/parsers_test.go
View File

@@ -45,7 +45,7 @@ func TestParseUintList(t *testing.T) {
"0-2,3,1": {0: true, 1: true, 2: true, 3: true},
}
for k, v := range valids {
out, err := ParseUintList(k)
out, err := parseUintList(k, 0)
if err != nil {
t.Fatalf("Expected not to fail, got %v", err)
}
@@ -63,7 +63,7 @@ func TestParseUintList(t *testing.T) {
"-1,0",
}
for _, v := range invalids {
if out, err := ParseUintList(v); err == nil {
if out, err := parseUintList(v, 0); err == nil {
t.Fatalf("Expected failure with %s but got %v", v, out)
}
}
@@ -71,13 +71,13 @@ func TestParseUintList(t *testing.T) {
func TestParseUintListMaximumLimits(t *testing.T) {
v := "10,1000"
if _, err := ParseUintListMaximum(v, 0); err != nil {
if _, err := parseUintList(v, 0); err != nil {
t.Fatalf("Expected not to fail, got %v", err)
}
if _, err := ParseUintListMaximum(v, 1000); err != nil {
if _, err := parseUintList(v, 1000); err != nil {
t.Fatalf("Expected not to fail, got %v", err)
}
if out, err := ParseUintListMaximum(v, 100); err == nil {
if out, err := parseUintList(v, 100); err == nil {
t.Fatalf("Expected failure with %s but got %v", v, out)
}
}