From 064cdf475c837d912e896ed2a1ea118fa85800f6 Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Mon, 6 Jan 2025 18:04:31 +0100 Subject: [PATCH] pkg/parsers: deprecate ParseUintListMaximum, ParseUintList These utilities have been moved internal to pkg/sysinfo in 2282279180c610938778f514a201883ef23f751a, and are no longer used. Signed-off-by: Sebastiaan van Stijn --- pkg/parsers/parsers.go | 4 ++++ pkg/parsers/parsers_test.go | 10 +++++----- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/pkg/parsers/parsers.go b/pkg/parsers/parsers.go index 427a27e587..3779e78c54 100644 --- a/pkg/parsers/parsers.go +++ b/pkg/parsers/parsers.go @@ -34,6 +34,8 @@ func ParseKeyValueOpt(opt string) (key string, value string, err error) { // 03,1-3 <- this is gonna get parsed as [1,2,3] // 3,2,1 // 0-2,3,1 +// +// Deprecated: ParseUintListMaximum was only used internally and will be removed in the next release. func ParseUintListMaximum(val string, maximum int) (map[int]bool, error) { return parseUintList(val, maximum) } @@ -52,6 +54,8 @@ func ParseUintListMaximum(val string, maximum int) (map[int]bool, error) { // 03,1-3 <- this is gonna get parsed as [1,2,3] // 3,2,1 // 0-2,3,1 +// +// Deprecated: ParseUintList was only used internally and will be removed in the next release. func ParseUintList(val string) (map[int]bool, error) { return parseUintList(val, 0) } diff --git a/pkg/parsers/parsers_test.go b/pkg/parsers/parsers_test.go index dca3a07b91..1d6a287049 100644 --- a/pkg/parsers/parsers_test.go +++ b/pkg/parsers/parsers_test.go @@ -45,7 +45,7 @@ func TestParseUintList(t *testing.T) { "0-2,3,1": {0: true, 1: true, 2: true, 3: true}, } for k, v := range valids { - out, err := ParseUintList(k) + out, err := parseUintList(k, 0) if err != nil { t.Fatalf("Expected not to fail, got %v", err) } @@ -63,7 +63,7 @@ func TestParseUintList(t *testing.T) { "-1,0", } for _, v := range invalids { - if out, err := ParseUintList(v); err == nil { + if out, err := parseUintList(v, 0); err == nil { t.Fatalf("Expected failure with %s but got %v", v, out) } } @@ -71,13 +71,13 @@ func TestParseUintList(t *testing.T) { func TestParseUintListMaximumLimits(t *testing.T) { v := "10,1000" - if _, err := ParseUintListMaximum(v, 0); err != nil { + if _, err := parseUintList(v, 0); err != nil { t.Fatalf("Expected not to fail, got %v", err) } - if _, err := ParseUintListMaximum(v, 1000); err != nil { + if _, err := parseUintList(v, 1000); err != nil { t.Fatalf("Expected not to fail, got %v", err) } - if out, err := ParseUintListMaximum(v, 100); err == nil { + if out, err := parseUintList(v, 100); err == nil { t.Fatalf("Expected failure with %s but got %v", v, out) } }