InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #51414 from thaJeztah/remove_dummy_command

Browse Source 
daemon/command: remove `__dummy_command` workaround for completion
This commit is contained in:
Sebastiaan van Stijn
2025-11-06 12:33:09 +01:00
committed by GitHub
parent d661f17c3c e509a7cefe
commit 062906a354
1 changed files with 0 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
daemon/command/docker.go
View File

@@ -53,23 +53,6 @@ func newDaemonCommand(stderr io.Writer) (*cobra.Command, error) {
},
}
// Cobra's [Command.InitDefaultCompletionCmd] has a special-case for
// binaries/commands that don't have subcommands, and does not set up
// the default completion command in that case.
//
// Unfortunately, the definition of the default completion commands
// is not exported, and we don't want to replicate them. As a workaround,
// we're adding a hidden dummy-command to trick Cobra into applying
// the default.
//
// TODO(thaJeztah): consider contributing to Cobra to either allow explicitly enabling, or to export the default completion commands
//
// [Command.InitDefaultCompletionCmd]: https://github.com/spf13/cobra/blob/v1.8.1/completions.go#L685-L698
cmd.AddCommand(&cobra.Command{
Use: "__dummy_command",
Hidden: true,
})
SetupRootCommand(cmd)
flags := cmd.Flags()