InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

libnetwork/drivers/overlay: fix naked returns, output variables

Browse Source 
libnetwork/drivers/overlay/encryption.go:370:2: naked return in func `programSA` with 64 lines of code (nakedret)
        return
        ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn
2025-02-18 19:39:25 +01:00
parent 94afddb18d
commit 02b4c7cc52
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
libnetwork/drivers/overlay/encryption.go
View File

@@ -304,7 +304,7 @@ func (d *driver) programInput(vni uint32, add bool) error {
return nil
}
func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (fSA *netlink.XfrmState, rSA *netlink.XfrmState, err error) {
func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (fSA *netlink.XfrmState, rSA *netlink.XfrmState, lastErr error) {
var (
action = "Removing"
xfrmProgram = ns.NlHandle().XfrmStateDel
@@ -330,6 +330,7 @@ func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (f
exists, err := saExists(rSA)
if err != nil {
lastErr = err
exists = !add
}
@@ -356,6 +357,7 @@ func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (f
exists, err := saExists(fSA)
if err != nil {
lastErr = err
exists = !add
}
@@ -367,7 +369,7 @@ func programSA(localIP, remoteIP net.IP, spi *spi, k *key, dir int, add bool) (f
}
}
return
return fSA, rSA, lastErr
}
// getMinimalIP returns the address in its shortest form