mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
b3d7b07503
The check is intended to ensure paths don't traverse outside the extracted directory. However, the check was too strict: it banned all links, even relative links that still point inside the target directory. This CL relaxes the requirement to allow valid links. This is required to allow library symlinks for the instrumented libraries. Examples: libpcre.so -> libpcre.so.3.13.3 libpcre.so.3 -> libpcre.so.3.13.3 libpixman-1.so -> libpixman-1.so.0.38.4 libpixman-1.so.0 -> libpixman-1.so.0.38.4 libpng16.so -> libpng16.so.16.37.0 libpng16.so.16 -> libpng16.so.16.37.0 Bug: 320564950 Change-Id: I2aae18b86b1f1cc3d73a1b80c06d757af782f700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5369132 Reviewed-by: Joanna Wang <jojwang@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Joanna Wang <jojwang@chromium.org>
depot_tools
Tools for working with Chromium development. It requires python 3.8.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.