This reverts commit6678906cf8. Reason for revert: run gn.py instead of gn on PATH in presubmit check. Bug: 414312048 Original change's description: > Revert "Reland "Use bundled python to run gn"" > > This reverts commit49fcbee29e. > > Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview > > Bug: 414312048 > Original change's description: > > Reland "Use bundled python to run gn" > > > > This reverts commita3cdfed6c4. > > > > Reason for revert: > > https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed > > > > Original change's description: > > > Revert "Use bundled python to run gn" > > > > > > This reverts commitfa8fc854e1. > > > > > > Reason for revert: Most likely culprit for consistent failure > > > to generate orderfiles (see crbug.com/414312048). > > > > > > Bug: 414312048 > > > > > > Original change's description: > > > > Use bundled python to run gn > > > > > > > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515 > > > > Reviewed-by: Junji Watanabe <jwata@google.com> > > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > > > Auto-Submit: Fumitoshi Ukai <ukai@google.com> > > > > Commit-Queue: Fumitoshi Ukai <ukai@google.com> > > > > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846 > > > Owners-Override: Friedrich Hauser <friedrichh@chromium.org> > > > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org> > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > Bug: 414312048 > > Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176 > > Commit-Queue: Fumitoshi Ukai <ukai@google.com> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Junji Watanabe <jwata@google.com> > > Bug: 414312048 > Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888 > Commit-Queue: Garrett Beaty <gbeaty@google.com> > Reviewed-by: Garrett Beaty <gbeaty@google.com> > Owners-Override: Garrett Beaty <gbeaty@google.com> > Auto-Submit: Liviu Rau <liviurau@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: 414312048 Change-Id: I86d611b234bd5b2e91b184c7610c18cfe79f9816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6515221 Reviewed-by: Junji Watanabe <jwata@google.com> Auto-Submit: Fumitoshi Ukai <ukai@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by: Gavin Mak <gavinmak@google.com>
depot_tools
Tools for working with Chromium development. It requires python 3.8.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Also, includes shell script/batch file for tools required to build chromium, e.g.
gn: a meta-build system that generates build files for Ninjaautoninja: a wrapper forsisoandninja.siso: a build tool that aims to significantly speed up Chromium's build.ninja: a small build system with a focus on speed. deprecated by Siso.
These shell script/batch file runs python script with python-bin/python3
that find binaries in chromium checkout, and run with proper setup/check.
To use these wrappers, you need to initialize/bootstrap depot_tools (using
gclient, update_depot_tools or ensure_bootstrap).
Installing
See set-up documentation.
depot_tools is also available in
-
chromium's third_party/depot_tools: propagated by autoroller.
-
on builder: infra_internal/recipe_bundles/chrome-internal.googlesource.com/chrome/tools/build bundles depot_tools. propagated by build_internal recipe roller
These depot_tools would not be initialized/bootstrapped (i.e. no
python-bin/python3 binary available), so the build tool wrapper won't work,
unless it is explicitly initialized by ensure_bootstrap.
Or, directly call the python script instead of using the shell script/batch
file.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
Running gclient will install python3 binary.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.