mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
6f83fce865
This reverts commit 4e2be179a1.
Reason for revert:
This caused exception
```
+ autoninja -strict_remote -d keepdepfile -d keeprsp -C out/Default chrome
siso ninja -strict_remote -d keepdepfile -d keeprsp -C out/Default chrome
ninja: Entering directory `out/Default'
4.51s init credentials by "credhelper"
https://console.cloud.google.com/logs/viewer?project=rbe-chrome-untrusted&resource=generic_task/task_id/25d8cbb8-4fa1-486d-ba78-7865d0eea5ac
use RBE instance "projects/rbe-chrome-untrusted/instances/default_instance"
2.27s loading/recompacting deps log
3.47s Regenerating ninja files
1.17s load siso config
build finished
local:3636 remote:33214 cache:3317 cache-write:0(err:0) fallback:0 retry:0 skip:40752
reapi: ops: 102977(err:33221) / r:46503(err:8) 3.13GiB / w:72424(err:0) 152.35MiB
fs: ops: 2790971(err:182693) / r:227138(err:0) 6.68GiB / w:13508(err:4) 1.87GiB
resource/capa used(err) wait-avg | s m | serv-avg | s m |
pool=action/128 2372(0) 0.00s |█ | 0.30s | █▅▂▂▂ |
rbe:sched 33214(0) 0.01s |▃█▂▂ | 6.43s | ▂█▃▂ |
rbe:worker 33214(0) 0.87s | █ | 5.56s | ▂█▃▂ |
remoteexec/10240 33214(0) 0.10s |█▂▂▂ | 15.37s | ██▂ |
1.00s shutdown cloud logging/monitoring
4m08.96s Build Succeeded: 40167 steps - 161.34/s
flag provided but not defined: -enable_cloud_monitoring
summarize siso_metrics.json
$ siso metrics summary -C <dir> \
[--step_types <types>] \
[--elapsed_time_sorting] \
[--elapsed_time=run|step] \
[--input siso_metrics.json]
summarize <dir>/.siso_metrics.json (--input)
as depot_tools/post_ninja_build_summary.py does.
-C string
ninja running directory, where siso_metrics.json exists (default ".")
-elapsed_time string
metrics to use for elapsed time. "run" or "step". "run": time to run local command or call remote execution. "step": full duration for the step, including preproc, waiting resource to run command etc. (default "run")
-elapsed_time_sorting
Sort output by elapsed time instead of weighted time
-input string
filename of siso_metrics.json to summarize (default "siso_metrics.json")
-step_types string
semicolon separated glob patterns (go filepath.Match) for build-step grouping
Traceback (most recent call last):
File "/usr/local/google/home/tikuta/depot_tools/post_build_ninja_summary.py", line 390, in <module>
sys.exit(main())
^^^^^^
File "/usr/local/google/home/tikuta/depot_tools/post_build_ninja_summary.py", line 375, in main
subprocess.run(cmd, check=True)
File "/usr/local/google/home/tikuta/depot_tools/bootstrap-2@3.11.8.chromium.35_bin/python3/lib/python3.11/subprocess.py", line 571, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['/usr/local/google/home/tikuta/depot_tools/bootstrap-2@3.11.8.chromium.35_bin/python3/bin/python3', '/usr/local/google/home/tikuta/depot_tools/siso.py', 'metrics', 'summary', '-C', 'out/Default', '--step_types', 'trict_remote']' returned non-zero exit status 2.
```
Original change's description:
> Enable telemetry flags for Google corp machines only.
>
> Bug: b/348530235
> Change-Id: I4ac32c60b806f44920bd06e31ec6c3b86a6a6964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7104218
> Commit-Queue: Alex Ovsienko <ovsienko@google.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>
Bug: b/348530235
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iff13fa73745e09d2dab4278e9571f7ed77bf3d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7136522
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Alex Ovsienko <ovsienko@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
depot_tools
Tools for Chromium development. Requires Python 3.8+.
gsutil: Python 3.9–3.13 required.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Also, includes shell script/batch file for tools required to build chromium, e.g.
gn: a meta-build system that generates build files for Ninjaautoninja: a wrapper forsisoandninja.siso: a build tool that aims to significantly speed up Chromium's build.ninja: a small build system with a focus on speed. deprecated by Siso.
These shell script/batch file runs python script with python-bin/python3
that find binaries in chromium checkout, and run with proper setup/check.
To use these wrappers, you need to initialize/bootstrap depot_tools (using
gclient, update_depot_tools or ensure_bootstrap).
Installing
See set-up documentation.
depot_tools is also available in
-
chromium's third_party/depot_tools: propagated by autoroller.
-
on builder: infra_internal/recipe_bundles/chrome-internal.googlesource.com/chrome/tools/build bundles depot_tools. propagated by build_internal recipe roller
These depot_tools would not be initialized/bootstrapped (i.e. no
python-bin/python3 binary available), so the build tool wrapper won't work,
unless it is explicitly initialized by ensure_bootstrap.
Or, directly call the python script instead of using the shell script/batch
file.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
Running gclient will install python3 binary.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.