InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,590 Commits 6 Branches 0 Tags
dd8909f2123922b1d2c5e6a9a717d0a1f5250bf0
Commit Graph

11590 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Junji Watanabe
dd8909f212 autoninja: Do not collect Reclient build metrics 
We don't need to collect metrics from Reclient, anymore since
most builds are done by Siso.

Change-Id: I38fcb42aca966acc1b45a0876634cb9949bd255d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6733778
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2025-07-13 20:11:12 -07:00
Fumitoshi Ukai
c2a6159a0d autoninja: fix siso suggestion message 
Bug: 430498033
Change-Id: I1b44916bd233a8261a714c358840ffde868f0538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6719028
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Matt Stark <msta@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2025-07-10 20:16:50 -07:00
recipe-roller
7784911e43 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8709770217360738545

recipe_engine:
bfba93e229
  bfba93e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from ded4eb56ba38 to f703132ac353

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4b388becf0c18e9de2fb01d9cf63a0cc3035b0c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6720147
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-07-09 19:09:31 -07:00
Nikolay Vitkov
0f872505cc [cleanup] Remove DevTools internal 
This repo no longer exits and should be remove to reduce confusion.

Bug: none
Change-Id: Iea67c85680a89b8bb5043bf5d63e117f63e80c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6708502
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-07-09 02:31:46 -07:00
Riley
405df0756a [lucicfg] Update v1.45.5 -> v1.45.6 
Major update is allowing luci builder health notifier
rule to have an ignore bucket parameter.

Bug: 407539622
Change-Id: I319f1fe56fc643894f8eb138ebb81ad029f3551c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6714288
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 2025-07-08 09:58:24 -07:00
Jordan Brown
0d6837383d Fixed bug in depot_tools presubmit 
Potential to call None.lower() when doing 'vuln_scan_sufficiency'

Change-Id: I55e7f207612337ff18f5799d0366e89ecfa98b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6711769
Auto-Submit: Jordan Brown <rop@google.com>
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
 2025-07-07 22:36:07 -07:00
Jordan Brown
ea4e2d4117 vuln_scan_sufficiency: Ignore internal/canonical 
Change-Id: Ie0dc496abc955163364feeb198881a9b58c825d3
Bug: 429937921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6711768
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
Auto-Submit: Jordan Brown <rop@google.com>
Commit-Queue: Rachael Newitt <renewitt@google.com>
 2025-07-07 21:09:22 -07:00
Jordan Brown
ab22114f1f Allow "Google Internal" in url field 
This change adds support for an "Internal" label in the "URL" custom
metadata field. When this label is used, the dependency will be not be
required to provide sufficient metadata for vulnerability coverage.

Change-Id: I747d53934b5ebe3cf4a17fc2aab2de6a9ac2c1dd
Bug: 429937921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6706140
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
 2025-07-07 20:42:15 -07:00
Jordan Brown
1b7c452940 Add Vuln scan sufficiency to metadata. 
This property helps determine if the data available in metadata is sufficient to do vulnerability scanning.

Change-Id: I7cead6ca7eacf3184f6afa0a77b48fb2439f9fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6706867
Auto-Submit: Jordan Brown <rop@google.com>
Commit-Queue: Rachael Newitt <renewitt@google.com>
Reviewed-by: Rachael Newitt <renewitt@google.com>
 2025-07-07 18:56:39 -07:00
Scott Lee
abc5109882 fix cipd_impl.ps1 failure when depot_tools path contains whitespaces 
Bug: 428834916
Change-Id: I190c63ef6f9f9c1decab4a2f410aa18699e6f273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6700873
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-07-02 16:22:54 -07:00
Rafael Cintron
1867bb56c1 Add dump_file_list flag to package_from_installed.py 
To aid in debugging packaging file list, add a dump_file_list flag
which writes the list to a file of the user's choosing.

Format of the file is "disk_name -> archive_name"

Change-Id: Ib0549372fa72069a58d46ef32807e7e7cc713092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6701090
Reviewed-by: Devon Loehr <dloehr@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
Auto-Submit: Rafael Cintron <rafael.cintron@microsoft.com>
 2025-07-02 14:13:51 -07:00
Andy Perelson
615f4a2f03 Remove support for RobotComments, which have been removed from Gerrit. 
Bug: 428171766
Change-Id: I38ddbf4a934f80897301d2fd04d8b83a799b1bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6690195
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Andy Perelson <ajp@google.com>
 2025-07-01 14:23:35 -07:00
Ben Pastene
52de072b5f Add *.star files as source file from presubmit's PoV 
By not considering *.star files as source files, various pan-project
checks (like the copyright header check) weren't running on them.

But *.star files are pretty much python files, so should be treated the
same.

Bug: 428926694
Change-Id: If3f7ff45d9fa825008e6a86b13d60d44ad8387c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6697693
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
 2025-07-01 13:52:53 -07:00
Camillo Bruni
b75eae780d Add fetch-config for v8-perf repo 
Based on the existing v8.py config.

Change-Id: I58089e1d899fe4dcc09d259a0ab77a893d0907ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6684932
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2025-07-01 02:44:42 -07:00
Alex Ovsienko
211126cbe1 autoninja: import resource only when its needed to prevent linter from complaning. 
Linter in question: https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance - Pylance.

Change-Id: I3d8c17c533a882d08b846364249795b32c51bd27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6693923
Auto-Submit: Alex Ovsienko <ovsienko@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-07-01 00:02:53 -07:00
Alex Ovsienko
179c4a53fc autoninja: prevent null pointer exception on _get_remoteexec_defaults returning None. 
Change-Id: Ic89607b4e234b66253923383bc8b969c1434e9f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6693922
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Alex Ovsienko <ovsienko@google.com>
 2025-06-30 23:58:36 -07:00
recipe-roller
5cc29c7a21 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8710863672211156465

recipe_engine:
31c3050c67
  31c3050 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 53a8b1a180a8 to 421eb17838d0

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I41ee69c2027ebef9de588300c02420ddaf4679a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6685913
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-27 17:30:09 -07:00
recipe-roller
55d1d785e5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8710888209033811377

recipe_engine:
db9d781fef
  db9d781 (mohrr@google.com)
      [buildbucket] Add build argument to build_url()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I79d549fe59a6a8bb6fb1d193ddaa38849c46152b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6685086
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-27 11:00:33 -07:00
recipe-roller
4f1723dd1f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8710984467688039345

recipe_engine:
7224b53b55
  7224b53 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e0af1d92ce1c to e18061c271a8

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I20c76b84c3d3998d157edb25272dbcb5a24140a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6680328
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-26 09:31:29 -07:00
Jordan Brown
838762e3ae Improve Update Mechanism bug link validation 
Includes parsing the bug number and returning a standard format e.g.
`https://crbug.com/421989967`

Bug: 421989967
Change-Id: I4e159e6ab8ddd1d6fb253a360db8b48ee5a68c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6669073
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
Auto-Submit: Jordan Brown <rop@google.com>
 2025-06-24 23:27:22 -07:00
Fumitoshi Ukai
6a1451c0c0 autoninja: disable siso native by --reapi_address= 
siso v1.3.1 changed the way to enable reapi.
It allows empty project and empty reapi_instance.

Under reclient mode to disable siso native,
set reapi_address empty.

Bug: 427569563
Change-Id: Ib653186c5200605032de5c0fddab0b64412db85c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6668613
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2025-06-24 17:43:48 -07:00
Riley
4c626451ae [lucicfg] Update lucicfg 1.45.4 to 1.45.5 
Most notable change is fixing a bug in generator causing branches
to fail in presubmit for builder health notifiers

Bug: 407539622
Change-Id: Id596dfa24c72d29a5b11d61af647d9d7597a2afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6666483
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Riley Wong <rgw@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2025-06-24 14:52:16 -07:00
Michael Tang
488ad9dd22 Add lxml wheel for Windows DebugVisualizer presubmit support 
The lxml package lets us validate .natvis files against the schema.

See: crrev.com/c/6533151

It is already available on CIPD and is being used by chromium infra:
- https://chrome-infra-packages.appspot.com/p/infra/python/wheels/lxml
- https://source.chromium.org/chromium/infra/infra_superproject/+/main:infra/go/src/go.chromium.org/chromiumos/config/.vpython3;l=163-166;drc=faae440af665c1ee2b26b3e25d52bad6a5d144ae

Change-Id: Ic19ae47268612230cf9db94c37792c989964e58f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6593971
Commit-Queue: Michael Tang <tangm@microsoft.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
 2025-06-24 12:54:22 -07:00
Struan Shrimpton
dc4e911623 Revert "Telemetry: disable for non-linux" 
This reverts commit dcbf502f02.

Reason for revert: Fixes have landed

Bug: 326277821
Original change's description:
> Telemetry: disable for non-linux
>
> Something about collecting traces before explicit opt-in is causing
> the output on win to get consumed. Disable for non-linux until I can
> more thoroughly test and figure out what's going on
>
> Bug: 326277821
> Change-Id: I8536cb61078ef98e37c5ab3e1c8abe2141a50eef
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648247
> Auto-Submit: Struan Shrimpton <sshrimp@google.com>
> Commit-Queue: Struan Shrimpton <sshrimp@google.com>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>

Bug: 326277821
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I0d122895a832130fef5eebaf4cd4b5896dba4806
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648626
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 2025-06-24 09:19:31 -07:00
recipe-roller
8aee541283 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711202152132202993

recipe_engine:
bb258e4d70
  bb258e4 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2da73c426d1b to 6c2c13d25bc8

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I31b94dc8125e9bff4318def5ddc4800aa5664f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6663449
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-23 23:49:34 -07:00
Chan Li
ea7a0baff0 [depot_tools] roll dirmd 
To include https://crrev.com/c/6664398

Change-Id: I3d6919cd76306d7112b8cc2ff1b465683879d1e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6664482
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Chan Li <chanli@chromium.org>
 2025-06-23 14:05:41 -07:00
recipe-roller
0c423cc347 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711243044641158881

recipe_engine:
9957f1505c
  9957f15 (mohrr@google.com)
      [engine] Include details of step config failures

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I60753a60b8317910736ac7b3b06e1b63af7a9c7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6664001
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-23 13:00:02 -07:00
recipe-roller
9cb1143786 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711248708731678065

recipe_engine:
5f23797390
  5f23797 (gbeaty@google.com)
      Revert "[snoopy] retry reporting errors in bcid reporter module"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e21bb37b31a616b6d11b686da1bad539e173317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6663540
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-23 11:34:04 -07:00
Junji Watanabe
8f87843807 autoninja: Handle -j for Siso 
This CL adds -j support for Siso builds.

- With use_remoteexec=true
  - -j will be replaced with -remote_jobs
- Without use_remoteexec=true
  - -j will be replaced with -local_jobs unless j > num_cpus

Bug: 424659245
Change-Id: I0370cfdd6e2004094a599c3aa32f02106e1b3092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6656547
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2025-06-23 00:23:32 -07:00
recipe-roller
e04e3cadc2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711300300377681073

recipe_engine:
b12105986e
  b121059 (mohrr@google.com)
      [buildbucket] Check types in build_url()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I21c3455aaf974d58ddebc8f2444d3e48fcd67aa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6658855
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-22 21:48:55 -07:00
Junji Watanabe
909e2921a0 autoninja: remove no remote execution warning 
Siso is expected to use for local builds, too.
This warning doesn't make sense now. The message for -offline
flag should be sufficient for developers to notice about it.

Bug: 424659245
Change-Id: Iedab0c5de4886c70c7fe88640332d17f7d92889f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6656548
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2025-06-22 18:23:52 -07:00
recipe-roller
ae91718550 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711502254731029937

recipe_engine:
40d9046b92
  40d9046 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 387ab8df4029 to b0488766ec2a

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I33b5bdf7dbbf22b02e8d5da19d56ca2cf296cca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6659178
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-20 16:22:03 -07:00
Junji Watanabe
9a17210302 autoninja: switch between ninja and siso for help appropriately 
When running `autoninja -help` at Chromium project root, it prints
`ninja -help`. `autoninja` should switch between `ninja -help` and `siso
ninja -help` based on the project setting.

Bug: 426149609
Fixed: 426149609
Change-Id: I1a5d1b98e906130ad17061d49a1f25d2c0119c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6656541
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2025-06-19 21:50:43 -07:00
recipe-roller
3f633ff2f9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711658283235240625

recipe_engine:
c34226a2b2
  c34226a (dlf@google.com)
      [snoopy] retry reporting errors in bcid reporter module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I58fe1a75b58757a6e8643311e18219f0d0b8c16e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6656120
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-18 22:59:50 -07:00
Riley
6b2b0240d9 [lucicfg] Update v1.45.3 -> 1.45.4 
Most notable change is including luci.builder_health_notifier into
lucicfg generation.

Bug: 407539622
Change-Id: Ic6360e73c924b5adb58dc46ac536065059a2489b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6652457
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 2025-06-18 18:00:23 -07:00
Struan Shrimpton
712066553a Telemetry: use print instead of logging 
Using the logging library before UTR can set it up puts it in a weird
state that consumes all output. Instead of using logging, just print
anything from initializing telemetry.

Also make some small updated to avoid features not supported by
non-linux os's right now (these have been generating unnecessary
warnings)

Bug: 425298118
Change-Id: I1ccc749fb3c3410b105116ff25160fc23f0336df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648785
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
 2025-06-18 14:29:45 -07:00
recipe-roller
b51ce4941b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711706096566523089

recipe_engine:
9803c733ce
  9803c73 (mohrr@google.com)
      [buildbucket] Add summary_markdown to test_api.py

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I21cf2653f9a0654ee2490ecd69946d9ad99e0c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6654827
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-18 10:23:49 -07:00
recipe-roller
18b553f876 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8711706726376805313

recipe_engine:
83f09a879c
  83f09a8 (mohrr@google.com)
      [OWNERS] Cleanup

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibf4eb537f76cf392e28d0719163c427c454c4579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6652514
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-18 10:11:37 -07:00
Junji Watanabe
377f55f382 autoninja: Enable Siso by default for external Chromium developers 
This CL changes the default build system for Chromium builds by external
developers from Ninja to Siso.
See also https://crrev.com/c/6638830 for more info.

Bug: 424659245, 409223168
Change-Id: I382746cab2e8b40db5f555711e965f814d089987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6636690
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2025-06-17 17:38:43 -07:00
Struan Shrimpton
2ac2988f7b Telemetry: add bot opt-in support 
This adds a new option to bypass the googler check for bots which
might have unexpected hostnames

Bug: 326277821
Change-Id: I56aa2e60d9a7a91ba0b8c8202e659d5b35076c52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6622310
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 2025-06-16 15:47:38 -07:00
Struan Shrimpton
dcbf502f02 Telemetry: disable for non-linux 
Something about collecting traces before explicit opt-in is causing
the output on win to get consumed. Disable for non-linux until I can
more thoroughly test and figure out what's going on

Bug: 326277821
Change-Id: I8536cb61078ef98e37c5ab3e1c8abe2141a50eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6648247
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
 2025-06-16 11:16:43 -07:00
Jordan
d4c627ed62 Adding Update Mechanism to Presubmit validation. 
Bug: b/417367156
Change-Id: I3d12566ecf3c4d6d8d42c509fceb847fa5248776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6606603
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
 2025-06-12 01:35:35 -07:00
recipe-roller
ea261d7c75 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8712297495055017281

recipe_engine:
d66ea2e593
  d66ea2e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 315bb43d6435 to 0250323d9993

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I863994a466a91e47c5f16c9b6beb5485fae26dcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6638248
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-11 21:42:23 -07:00
recipe-roller
9297a6fb2b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8712302528317514753

recipe_engine:
53370a74da
  53370a7 (mohrr@google.com)
      [buildbucket] Allow epoch time in test time values

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ied4d40ab5a95eb119039c6341b3311ca7b348100
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6638246
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-11 20:22:18 -07:00
Jie Sheng
5d3a0d63c1 Add CheckValidHostsInDEPSOnUpload in presubmit_canned_checks.py 
This check will call the gclient.py to verify the host in DEPS file.
Using the local path of the gclient.py file.
Will remove the same test in the PRESUBMIT.py in next cl.

Bug: 419888911
Change-Id: I59719a84bc3a901c52188a9ca2ea2a523c23dd4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6638231
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Jie Sheng <jiesheng@google.com>
 2025-06-11 16:36:46 -07:00
recipe-roller
974e876217 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8712397529356002833

recipe_engine:
967b970ccb
  967b970 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 698a18425c10 to a716714d4279

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5532ff56b2bec8b326a1a02f803d9a5d43bcb03e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6636134
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-10 19:11:00 -07:00
recipe-roller
d255a8d41e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8712841077786119073

recipe_engine:
aac6da572b
  aac6da5 (olivernewman@google.com)
      [change_verifier] Update CV CLI

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If666a52bf34a9af3dd8e93f70824a49cb35bbd79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6626617
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-05 21:39:18 -07:00
recipe-roller
749b3f1960 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8712868758645639329

recipe_engine:
a93790fa9b
  a93790f (yiwzhang@google.com)
      roll all proto to the latest

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie02a26cd5fceb4a043463c8f39b0d3c25983f05f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6626216
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-06-05 14:22:33 -07:00
Struan Shrimpton
46ad34abca Reland "telemetry: Collect until opt-out" 
This is a reland of commit 9c11bcef1f

Original change's description:
> telemetry: Collect until opt-out
>
> The pdd says we will collect by default:
> https://eldar.corp.google.com/assessments/570486509/revisions/1/sections/550004#questions/550404/revisions/2
>
> Also reduce the notice count to 9 since it notices on "0 remaining"
>
> Bug: 326277821
> Change-Id: I4de584c36868b45cefaa5cea42f88d245485dce7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6616983
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Struan Shrimpton <sshrimp@google.com>

Bug: 326277821
Change-Id: Ieee21e20ede1dfa71e6c7944ba0e92e74b5a5ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6624994
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 2025-06-05 12:59:57 -07:00
Struan Shrimpton
4e7e235dc8 Revert "telemetry: Collect until opt-out" 
This reverts commit 9c11bcef1f.

Reason for revert: Last patch introduced a bug:
https://ci.chromium.org/ui/p/chromium/builders/try.shadow/mac-utr-tester/6/infra

Bug: 326277821
Original change's description:
> telemetry: Collect until opt-out
>
> The pdd says we will collect by default:
> https://eldar.corp.google.com/assessments/570486509/revisions/1/sections/550004#questions/550404/revisions/2
>
> Also reduce the notice count to 9 since it notices on "0 remaining"
>
> Bug: 326277821
> Change-Id: I4de584c36868b45cefaa5cea42f88d245485dce7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6616983
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Struan Shrimpton <sshrimp@google.com>

Bug: 326277821
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Iffaf2a8318cd93c3dd1014080c57de92cfdc4eff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6622519
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Struan Shrimpton <sshrimp@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-06-05 09:00:17 -07:00