InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity
7,883 Commits 6 Branches 0 Tags
74e3d80019d91baf14ad4871e4c85b2b543022fc
Commit Graph

7883 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Edward Lesmes
74e3d80019 Change whitespace.txt 
Test implicit owners approval.

Change-Id: I1f38e1b931b191909659298a7e6e39c42603c1e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2897275
Reviewed-by: Yulan Lin <yulanlin@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2021-05-14 18:31:47 +00:00
Chenlin Fan
5ab2f3314c pinpoint: Update Pinpoint CLI 
This change includes the following commits from the infra/infra
repository:

$ git log --format='%h %s (%ae)' \
    97ee9cecaac4d99be09278169f987e61b8116672..HEAD \
    -- go/src/infra/chromeperf/pinpoint/cli

a16d4a5458 Fix deadlock in Pinpoint CLI Unit Test (heiserya@google.com)
211e030fbe Add ability to run a batch of experiments to Pinpoint CLI (heiserya@google.com)
ca40b45ace pinpoint: Make artifact download concurrent (dberris@google.com)
08ea607681 pinpoint: print absolute path for downloaded files (fancl@chromium.org)
128352a9fb chromeperf: Add go_package option to protos (dberris@google.com)
6f69cd0a52 pinpoint: Initial support for downloading job artifacts (fancl@chromium.org)
fbcd876092 pinpoint: Compact job listing UI (dberris@google.com)
095bfe3bc8 pinpoint: Set a user agent for the CLI (dberris@google.com)

Change-Id: I4c31857272591667af5587ec83f3418cb1c14303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2896109
Auto-Submit: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2021-05-14 02:13:40 +00:00
Brian Ryner
5974ca0262 Roll back cpython version on Linux. 
Bug: 1208146
Change-Id: If692ee3073e41acf4da2cd271559b86987813937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2896108
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
 2021-05-14 01:37:40 +00:00
Nodir Turakulov
47a4b0bc59 Add revert instructions 
Add revert instructions to .bat and bash files which are the entry
points to various infra tools deployed via CIPD.

Bug: 1206818
Change-Id: Ib0045aea86f29d0f7e3a43c6ff314c4b7aa74171
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892387
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2021-05-13 23:58:10 +00:00
Nico Weber
36179f5548 Update a bug number in a TODO 
Bug: 1205263
Change-Id: Iff55491a058d2f75747b6206c39fa77e092196d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2895148
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-13 23:44:20 +00:00
Robert Liao
b888780d17 Change FindGclientRoot to Use os.path.abspath instead of os.path.realpath 
os.path.realpath will resolve back to the subst paths, leading to
inappropriate current working directories for all downstream hooks.

BUG=1208688

Change-Id: Idfcb0fe4d25ab1317db5aae34663b1017d4c4937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2893669
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-13 23:20:50 +00:00
Anthony Polito
542224ebd6 Replace processObservers with a class that doesn't constantly recreate threads 
I'm not saying this is why bot_update is failing, but I never trust python threads, especially not at scale. I also think the new implementation is easier to understand and less likely to have subtle mistakes if it is extended later

Change-Id: I29be55594a400fda845ea31893789104373fd0f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892185
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
 2021-05-13 22:29:12 +00:00
Nodir Turakulov
170ef52791 [dirmd] Roll dirmd 
To pickup https://chromium-review.googlesource.com/c/infra/infra/+/2891608

R=dpranke@chromium.org

Bug: 1179786
Change-Id: I023e85e96660ee3acef8eaca345e5e89d3bf03e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2894371
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-13 21:55:32 +00:00
Nodir Turakulov
b073879ad6 Revert "[dirmd] Roll dirmd" 
This reverts commit c4575f8016.

Reason for revert: git.exe is not present everywhere. We should check for git.bat

Original change's description:
> [dirmd] Roll dirmd
>
> To pickup
> - https://chromium-review.googlesource.com/c/infra/infra/+/2889534
> - https://chromium-review.googlesource.com/c/infra/infra/+/2889536
> - https://chromium-review.googlesource.com/c/infra/infra/+/2893228
> - https://chromium-review.googlesource.com/c/infra/infra/+/2893224
>
> Bug: 1201822
> Change-Id: I000db40b88d3c2e2b2047a993ed3983a2f09519e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891365
> Auto-Submit: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1201822
Change-Id: I21c21b6be6f816485a849980fe7ae60b85c436fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892386
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-05-13 15:56:08 +00:00
Robert Liao
f5c054ce53 Pretty-Print the win_toolchain JSON Output 
This makes the file easier to read.

Change-Id: Ie5eac66582bd6f3ce3c31def6f591e001de9a79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2893667
Auto-Submit: Robert Liao <robliao@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2021-05-13 00:56:04 +00:00
Olivier Li
0614591e11 Add more users warning to git cl split 
Change-Id: I1306728d73701b2444d382f579aa8894d9857ed4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2892214
Commit-Queue: Olivier Li <olivierli@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gabriel Charette <gab@chromium.org>
 2021-05-12 23:59:24 +00:00
Nodir Turakulov
c4575f8016 [dirmd] Roll dirmd 
To pickup
- https://chromium-review.googlesource.com/c/infra/infra/+/2889534
- https://chromium-review.googlesource.com/c/infra/infra/+/2889536
- https://chromium-review.googlesource.com/c/infra/infra/+/2893228
- https://chromium-review.googlesource.com/c/infra/infra/+/2893224

Bug: 1201822
Change-Id: I000db40b88d3c2e2b2047a993ed3983a2f09519e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891365
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-12 22:56:45 +00:00
Zhaoyang Li
1af6d426a3 [mac_toolchain] Roll mac_toolchain version for builders using osx_sdk 
The roll takes new feature to download Xcode & iOS runtimes separately.
The interface used by builder machines is untouched, but implementation
changed for new Xcode packages.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 1191260
Change-Id: If0554e116bcb92c0b125693e1f555e52e22c10f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890331
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
 2021-05-12 19:17:54 +00:00
Josip Sokcevic
740825ecf2 Detect uploadvalidator error message 
If git push refs/for/ errors out, inspect stdout message to detect
uploadvalidator rejection. If present, present user a solution.

R=ajp@google.com

Change-Id: I70aee7615f3d905127a31bd5679968ade75c234a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2888475
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2021-05-12 18:28:34 +00:00
Josip Sokcevic
f5c6d8a27d Handle spaces in Gerrit search options 
Gerrit rejects requests with 400 Bad request if query string `q`
contains any spaces. Replace spaces with a plus sign solves the problem.

R=thakis@chromium.org

Bug: 1199692
Change-Id: Ic13dda378527594c6cf57b8cb2edf740517811ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2832653
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2021-05-12 18:23:24 +00:00
Brandon DeRosier
942a1eefc4 Respect GOMA_DIR in autoninja instead of always assuming .cipd_bin. 
Chromium + Fuchsia + Flutter Engine tools use GOMA_DIR to determine the
location of goma's scripts and binaries. Goma installs track some state
separately, and so when a different goma distribution's `compiler_proxy`
is launched and autoninja attempts to run `.cipd_bin/gomacc port`, the
check fails even though goma is running.

Additional context:
https://github.com/flutter/flutter/issues/81510#issuecomment-839489061
Change-Id: I93775628c6efba62bb226ac1995301c3ae7f5fa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891250
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Brandon DeRosier <bdero@google.com>
 2021-05-12 18:21:14 +00:00
Dirk Pranke
04cf3de933 Fix a Py3 bug in presubmit_canned_checks.py. 
There were a couple of references to using filter() that
needed to be replaced with list comprehensions as the return
values may be used repeatedly.

Bug: 1207012
Change-Id: Iae0abd38aeb186d6f7945f8c848c1f7312cb45bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890329
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2021-05-12 16:35:24 +00:00
Dirk Pranke
3b9d2d8557 Fix a Python3-compatibility issue in get_toolchain_if_necessary. 
Bug: 1207012
Change-Id: I9205089c3a7d9f2d3e2eb9aac7ef6da9ae9b0876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890330
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2021-05-12 16:26:04 +00:00
recipe-roller
8ac2b64226 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
955bddfc91~..dc36545f92232c37f4af4080296258fc1e240258
  955bddf (olivernewman@google.com)
      Do trivial s/master/main substitutions
  2200d7d (bryner@google.com)
      Upgrade cffi to 1.14.5 for the recipe engine.
  dc36545 (iannucci@chromium.org)
      [python3] Add test and do futurize --stage1.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icc1683726c3db84472f77333f6f6b9024f07dab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2891350
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2021-05-12 10:22:41 +00:00
recipe-roller
b47c95a58a Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
f4c9a77634
  f4c9a77 (olivernewman@google.com)
      [buildbucket] Make default git_ref consistent

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6b5526f445bbb7337ce8d18e10e855f7a91c587f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2885939
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 2021-05-12 10:05:25 +00:00
Brian Ryner
6e5b0a5c45 Update cffi wheel version to one that is available for Mac ARM64. 
Bug: 1205263
Change-Id: I0a2297c7a7d66807afe2ebf11558bc89afa793dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2890609
Commit-Queue: Brian Ryner <bryner@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-12 00:39:53 +00:00
Anthony Polito
f7157ceea8 add a big of debugging info to figure out more abour bot_update failures 
Change-Id: If324a6af154c4ded3b4c8d5e07a4740722318a59
BUG:1206377
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2889824
Auto-Submit: Anthony Polito <apolito@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 2021-05-12 00:23:12 +00:00
Allen Webb
b65bbfe4d5 Include original traceback in _run_check_function. 
This is a followup to CL:2797935 to make it easier to debug exceptions.

Bug: 1206782
Change-Id: Ibb649e94fd562919737de152e3203ca6b02b38ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880843
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>
 2021-05-11 21:22:01 +00:00
Nico Weber
4bd1522a29 gclient: Stop running git under "arch" on macOS 
We now have an arm python binary, so this should no longer be needed.

Bug: 1103326,1184767,1103236
Change-Id: I5510bf2c61adc2d0d505a886956a6677303df271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2888957
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-11 21:17:31 +00:00
Mike Frysinger
4bedb9d8c8 repo: update to latest version 
Change-Id: I81a29cf241f1633ed3fac830c0982a2dab7cc7fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2887605
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 2021-05-11 15:37:51 +00:00
Yoshisato Yanagisawa
cb17bc6028 Roll out new goma client binary VERSION=220 
Bug: b/186808715
Change-Id: Ice17a51b9a0bcd40b4662d0507dd20845f6c1160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2885984
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
 2021-05-11 04:32:50 +00:00
Scott Lee
c499142087 [lucicfg] release 1.24.4 version. 
Notable changes:
  move the cipd pin for cloud logging params in logdog
  https://crrev.com/c/2879575

Bug: 1164124
Change-Id: Ife6d6346b77379ed30f6e977751a4b7f4950c3ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2885198
Commit-Queue: Scott Lee <ddoman@chromium.org>
Auto-Submit: Scott Lee <ddoman@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 2021-05-10 20:40:16 +00:00
Nico Weber
524cdd8b7c download_from_google_storage: Use vpython3 instead of vpython 
We have vpython wheels for py3 but not for py2 on mac/arm. With this,
download_from_google_storage.py works on arm mac even without the
vpython bypass. (Also, moving from py2 to py3 seems like a good thing
in general.)

Bug: 1205263,1103236
Change-Id: I6cb08b7c56e5e6fc160fb5abc86d68e04a01f8de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2881917
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-10 19:17:43 +00:00
Brian Ryner
1039f6ca14 Roll vpython in depot_tools to the latest version. 
This version will no longer enforce that wheels exist for linux-x86
when running in "verify" mode. This is a prerequisite to rolling out
new wheels to vpython specs that use verification, since we no longer
build for Linux 32-bit.

Bug: 1176014
Change-Id: I13e77fe7b9ccc3741fa05ae493d171d0ed9aecac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2878769
Commit-Queue: Brian Ryner <bryner@google.com>
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2021-05-10 02:04:02 +00:00
Brian Ryner
03dfb00f96 Roll depot_tools cpython3 version. 
See e77e3c879a

Bug: 1175200
Change-Id: I340be41bd2c7e796de5d153b95873e4b45e5280e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2879116
Commit-Queue: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-09 23:55:42 +00:00
recipe-roller
b865acd3f2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
b64b15afdf
  b64b15a (iannucci@chromium.org)
      [python3] Add test and fix syntax+warnings for py3.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibda2918e076d774608ec0b49f15beaefb7827b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880846
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2021-05-07 21:59:00 +00:00
Nico Weber
360f981956 Bump python2 to 2.7.18 again, and pull it on mac/arm 
This time, the mac/intel binary was built with an older macOS SDK
which makes the runtime believe that the macOS version on Big Sur is
10.16 instead of 11.0, which should work around the Big Sur issue we had
in the last attempt.

This version was pushed to bleeding_edge in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876311

Bug: 1124119,1103236,1184768,1175200
Change-Id: I8614d6f22704d46bfa78b81c8e4b9ff7e6668487
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2880559
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-07 18:28:00 +00:00
Edward Lesmes
73faeeae3f metrics: Wait until upload is complete on bots. 
Otherwise, when the step completes, it won't be able to close
files used for stdout/stderr, since the metrics process is still
running.

Bug: 1206429
Change-Id: Id88578cbd9dab070e07f92e545ec137245566d16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877608
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
 2021-05-07 17:12:20 +00:00
recipe-roller
f9be70c9e6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
972327732a
  9723277 (iannucci@chromium.org)
      [python3] Add a python3 unittest which does nothing.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic95165944ec7285f5e8ee37a36b3b92bc4598c8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2879164
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2021-05-07 01:09:59 +00:00
Brian Ryner
e77e3c879a Update bleeding edge python versions. 
The new version is built with an older Xcode version for mac-amd64,
using the 10.15 SDK, which gives us better Big Sur compatibility for
some of the very old Python libraries we have in use. In particular,
it will see the OS version as 10.16 rather than 11.0, and recognize
the 10.x-built vpython wheels as compatible.

Bug: 1175200
Change-Id: I23be64b11c8a2fb31910ce5e13b98bd5b38eeb7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876311
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2021-05-06 23:56:59 +00:00
recipe-roller
b342958927 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
609ceedcf6
  609ceed (iannucci@chromium.org)
      [.vpython] Bump protobuf and six versions.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2c41f4530c3191dd8cd1abf2f2ebd1daa26df016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877607
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2021-05-06 23:09:59 +00:00
Edward Lesmes
cb04744f32 Reland "git-cache: Start collecting metrics." 
This is a reland of a84eaf515f

Original change's description:
> git-cache: Start collecting metrics.
>
> Change-Id: I36f4b37a78ad23d615e3f49f158e8de785d5214a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2875855
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I80091d78deb0b1aaba280572a1384848990d9d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2877262
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2021-05-06 20:18:49 +00:00
Edward Lesmes
9c34906c59 metrics: Don't print notice if reporting build metrics. 
Change-Id: Ib7e23cd1b57c6d0497f0e0ff1fe31b38f11bfc00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876082
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2021-05-06 20:02:39 +00:00
Edward Lesmes
5009fd68ac Revert "git-cache: Start collecting metrics." 
This reverts commit a84eaf515f.

Reason for revert:
Should not print notice.
https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8848034039500209104/+/u/bot_update/stdout

Original change's description:
> git-cache: Start collecting metrics.
>
> Change-Id: I36f4b37a78ad23d615e3f49f158e8de785d5214a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2875855
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I5d73cfccbcfc75ec26c7ba7127c1320002224e47
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2876069
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-05-05 22:55:09 +00:00
Edward Lesmes
a84eaf515f git-cache: Start collecting metrics. 
Change-Id: I36f4b37a78ad23d615e3f49f158e8de785d5214a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2875855
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2021-05-05 21:54:36 +00:00
Edward Lesmes
7522924749 gclient: Set DEPOT_TOOLS_REPORT_BUILD to report bot metrics. 
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: chromiumos
Change-Id: I5c7b2188a84580a0575e9e748946e66cc7140787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872856
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2021-05-05 17:42:06 +00:00
mlcui
3da91715d3 git cl upload: Use default patchset message when user's message is "y" 
Users sometimes type in "y" to confirm the default patchset message,
resulting in a patchset being uploaded with "y" as the message.

We can make a fair assumption that no-one would willingly use a patchset
message of "y", so this CL uses the default patchset message whenever
this happens.

(I have personally done this myself and have seen at least one other
person do the same.)

Bug: None
Change-Id: Iad314d35aa830b62152ab2910eb37d876b7e450b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861643
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Michael Cui <mlcui@google.com>
 2021-05-05 10:00:30 +00:00
Yuanjun Huang
6b022d1efb [cipd] Roll led to @c7e0fe5a 
Release the led which has the `-adjust-priority` flag

change logs:
infra/infra: bf50da1e..c7e0fe5a
luci-go: 5c64c54..26c1d75b

Bug: 1138533
Change-Id: Idd19d44f375143db0f5e7bf256b7b32567e8b393
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872927
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
 2021-05-04 23:46:20 +00:00
Robert Iannucci
d3acb16c9c [git-rebase-update] Disallow git gc during git-rebase-update. 
In theory this should prevent `git rebase-update` from invoking
potentially expensive `git gc` operations after every `git rebase`
(ideally once per branch, but sometimes as many as three per branch (!)).

This has outsized effects as the size of the repo or number of branches
increases, and additionally has penalties on Windows due to git's
POSIXey assumptions around how disk I/O works.

After doing all rebase stuff, we run `git gc --auto` from rebase-update
once (assuming we were successful; if the command failed then we don't
run gc at all).

R=apolito@google.com

Bug: 617218
Change-Id: I37a8f7953779f15b320e4ed7bb85119cb4bb665a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2868766
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2021-05-04 21:37:40 +00:00
Andrii Shyshkalov
0f402641d0 [auth] log errors from luci-auth token invocation. 
Motivating example -- seemingly empty output in this build:
https://luci-milo.appspot.com/ui/p/devtools-internal/builders/ci/Auto-roll%20-%20frontend/587/overview
R=vadimsh

Change-Id: I12f1acb1b4852f57057684b26fb153ab74e2da39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2871721
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
 2021-05-04 21:04:20 +00:00
Nico Weber
e038acc7e1 Revert "Bump python2 to 2.7.18" 
This reverts commit 029279376e.

Reason for revert: https://crbug.com/1175200

Original change's description:
> Bump python2 to 2.7.18
>
> That version was pushed to bleeding_edge in
> https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861642
>
> Bug: 1124119
> Change-Id: Id4ab5cb599dc85f3da7784163ddd46b2cd7c7980
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867872
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1124119
Change-Id: I70124c502c84713e2bbb809793353c74e2e40645
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872006
Auto-Submit: Nico Weber <thakis@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-04 17:03:31 +00:00
Nico Weber
795f75187f Revert "[mac/arm] pull python2 binary in cipd bootstrap now that it exists" 
This reverts commit 44e954ddfb.

Reason for revert: Prerequisite for https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872006

Original change's description:
> [mac/arm] pull python2 binary in cipd bootstrap now that it exists
>
> Bug: 1124119,1103236,1184768
> Change-Id: Ie56611586dd6f79989fba970de20846b845b08b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2870586
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

Bug: 1124119
Bug: 1103236
Bug: 1184768
Change-Id: I9de566312d40d9fd109d245eab36b26d19e3b0b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2872007
Auto-Submit: Nico Weber <thakis@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-04 17:03:00 +00:00
Nico Weber
44e954ddfb [mac/arm] pull python2 binary in cipd bootstrap now that it exists 
Bug: 1124119,1103236,1184768
Change-Id: Ie56611586dd6f79989fba970de20846b845b08b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2870586
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-04 16:00:40 +00:00
Nico Weber
029279376e Bump python2 to 2.7.18 
That version was pushed to bleeding_edge in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2861642

Bug: 1124119
Change-Id: Id4ab5cb599dc85f3da7784163ddd46b2cd7c7980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867872
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2021-05-03 23:37:09 +00:00
Nico Weber
4570dcf468 Convert manifest files in bootstrap/ to unix line endings 
Hopefully no behavior change :)

Bug: none
Change-Id: I62710ce8c07c4df4cb0fd8cb916127616f47ee8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2867312
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2021-05-03 22:27:09 +00:00