InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
9,287 Commits 6 Branches 0 Tags
67702834ccbdc6e8f054f9cd2ba97a8c76848cd2
Commit Graph

9287 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike Frysinger
67702834cc cipd/python: optimize cat usage 
Bash has a builtin for reading files, so use that instead of running
the cat program to save on time & overhead.

Change-Id: Ia90fc22a47f2ead4ef056020a79ebdebd7bd70ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4111082
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-01-23 15:31:10 +00:00
Joanna Wang
e852391441 [stacked_changes] Create cherry-picked commit. 
Bug:b/265929888
Change-Id: I4277474c1f09e4ac6ea6ebb5d9d340f22365f542
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178924
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2023-01-21 02:05:40 +00:00
Joanna Wang
b46232e729 [stacked_changes] Add Changelist._PrepareChange() common func called before creating commits. 
Bug: b/265929888
Change-Id: I18a0c5ba6757aef91e750b9703079c96b090dc1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178920
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-21 01:58:46 +00:00
Joanna Wang
ab9c6ba27f Make cwd optional for scm.IsAncestor() 
Bug:b/265929888
Change-Id: I9f25cd26eaf2d708ce3ac7d86503bb2c295c8406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178351
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-01-21 01:46:36 +00:00
Joanna Wang
18de1f68e6 [git cl]Add precheck function for stacked changes upload. 
High-level rough draft: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4166282

Bug: b/265929888

Change-Id: I7881ade0ea97d7537e1dd40ab484ee5ef828aa34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4175861
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-21 01:24:24 +00:00
Joanna Wang
39811b1915 Remove TBR from git cl 
Bug: b/266235601
Change-Id: I8122cf38d5a2c6879c32eafc6abd8fa306095125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4185277
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-20 23:09:48 +00:00
Ben Segall
eb2866e654 Create reclient specific ninja wrapper to properly handle reproxy lifecyle 
This is required as it is impossible to catch a keyboard interrupt in a
windows batch file and we dont want zombie reproxy instances running on
developer's machines for performance and metric collection reasons.

Bug: b/264405266
Change-Id: I00f036c8f14451cdb1b99a5cad1c2af03dd57d57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4171506
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Ben Segall <bentekkie@google.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
 2023-01-20 20:14:44 +00:00
recipe-roller
7c6ebe7fd1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8791438976452092001

recipe_engine:
a44d1d3092
  a44d1d3 (olivernewman@google.com)
      [cas] Use -paths-json instead of -paths

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If34f3cea472abde391576d1a533ce6bf5038266d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4182697
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-20 15:19:10 +00:00
Richard Townsend
1b4407e7c6 Use x64 emulation for Windows on Arm targets 
windows-386 packages have started to bit-rot, use the windows-x64
versions instead (this implicitly restricts us to Windows 11)

Change-Id: If5417e9463914d9cb7b2e738ff46ef0faea4d1ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4116709
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-20 14:49:42 +00:00
Simeon Anfinrud
aec39c38f8 (Reland) Detect RBE builds and accelerate them. 
Chromecast builds use a buildflag called `use_rbe` instead of
`use_remoteexec` or `use_goma`.

Previous attempt at crrev.com/c/4144469 tried recycling the
use_remoteexec variable for the use_rbe case, but that caused
problems with Cast CI because it would hit the error case
where the reclient binary isn't found.

This new attempt introduces a new dedicated use_rbe variable
that skips that check intended only for use_remoteexec.

Bug: b/266099996
Test: run `autoninja` in the chromecast internal repo
Change-Id: Ieaf3af709589fe1b8611904afc2fd80284b333b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4179133
Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2023-01-20 00:37:41 +00:00
recipe-roller
5a93263d93 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8791495598560944193

recipe_engine:
26cd5483c9
  26cd548 (kimstephanie@google.com)
      Create luci_analysis recipe_module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I74fa059cfbe8edacffd0ccef5e65d74ff7095e82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4182686
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-20 00:19:48 +00:00
Ben Segall
7954ed74a2 Ensure boostrap shutdown runs if ninja is killed with a signal 
This fixes the issue for linux. I will follow up with a windows fix

Bug: 264405266
Change-Id: I518412b06e410d82d02a085180a24987f9ba98fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4134101
Auto-Submit: Ben Segall <bentekkie@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 2023-01-19 22:35:56 +00:00
Joanna Wang
c8f23e26be Revert "Remove rietveld.cc to test removing all reitveld config sttuff." 
This reverts commit 8c5174b527.

Reason for revert: Need to replace this before removing.

Original change's description:
> Remove rietveld.cc to test removing all reitveld config sttuff.
>
> Bug:b/266001713
> Change-Id: Ib5342e7519d7f7eaccf0a0a6f4a39c13677406bb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178919
> Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
> Commit-Queue: Joanna Wang <jojwang@chromium.org>

Bug: b/266001713
Change-Id: Ief110063e7146f045df669ec138c4f01eccc44d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4182421
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
 2023-01-19 21:18:10 +00:00
Josip Sokcevic
884d716ce0 Run all presubmits with py3 if py2 isn't available 
This utilizes env variable set by LUCI: https://crrev.com/c/4087937 and
luci.buildbucket.omit_python2 experiment.

R=gavinmak@google.com

Bug: 1401307
Change-Id: I0e6c6fae7cdd1e6044fe7d7c4008f7da3a1bbf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4179134
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-01-19 21:17:56 +00:00
recipe-roller
8d8b2de33b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8791510072234548561

recipe_engine:
7ec46d46ce
  7ec46d4 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from ff9307900bad to 8e7b251208a2

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iabb00a9010c71e5b13d76e8222c4fab7a7f43f2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4179887
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-19 20:32:52 +00:00
Chan Li
35db69d337 [depot_tools] roll bb 
To release https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4167060

Change-Id: I51549050e561ca2ec3d3b498def8cede0410af97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4179132
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
 2023-01-19 19:03:01 +00:00
Jonas Termansen
bf7eb5292c [portability] Support unknown operating systems in gclient. 
Detect the name of unknown operating systems using uname, if available,
since it doesn't append the operating system version.

Change-Id: Idab7bd0db65a8d424ec2fd48f06247405b6649e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4169240
Auto-Submit: Jonas Termansen <sortie@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-19 17:56:40 +00:00
Brian Ryner
faf64f1f63 Minor update to git. 
Change-Id: I35573be46a7d9b482b13205e029ea607d4b2e5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4177975
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Brian Ryner <bryner@google.com>
 2023-01-19 05:06:49 +00:00
recipe-roller
88e8d54989 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8791579276901246017

recipe_engine:
4ddc3eab0c
  4ddc3ea (funing@google.com)
      Add interpreter option for py scripts

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0f375e4ee4e5bfa5a9ca76fdc43fb29adad8e15f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4179870
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-19 02:07:46 +00:00
Joanna Wang
8c5174b527 Remove rietveld.cc to test removing all reitveld config sttuff. 
Bug:b/266001713
Change-Id: Ib5342e7519d7f7eaccf0a0a6f4a39c13677406bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4178919
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2023-01-19 00:07:48 +00:00
Aravind Vasudevan
a111c9189d Fix roll dep to use update-index 
This change updates roll-dep to update submodule revision using `git update-index` instead of `git add` to stay consistent with our design.

Fix: 1406766
Change-Id: Ic23b9758a5893ac211d459a3c451bb102d4501a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4177144
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-18 23:44:40 +00:00
Aravind Vasudevan
474e28e576 Add submodule support to roll-dep 
This change adds submodule support to roll-dep. Currently, roll-dep command takes a set of dependencies, revisions to roll them to (or origin/HEAD by default), uses `gclient getdep` to get the current rev, and `gclient setdep` to update the DEPS file.

With this change, if `.gitmodules` is present, roll-dep uses it instead to find the current revision and also updates the submodule's pinned revision. This also keeps the existing flow for updating DEPS file for interperability.

Fixed: 1406766
Change-Id: I56b6e268cc1a7c49dabc2dc39fef2d820d2690c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4167341
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2023-01-18 20:29:51 +00:00
Aravind Vasudevan
7b1f98e9c6 Skip reauthentication when ~/.boto file is present 
This fix skips luci-auth ~/.boto file is already present.

Bug: 1407306, 1359383
Change-Id: I333b6baf693bfed295a2467c7a543432111be4dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4175408
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
 2023-01-18 17:34:15 +00:00
Michael Achenbach
86cfa62b07 [presubmit] Use vpython3 on bots without vpython2 
Bug: 1401307
Change-Id: Ie81608be8e8ec64ed569b0367f1426b4b2ab8b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4110968
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-18 00:55:15 +00:00
Weilun Shi
4f50adb332 Remove the one-linear check for the validate_prefix file 
The validate_prefix file is now rolled out on prod so we
don't need that check any more.

Bug: 1116488
Change-Id: Ibbbfd29366e3e41d8e52d65dd7553f2e521ffd63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4167358
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-01-17 20:43:17 +00:00
Fumitoshi Ukai
7879da9e9d run goma_ctl update_hook in update_depot_tools 
to make sure goma runs the latest version,
run `goma_ctl update_hook` in update_depot_tools

Bug: b/260864926
Change-Id: If8a6bc1b6e3b18339672dc26f609fab2d84aa987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4160794
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2023-01-17 17:59:50 +00:00
Aravind Vasudevan
175767738f Reland "Update log when luci-auth is not logged-in" 
This is a reland of commit 5e5802d7a2

This was reverted as a temporary fix for servers running python 3.5. This reland removes `encoding` arg from `subprocess.run` temporarily until all servers are migrated to a supported python version.

Original change's description:
> Update log when luci-auth is not logged-in
>
> This change updates gsutil.py to capture when luci-auth is not logged in and prints useful log for signing in. This change couple enables luci-auth UI when luci-auth is enabled.
>
> Bug: 959170, 1359383
> Change-Id: Ic636bb362df388073e1fd11d736a47f35b749016
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4154550
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 959170, 1359383
Change-Id: I409a49362f0c584bd39f1031671e9e089cf50f97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4165881
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-13 19:50:51 +00:00
William Hesse
a4eeafaa2f Revert "Update log when luci-auth is not logged-in" 
This reverts commit 5e5802d7a2.

Reason for revert: This CL introduces a dependency on Python version 3.10.  I'm not clear that this is allowed for depot_tools.  We are using it on systems with Python 3.5.

Original change's description:
> Update log when luci-auth is not logged-in
>
> This change updates gsutil.py to capture when luci-auth is not logged in and prints useful log for signing in. This change couple enables luci-auth UI when luci-auth is enabled.
>
> Bug: 959170, 1359383
> Change-Id: Ic636bb362df388073e1fd11d736a47f35b749016
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4154550
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 959170, 1359383
Change-Id: I0a73051f6b65786374f2b585f13ca88f5f8f83d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4165720
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2023-01-13 16:36:43 +00:00
Brian Ryner
e38d195b63 Roll all tools to versions that are built for windows-arm64. 
git 1.39.0 was previously rolled to manifest_bleeding_edge in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4149950 and is now being rolled to all users.

Change-Id: I4c7a3bc60e6b3b2625cee59138235d398adb27c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4159755
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Brian Ryner <bryner@google.com>
 2023-01-13 00:38:53 +00:00
Aravind Vasudevan
5e5802d7a2 Update log when luci-auth is not logged-in 
This change updates gsutil.py to capture when luci-auth is not logged in and prints useful log for signing in. This change couple enables luci-auth UI when luci-auth is enabled.

Bug: 959170, 1359383
Change-Id: Ic636bb362df388073e1fd11d736a47f35b749016
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4154550
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2023-01-12 22:29:42 +00:00
Andrew Grieve
c2a4f5db62 Skip gclient auto-update for "getdep", "root", "help", "--help" 
These are all things I would expect to not hit the network.

Bug: None
Change-Id: I44bddd94e8da13df57f3cd068def9a5e51774bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4161184
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2023-01-12 17:28:44 +00:00
Vadim Shtayura
4f3b322a39 [cipd] Add windows-arm64 support to CIPD client bootstrap. 
This actually updates the CIPD client to a version that has
a windows-arm64 build, as well as modifies the bootstrap script
to support multiple possible Windows platforms (which is very
similar to what was done to support mac-arm64 on OSX).

By default windows-amd64 is still used everywhere, even on arm64 OS.
To opt-in into windows-arm64, create a file .cipd_client_platform
under depot_tools directory with a single line "windows-arm64".

The bootstrap script now recognizes this file (if it exists) and
rebootstraps the CIPD client if the platform changes. Since this
check needs to happen on every CIPD invocation, it is done in
the batch file, to avoid hitting relatively heavy Powershell on
the hot path.

Finally, do some minor style cleanup in the powershell script to
make it look more consistent.

CIPD client change log:
9cc9fd49..5252f4fc7/cipd

R=bryner@google.com

Change-Id: I4fe5c4ea5e0b5cbb43e7b8c4702dc9fb0627c056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4153336
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2023-01-12 00:11:03 +00:00
recipe-roller
9a2a8cddc1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8792227926665315153

recipe_engine:
573a3a6797
  573a3a6 (randymaldonado@google.com)
      [recipes-py] passing debugging experiment to children in placeh...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e937f22c7c5184015e1d120e062f2a28e235d7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4157937
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-11 22:19:48 +00:00
Matt Swartwout
762f1e0673 Revert "Detect RBE builds and accelerate them." 
This reverts commit f4fa0cc7c1.

Reason for revert: This broke chromecast infra

Original change's description:
> Detect RBE builds and accelerate them.
>
> Chromecast builds use a buildflag called `use_rbe` instead of
> `use_remoteexec`.
>
> Bug: None
> Test: run `autoninja` in the chromecast internal repo
> Change-Id: Iebb18ad47a30c4152923f48175222ec6a20e16f4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4144469
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: None
Change-Id: Ib93820b6045088b7dcb45d1f14c0d4f83dc92ebc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4157771
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Matt Swartwout <mwswartwout@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-01-11 18:24:43 +00:00
Brian Ryner
790a0c522d Fix CheckCIPDManifest for python 3. 
Change-Id: Icf7b8e7ad732a731520550ff9e276f13016effb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4149964
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Brian Ryner <bryner@google.com>
 2023-01-11 17:43:46 +00:00
Junji Watanabe
3e7206ff0a Remove CPATH,LIBRARY_PATH,SDKROOT env vars set by macOS python3 
macOS python3 sets those env vars implicitly. https://openradar.appspot.com/radar?id=5608755232243712

Removing them to avoid changing clang's behaviors.

Fixed: 1403485
Change-Id: I2ecf0cad8a1f69f5d7d180d2a2a003ce97365f3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4149962
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
 2023-01-11 02:33:26 +00:00
Brian Ryner
3d8429ca2a git 2.39.0 to depot_tools bleeding edge. 
This seems to have better compatibility with windows-arm64.

Change-Id: I99950be434b80c010d3dd499c7121c8dd214fe95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4149950
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Brian Ryner <bryner@google.com>
 2023-01-10 22:24:38 +00:00
Simeon Anfinrud
f4fa0cc7c1 Detect RBE builds and accelerate them. 
Chromecast builds use a buildflag called `use_rbe` instead of
`use_remoteexec`.

Bug: None
Test: run `autoninja` in the chromecast internal repo
Change-Id: Iebb18ad47a30c4152923f48175222ec6a20e16f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4144469
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2023-01-10 22:01:57 +00:00
recipe-roller
d28e8d05a4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8792319781184436977

recipe_engine:
f54f0ff1aa
  f54f0ff (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from fbd6932d11fa to 81e5cdad29bb

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I019255fe6620b984f525c9a11970a6598a6c324d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4151320
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-10 22:01:37 +00:00
Junji Watanabe
2b1aa8dcab Add single file compile support for Windows in ninja wrappers 
ninja.bat can't pass '^' for single file compile.
This change fixes ninja.bat to apply double quotas to args to preserve "^".
Note that ninja.bat still needs "^^" since single "^" is already removed  as an escape character.
This is the same implementation with autoninja.{bat, py}.

Test: http://go/paste/6182226814304256

Bug: 1340825
Change-Id: I183c7890634a77471a617c4cc2b9c8c33bc8487d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4060603
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2023-01-10 02:20:13 +00:00
Aravind Vasudevan
7af6169852 Update gsutil.py to use luci-auth for authentication 
The change updates gsutil.py to internally use luci-auth for
authentication. It redirects `gsutil.py config` to `luci-auth login` and
wraps gsutil.py calls using `luci-auth context`.

The change is mainly done to ensure users have a way to authenticate once OOB authentication flow is deprecated. This patch falls back to using the .boto file when that is provided.

Design Document: go/gsutil-oauth-issue-resolved

Bug: 959170, 1359383
Change-Id: Icc6df1d8b93424ac0f6e2df84afdebc869763ede
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4109192
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 2023-01-09 23:15:15 +00:00
Chan Li
dcb79c7080 [depot_tools] roll dirmd 
To release https://chromium-review.googlesource.com/c/infra/infra/+/4144455

Bug: 1402202
Change-Id: I798dfa8866ccdb82e0c9c684a3c5e4414c8f8962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4146187
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 2023-01-09 22:39:08 +00:00
Pavol Marko
624e7eec34 Change working directory to PRESUBMIT's dir also for postsubmit 
While we're at it, ensure that the working directory is reverted even if
exceptions are raised by moving that part into a finally block.

Bug: 1404222
Change-Id: I8606bc5810202ff1ecdc7f202e3f574bf643f91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4129515
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
 2023-01-09 09:56:29 +00:00
Gavin Mak
6f905470df Print overview of external changes 
This gives users an idea of what changes they are applying.

Bug:1382528, 1405491
Change-Id: Icb1e94f193b9cba3d80cc918c2abb11c2527ad3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4082289
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2023-01-06 21:01:36 +00:00
Brian Ryner
50985d5fdd Don't run cipd from depot_tools, it lives in a different location on Swarming. 
Bug: b/264453023
Change-Id: I3a149c0a70b11a1718a73afcda6644a4d3b3c93f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4138059
Auto-Submit: Brian Ryner <bryner@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 2023-01-05 23:49:37 +00:00
Quinten Yearsley
f9f61a9d7c Release lucicfg 1.37.0 stop generating unused properties triggered_by and location_regexp 
triggered_by in CQ configs has now not been used by any projects
for a month. This is a deprecated property that we don't
support anymore in CV.

location_regexp and location_regexp_exclude has been replaced by location_filters and is not used in any projects any more.

Related buildbucket config change at
https://chrome-internal-review.googlesource.com/c/infradata/config/+/5229868

Bug: 1395209
Change-Id: I4e53606c8bcd7a784970beb337984a808321c5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4113683
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 2023-01-05 22:15:42 +00:00
Weiwei Lin
58a343c88b [depot_tools] roll rdb 
To pick up
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4127735

R=gavinmak@google.com, meiring@google.com

Bug: 1373762
Change-Id: I811d3dfbb6a158996394ad9ec13674a90a9253da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4135663
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Weiwei Lin <weiweilin@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2023-01-05 00:45:20 +00:00
Brian Ryner
252b19866a Redirect cros calls to py2.7 scripts to the vpython2.7 package. 
Bug: 1245665
Change-Id: I1b75e2a515e6c8b1b7b0192946a2cfd5295a21f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4015440
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 2023-01-03 22:56:22 +00:00
Bruce Dawson
7a81ebf111 Add .rs to list of presubmit source file patterns 
.rs files were not part of DEFAULT_FILES_TO_CHECK which means that they
were not being checked for proper licenses, among other things.

Testing with this command reveals that six missing or bad licenses have
crept in:

    git cl presubmit --force --files "*.rs"

Output was:

Found a bad license header in these files:
  build\rust\tests\test_aliased_deps\main.rs
  build\rust\tests\test_aliased_deps\real_name.rs
  mojo\public\rust\tests\util\mojom_validation.rs
  testing\rust_gtest_interop\gtest_attribute.rs
  tools\crates\gnrt\sample_package\foo\src\lib.rs
  tools\crates\gnrt\sample_package\src\main.rs

Change-Id: Ia7788d92d428a4060f4a0b854fdcee0450b0a3f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4128762
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2023-01-03 18:36:18 +00:00
recipe-roller
5b0c934026 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8793081676879223793

recipe_engine:
46fb59926a
  46fb599 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 02ae470ec2d1 to 89298485414b

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iace4339949f986a0f30109173868a2eedd216441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4131121
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2023-01-02 12:10:10 +00:00