InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,946 Commits 6 Branches 0 Tags
4b9413003436466d374a306d879338680c54b467
Commit Graph

10946 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Allen Li
4b94130034 [gerrit_util] Add fallback if missing Gerrit account 
Bug: b/366261039
Change-Id: I7d22c4f03ad9bd837190dee7a511af3437a30434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5869050
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-09-18 21:57:33 +00:00
recipe-roller
9650e09a4c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8736422083488578289

recipe_engine:
71016c2fda
  71016c2 (linxinan@chromium.org)
      nodejs module does not need /bin suffix for PATH in win builds

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I541522d880b7fbf8b9a9425fbe0736c72f7017c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5874602
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-18 21:49:44 +00:00
recipe-roller
bbfbfaf2be Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8736432778076128833

recipe_engine:
29bd4696ad
  29bd469 (mohrr@google.com)
      [step] Assert step name is non-empty

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5ec34f450966de514f3e6b8c658bd93c9e0ef198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5874599
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-18 19:03:03 +00:00
Josip Sokcevic
945cb0c0d7 Add roll_downstream_gcs_deps.py to depot_tools recipe module. 
Change-Id: I7b8a8f8e686c89fcb5fe2d27f6b506e53a26d535
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5867087
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2024-09-18 16:21:39 +00:00
Allen Li
74ec765457 [gerrit_util] Skip gitcookies help with newauth enabled 
Change-Id: Ie74761efd7bbb50051994a83f21ed150ddf8e4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5871206
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-09-17 22:41:09 +00:00
Josip Sokcevic
76021e34e5 Update roll_downstream_gcs_deps to take a list of source and destination packages. 
This is needed to support rolling multiple packages at once when package
names don't match.

Change-Id: I20bb5edfee87bb3e089a2c25f597e4778e0fe60f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5867086
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
 2024-09-17 22:36:08 +00:00
Allen Li
58e0e19462 [git_auth] Remove old option cleanup 
Change-Id: I426199d05613397a74aba87ad8dcbd67a0175ee7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5869051
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-09-17 21:52:13 +00:00
Allen Li
b32c4f1abc [gerrit_util] Add auth parameter to GetAccountDetails 
We need to use this to determine if an account exists to determine
what auth to use, so we have to be able to override the default auth
detection.

Bug: b/366261039
Change-Id: I814b47ac1518170846ff9a7e5dc210f26db3e985
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5869049
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-09-17 20:31:42 +00:00
Allen Li
b471d6f709 [scm] Fix type annotations 
Change-Id: If18010e076b4b9bac540ff03daefc7d312713778
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5867128
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2024-09-17 20:30:04 +00:00
Allen Li
6429a2f9e5 [gerrit_util] Fix ShouldUseSSO with no account 
Bug: b/366261039
Change-Id: I77cd3a45ebb6e67eebcae6dc44a30b46b954a545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5867127
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-09-17 20:29:02 +00:00
recipe-roller
6e9a3df972 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8736575594686767713

recipe_engine:
2cacf729f7
  2cacf72 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from add042d0e15f to f395cad73f6f

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib7951bc27ca336d2c747cf4a549ddd3e1961456b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5867277
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-17 05:14:42 +00:00
recipe-roller
c5df152f10 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8736610197301215793

recipe_engine:
53decf356b
  53decf3 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 0aab06763983 to add042d0e15f

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If56f2036bee666737ffd98a60f1f82e8ab6f1672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5867117
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-16 20:00:30 +00:00
Mark Mentovai
22df6f8e62 autoninja: fix strings with invalid escape sequences 
Since 61fad561d6 (https://chromium-review.googlesource.com/c/5848450,
2024-09-11), autoninja under Python 3.12 presents these warnings:

```
…/autoninja.py:73: SyntaxWarning: invalid escape sequence '\s'
  m = re.match('instance\s*=\s*projects/([^/]*)/instances/.*', line)
…/autoninja.py:92: SyntaxWarning: invalid escape sequence '\s'
  m = re.match('SISO_PROJECT=\s*(\S*)\s*', line)
```

This warning appears in Python 3.12 ([1], [2], [3]).

'\s' and '\S' are not valid escape sequences in strings. r'\s' and r'\S'
are valid in regular expressions, but outside of raw strings, they would
need to be written as '\\s' and '\\S'.

There is no reason to not use raw strings in this case, so the new
regular expression pattern strings introduced in 61fad561d6 are
changed to raw strings.

[1] https://docs.python.org/3/whatsnew/3.12.html#:~:text=A%20backslash%2Dcharacter%20pair%20that%20is%20not%20a%20valid%20escape%20sequence%20now%20generates%20a%20SyntaxWarning%2C%20instead%20of%20DeprecationWarning.
[2] https://github.com/python/cpython/issues/98401
[3] https://github.com/python/cpython/pull/99011

Bug: b/364318216
Change-Id: I0f237976fe9c39208541ae78205f5bdbf126fa82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5859159
Commit-Queue: Mark Mentovai <mark@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Auto-Submit: Mark Mentovai <mark@chromium.org>
 2024-09-13 16:08:45 +00:00
Joanna Wang
d43a3eb748 Add end_commit for calculating GitChange diffs. 
Bug: b/365162784

Change-Id: I97b69b1ae5183bbdaa7d4de0b1f23e62f4e1d8d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5853908
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2024-09-12 21:07:57 +00:00
Junji Watanabe
20a0cda9e9 ninjalog_uploader: Distinguish between explicit and default build configs 
This CL adds `explicit_build_config_keys` to the metadata for the server
to distinguish between explicit and default configs.
This CL excludes the configs set in `//.gn` from the list, so that
the configs specified by users will be considered as explicit.

Bug: 364971744
Change-Id: I6a3d289d8ca6e054dac691051b53c92ad1ec23c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5853009
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2024-09-12 03:00:34 +00:00
Patrick Meiring
17226d7965 [depot_tools] Roll CIPD. 
To ensure https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5834682 is included via
b1f414539a.

Diff:
be41b8d978..b1f414539a

BUG=b:349254870

Change-Id: If63a49c7781dac5a6430367a0bc95720843f2281
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5856579
Auto-Submit: Patrick Meiring <meiring@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2024-09-12 02:30:21 +00:00
Patrick Meiring
e08157e1f0 [depot_tools] Roll everything. 
To ensure https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5834682 is included via
b1f414539a.

N.B. it is possible some of these don't include luci-auth code, I didn't check.

Diffs:

vpython:
f7fecd758a..b1f414539a

led, prpc, luci-auth, git-credential-luci, bb, rdb:
165155b778..b1f414539a

lucicfg:
1fdeb2c6cc..b1f414539a

mac_toolchain:
05fe195bf7..b1f414539a

dirmd:
9558e2c2dc..b1f414539a

pinpoint:
fc7aae4225..b1f414539a

BUG=b:349254870

Change-Id: I1a1c9fd7942d02f0fa07b1ba9d1a4dca77ad5219
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5856168
Commit-Queue: Patrick Meiring <meiring@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 2024-09-12 00:50:45 +00:00
Struan Shrimpton
9903e62e20 Add config to the telemetry lib 
This provides the consistent config between runs. This only supports
linux at the moment, a windows support CL will follow up. Note the
current count down is stored to ensure we provide the banner a minimum
of 10 times and a uuid is stored which is collected in lieu of the
actual username

Bug: 326277821
Change-Id: I3817436ea213c755f490914023508a10cf3cef1b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5855459
Reviewed-by: Terrence Reilly <treilly@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 2024-09-11 23:10:14 +00:00
Struan Shrimpton
55d065cc0c Add anonymization and the protos to the telemetry lib 
Add the protos for the traces used to publish metrics to Clearcut and
the anonymization code/test that ensure we don't collect de-anonymized
paths.

Bug: 326277821
Change-Id: Ifae4d51f59db2219995a0a8d21785729f5eeb137
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5850298
Reviewed-by: Terrence Reilly <treilly@google.com>
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
 2024-09-11 18:18:26 +00:00
Max Ihlenfeldt
62475a5ed8 autoninja.py: Fix "SyntaxWarning: invalid escape sequence '\s'" 
Bug: None
Change-Id: Id19557ff5f115f1cacee85f113174535112f7c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5854399
Commit-Queue: Philipp Wollermann <philwo@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
Auto-Submit: Max Ihlenfeldt <max@igalia.com>
 2024-09-11 15:19:56 +00:00
Aleksey Khoroshilov
1ad5b6c0df Do not fail if RBE project is empty. 
External developers may use RBE without RBE_instance set.
Autoninja should not fail in this case.

Change-Id: I2dbafded690246132bb0ff1cd080caa0b758b4f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5851434
Auto-Submit: Aleksei Khoroshilov <akhoroshilov@brave.com>
Commit-Queue: Aleksei Khoroshilov <akhoroshilov@brave.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2024-09-11 06:13:32 +00:00
Fumitoshi Ukai
61fad561d6 autoninja: check RBE project, not account 
Account check would become too slow.
We'll check RBE project to use instead.

On corp machine, our policy to use @google.com account
and rbe-chrome-untrusted to build chromium/chrome.
We don't allow rbe-chromium-untrusted with @chromium.org
on corp machine.

On non-corp machine, user couldn't use rbe-chrome-untrusted
because it's @google.com only, and corp security policy
doesn't allow @google.com account on non-corp machine.

Bug: b/364318216
Change-Id: I0f3a19e105b050aef6a62e1b25b45b1722382a34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5848450
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Michael Savigny <msavigny@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
 2024-09-11 00:03:49 +00:00
Struan Shrimpton
c36eb432d9 Add the detector to telemetry library 
The detector can be a pretty direct port from chromite. A lot of these
metrics aren't likely neccesary but will be good to have complete
trace protos rather than missings parts. This also creates the
presubmit and .vpython3 file necessary to run the unit tests

Bug: 326277821
Change-Id: I4dbeabbbced4715527201eca888948b07b6004ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5840599
Commit-Queue: Struan Shrimpton <sshrimp@google.com>
Reviewed-by: Terrence Reilly <treilly@google.com>
 2024-09-10 21:52:28 +00:00
Peter Kasting
c246cf3e84 Fix spelling error and wrap output at 80 columns. 
Bug: 362787698
Change-Id: I5d31783dd8f659ba6e5e37c2f3961971874e851e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5851653
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
 2024-09-10 21:10:51 +00:00
Junji Watanabe
46f5de67e1 build_telemetry: Do not print warning message for cipd auth-info error 
The warning message is always printed for non-Googlers.
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5842066/comments/c124a640_3e9ee3ea

Change-Id: I9be51813e7531adcdeed6e2f7446aedc8700b880
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5848451
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
 2024-09-10 05:51:16 +00:00
Scott Lee
8258c1340a [depot_tools] annotate third_party/colorama as non security critical 
https://github.com/tartley/colorama a python library that makes
ANSI escape character sequences work under MS windows.

AFAIK, the library itself is not used to perform,
nor does it perform, any of the operations, listed in
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/adding_to_third_party.md#add-a-readme_chromium

Bug: 365320907
Change-Id: I2bb9301a3420b0813675c8952f8720e1395761ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5843576
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-09-09 23:25:57 +00:00
Yiwei Zhang
653e86a6f0 define security critical attribute in third_party/schema 
It is not packaged in Chromium/Chrome so I assume that implies
it's not security critical. Moreover, the library[1] doesn't seem
to do anything mentioned in [2]

[1]:https://github.com/keleshev/schema
[2]: https://chromium.googlesource.com/chromium/src/+/HEAD/docs/adding_to_third_party.md#add-a-readme_chromium

Bug: 365321156
Change-Id: I824b15feedb19ee3d1a7fa6d78bc2c9a432214b5
Fixed: 365321156
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5844683
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2024-09-09 19:16:13 +00:00
Helmut Januschka
eb0cb70185 Avoid silently overwriting diff.ignoreSubmodules config. 
Setting this to `dirty` is generally desirable. If the user has
explicitly set it to something else on their chromium checkout,
warn rather than silently overwriting.

Rev^2: https://crrev.com/c/5832742

Change-Id: I8392c7976af0a1f8754a630bd865830ba6698051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5836831
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
 2024-09-09 17:11:52 +00:00
recipe-roller
ab2fe54f4d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8737260733446787281

recipe_engine:
83f6ab08d4
  83f6ab0 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from ec627773ecc5 to 1aca70b6bf11

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia19ed187b8eb1019017bfe0365a0ece032c49c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5845997
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-09 15:39:14 +00:00
Chenlin Fan
ae3745656b gclient: fix gclient sync with revision ref 
Check /refs/heads/ strictly as branch revision type. Any ref (e.g. /refs/changes/*) not a branch has no difference from a hash.

Bug:341208163
Change-Id: I23e8c577b099adb88917527f827da3b122997cb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5835142
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-09-09 05:14:45 +00:00
Dan Le Febvre
ab105459cb Revert "Avoid silently overwriting diff.ignoreSubmodules config." 
This reverts commit acd68a9a5d.

Reason for revert: Doesn't get values for non scoped config.

Original change's description:
> Avoid silently overwriting diff.ignoreSubmodules config.
>
> Setting this to `dirty` is generally desirable. If the user has
> explicitly set it to something else on their chromium checkout,
> warn rather than silently overwriting.
>
> Bug: 362787698
> Change-Id: I56587d501aafc5de78c82bc46e29f926519d25fa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5832742
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Commit-Queue: Helmut Januschka <helmut@januschka.com>

Bug: 362787698
Change-Id: I3e5d1e44e3707dda53dc398f83c43259868d343b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5842067
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Joey Scarr <jsca@google.com>
Owners-Override: Joey Scarr <jsca@google.com>
Commit-Queue: Dan Le Febvre <dlf@google.com>
 2024-09-09 01:46:14 +00:00
Helmut Januschka
acd68a9a5d Avoid silently overwriting diff.ignoreSubmodules config. 
Setting this to `dirty` is generally desirable. If the user has
explicitly set it to something else on their chromium checkout,
warn rather than silently overwriting.

Bug: 362787698
Change-Id: I56587d501aafc5de78c82bc46e29f926519d25fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5832742
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
 2024-09-06 20:39:50 +00:00
Junji Watanabe
28edf94b2b build_telemetry: Set timeout to 'cipd auth-info' command. 
When it's offline or the internet connection is unstable,
build_telemetry.enabled() may fail, which end up with
blocking autoninja command.

Bug: 364611323
Change-Id: Ie0d26e7b950e29af1392e452a0cd7e986494cdcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5842066
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Philipp Wollermann <philwo@google.com>
 2024-09-06 11:01:14 +00:00
Junji Watanabe
4250face7b ninjalog_uploader: Collect all GN args except sensitive information 
Bug: 364971744
Fixed: 364971744
Change-Id: Ia09ba43f3cd12638923b3add458f2f32f9a03860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5836322
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 2024-09-06 08:09:07 +00:00
Gavin Mak
43691064b4 Remove commits-to-cherry-pick only after a cherry-pick is created 
If `git cl cherry-pick` fails to cherry-pick a CL, it should print
out the commit it failed to cherry-pick. Right now, that commit
is missing from the "print_any_remaining_commits" output
since commits get popped from the dict regardless of whether or
not a CL is created.

Bug: 364375259
Change-Id: Iac61f50b8f8f226b9e70bc2d0fa235f39c27d91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5829953
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2024-09-05 23:56:06 +00:00
Arthur Eubanks
5eca5541e8 [git-cl] Only ignore deleted files for formatting purposes 
Multiple people have complained that we should format files when changing class names. That seems better than not formatting moved/copied files (you can always format a file separately before moving it to workaround the issue of moving unformatted files and presubmit complaining).

This CL essentially reverts https://crrev.com/c/4904205, meaning we will again run clang-format on files that were copied/moved.

https://crrev.com/c/5199134 is probably the proper fix by only looking at lines that were actually changed, but does not yet work with non-C++ formatters.

Checked locally that previously we wouldn't format a moved file, and with this change we now do.

Bug: 737568
Change-Id: Ie12c802316d5e293f2946c532e1600c342caaf59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5840596
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2024-09-05 22:55:26 +00:00
Peter Kasting
9bbf9b0541 Set blame.ignoreRevsFile to .git-blame-ignore-revs. 
This basically brings the functionality of git hyper-blame to git blame
by default and is supported since git 2.23.

Bug: none
Change-Id: I2023669deac999ef31d0e094e79d7214168acb63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5838110
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2024-09-05 16:31:34 +00:00
Gavin Mak
9e91079582 Use the cherry picked CL's Change-Id 
If a CL and its cherry pick share a change ID, Gerrit will link to each
other in the UI.

Bug: 364692466
Change-Id: I6740ddfd813124d5876b29b05c4b8f91822faa57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5838865
Auto-Submit: Gavin Mak <gavinmak@google.com>
Reviewed-by: Matt Jones <mdjones@google.com>
Commit-Queue: Matt Jones <mdjones@google.com>
 2024-09-05 14:06:26 +00:00
recipe-roller
62fc3a1d24 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8737669678790717841

recipe_engine:
3381d1b415
  3381d1b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 0faa087a5890 to 1d383421736c

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7aa6a227909d20a3a77382d32c5fa1434b8dc4b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5837671
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-05 03:22:16 +00:00
Allen Li
3a7d070966 [gerrit_utils] Add caching to ShouldUseSSO 
This only lasts per process invocation, so we don't worry about cache
size (and it's a minor performance save).

Bug: b/350806563
Change-Id: Ie8e1aa2933c5582a3a2e2f75f04590f6bb432c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5833280
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-09-04 21:19:43 +00:00
Allen Li
dc8d502d13 [gerrit_util] Don't try to use SSO on non-googlesource hosts 
In case you're getting funny thoughts, these requests would not attach
any cookies anyway because the domain doesn't match.  It just allows
requests to properly fallback to OAuth path.

Bug: b/362741558
Change-Id: Iaf83ad640501ff45671dbc358e676cbeaf04d686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5824222
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2024-09-04 21:18:53 +00:00
recipe-roller
b89b440351 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8737949645716858529

recipe_engine:
d8675d4c62
  d8675d4 (dlf@google.com)
      fix peeps sec owners

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2552ab779a1daac6ba5ae9465ab658a97ee47f30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5831525
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-02 01:08:43 +00:00
recipe-roller
829de93b77 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8737956569395364897

recipe_engine:
2fcca0ed01
  2fcca0e (dlf@google.com)
      [ssci] allow multiple subject hashes for sbom reporting

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie864127a6a8cdd47ca7d3cb323479caac3e3f4fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5831252
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-09-01 23:20:10 +00:00
Gavin Mak
2836a02f55 Make "git cl cherry-pick" handle failed cherry picks better 
"Better" means:
1. Retrying a failed gerrit_util.CherryPick only once instead
   of 5 times for faster feedback since more retries don't help.
2. Gracefully handling GerritErrors raised by gerrit_util.CherryPick

This CL also fixes a minor bug where the "Remaining commit(s) to
cherry pick" message would always print even if there were no more
commits left.

Bug: 341792235
Change-Id: I1712a6b080b14396463f3bceeeac84772f1253b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5825626
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2024-08-30 15:35:36 +00:00
Robert Iannucci
b46b033bd7 [git-cl] Make quick Gerrit RPC at the top of CMDupload. 
This prevents the following scenario:

$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # requires thinking
CRASH!! You need to authenticate!!
$ <authenticate>
$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # opens new, fresh, editor :(

Now it will do:

$ git cl upload ...
CRASH!! You need to authenticate!!
$ <authenticate>
$ git cl upload ...
<runs `git status`>  # slow operation
<runs `git cl presubmit`>  # slow operation
<runs $EDITOR /commit/message> # requires thinking

R=ayatane, sokcevic@google.com

Change-Id: Icada2b69b3f4ddaff810dc82d54d65f3918d1434
Bug: 351071334
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5826970
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
 2024-08-30 01:20:40 +00:00
recipe-roller
7004c799c7 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8738222068835851505

recipe_engine:
64ac83a80a
  64ac83a (iannucci@chromium.org)
      Switch execution details step to be a debug log.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibf927e51255a9e5b10bb2c4e44bd597b420e685f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5828008
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2024-08-30 01:02:53 +00:00
Junji Watanabe
4a08b97dd4 ninjalog_uploader: Add user email to ninjalog metadata 
Bug: 348527311
Change-Id: Idb623a57a2374f4ed5461a9cf159b2eda62c94f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5823448
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2024-08-29 11:17:57 +00:00
nqmtuan
22f6c9d8e9 Deploy Lucicfg to 1fdeb2c6cc9a65c02570616b8619699cef40d07c 
Include change 1fdeb2c6cc

Change-Id: Ie217055e6ed5499527b18131f1d569fb324cb134
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5823022
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Tuan Nguyen <nqmtuan@google.com>
 2024-08-29 00:58:01 +00:00
Gregory NISBET
ae2bc61bf0 Make update_depot_tools tell you if it's skipping an update. 
I set DEPOT_TOOLS_UPDATE to 0 because I sometimes contribute to
depot_tools (and because I was negatively impacted a few times in the
past by a depot tools update in ways that I can't recall.)

Anyway, if you set the DEPOT_TOOLS_UPDATE variable to 0, then even
explicitly doing `update_depot_tools` from the command line will not
actually do an update, you need to set the environment variable to a
different value before attempting an update.

This script is so old that its behavior probably shouldn't be changed.
But we can tell the user what update_depot_tools is doing and why, and
how to get it to do a real update.

Change-Id: I67458e78b5e64f8ea75ffad73b2ede0955c4d91f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5824829
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>
 2024-08-28 19:47:07 +00:00
Gavin Mak
aaaca2863c Make git cl cherry-pick use a unique change ID 
If a commit's Change-Id identifies more than one change, git cl
cherry-pick will get an error when trying to rebase the cherrypick:
"Multiple changes found for <change-id>"

Make sure the command only uses a CL's unique ID.

Bug: b/362514041
Change-Id: Ia84053fc8a49eadfc0f1e732929fb58e507a6bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5818412
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2024-08-28 16:18:18 +00:00