InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
8,126 Commits 6 Branches 0 Tags
39120911526720e9256b724b1f44513bab3cb533
Commit Graph

18 Commits

Author SHA1 Message Date
Takuto Ikuta
4bb3a7d00d ninjalog_uploader: ignore http.client.RemoteDisconnected 
Bug: b/190562569
Change-Id: Iaa8d119ad643e64bdf231fe5ae43ea4daa69996f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2947272
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2021-06-09 03:58:27 +00:00
Takuto Ikuta
84e43fa2c4 ninjalog uploader: migrate to python3 
This removes dependency to httplib2 by using urllib.
https://docs.python.org/3/library/http.client.html#httpresponse-objects

Use six for both py2/py3 unittest.

Bug: b/177465438
Change-Id: I48383559842615f97abea45b55ca0acf4d7c8bd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2629087
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2021-01-19 02:51:50 +00:00
Takuto Ikuta
c603339365 autoninja: use pure python for ninjalog_uploader_wrapper.py 
I'll update to python3 separately.

Bug: b/177465438
Change-Id: Id204789f2d0854a796e5408597700d90dc8cd191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2626863
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2021-01-14 08:57:35 +00:00
Gavin Mak
e6a623392d [depot_tools] Use logging.warning 
logging.warn is deprecated and should be replaced with logging.warning.

Bug:1097402
Change-Id: I55ce007bec47608eeafcf3cd9ac2b90f60073115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575621
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2020-12-04 21:57:10 +00:00
Bruce Dawson
9e633036da Fix reference to enable_js_type_check 
A TODO in ninjalog_uploader.py referred to the closure_compile gn arg
which was recently renamed (as of crrev.com/c/2248564) to
enable_js_type_check. This updates it (and adds a missing space and a
bug number). This is purely a comment fix.

Change-Id: I117fa7910663491fd7c6e017fe98e2a977a75f13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2336176
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2020-08-04 21:50:29 +00:00
Takuto Ikuta
6c7b829e54 remove reference to jumbo build 
Bug: 994387
Change-Id: I0c675bb6aca04d64593de420c7936cb88ff6a051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2334503
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2020-08-03 17:47:51 +00:00
Takuto Ikuta
a2e91dbb61 apply yapf for ninjalog*.py 
This is preparation to fix the issue.

Bug: 992282
Change-Id: I64b237670bf460ff765df3eaf069b0e0bdcfb31d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2237268
Commit-Queue: Ye Kuang <yekuang@google.com>
Reviewed-by: Ye Kuang <yekuang@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2020-06-09 11:21:59 +00:00
Edward Lemur
59a3b2fd5d Run autoninja scripts using vpython. 
Bug: 1002153
Change-Id: I769a5370d726f4ce478035f59bfd1df50fef452e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1992315
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2020-01-14 01:50:50 +00:00
Edward Lesmes
1961043388 Revert "Move httplib2 import above third_party." 
This reverts commit cd1331ea69.

Reason for revert:
Original CL was reverted.

Original change's description:
> Move httplib2 import above third_party.
> 
> 7fd6347be3 removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest.
> 
> move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix.
> 
> Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Mark Orchard <morchard@google.com>

TBR=ehmaldonado@webrtc.org,ehmaldonado@chromium.org,morchard@google.com,apolito@google.com

Change-Id: Ic7775cdb4abae1855358711335349fc39eb37dfb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988739
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 2020-01-07 03:30:49 +00:00
Mark Orchard
cd1331ea69 Move httplib2 import above third_party. 
7fd6347be3 removed the third_party/httplib2 files, but left the pyc files. This is breaking CQ for nest.

move httplib2 import above adding third_party to the path in ninjalog_uploader_wrapper to fix.

Change-Id: Id28f68ce7e3eb94783bdd5ee7ce15ae5930fde7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1988690
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mark Orchard <morchard@google.com>
 2020-01-07 01:48:07 +00:00
Quinten Yearsley
3841eaa164 Remove unused imports in depot_tools/*.py 
I know that sometimes imports can have side-effects,
so unused imports shouldn't always be removed, but these
ones look like they could be.

Change-Id: Iea9f82afa99b0ea35f29a28f20ce0493b579cfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819860
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
 2019-09-23 21:07:07 +00:00
Takuto Ikuta
5c00a22f22 [ninjalog_uploader] add path for httplib2 
This is to let httplib2 import its sock.py in __init__.py correctly.
This is pointed out in
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/8BF_cywS9JY/8g-HHmuqEQAJ

Also removed an unnecessary httplib2 import.

Change-Id: Iad0377ad282acd9e1e222890f522e4e62086dcaf
Reviewed-on: https://chromium-review.googlesource.com/c/1475255
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2019-02-18 04:32:51 +00:00
Takuto Ikuta
36248fcd63 [ninjalog] don't upload ninja log of no-op build 
Check timestamp of .ninja_log before upload and don't upload if mtime is very old.

Bug: 900161
Change-Id: I0cf00ae29e23a9f609564e4c12b4b518320ca23a
Reviewed-on: https://chromium-review.googlesource.com/c/1404611
Commit-Queue: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2019-01-11 03:02:32 +00:00
Takuto Ikuta
c8069af594 [ninjalog] fully anonymize build stats before sending 
We cannot send PII data.

This CL tried to remove following data,
* build config that can contain build directory path
* build directory path
* hostname
* cwd

I use per build uuid instead of per user uuid.


Bug: 900161
Change-Id: Id533762749806ad8616b7dc07f21b27dfe632c9a
Reviewed-on: https://chromium-review.googlesource.com/c/1369473
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2019-01-09 06:24:56 +00:00
Takuto Ikuta
cf56a4bfb0 [ninjalog_uploader] Add BuildTargetFromCommandLine function 
This function extracts build target from command line.

Bug: 900161
Change-Id: I38d37689a42437de76933ea3c9afb9def5a1253c
Reviewed-on: https://chromium-review.googlesource.com/c/1381911
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
 2018-12-18 05:47:26 +00:00
Takuto Ikuta
61cb9d6ba7 [ninjalog_uploader] add tests 
Use unittest module instead of doctest.

Bug: 900161
Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3
Reviewed-on: https://chromium-review.googlesource.com/c/1379441
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
 2018-12-17 23:45:49 +00:00
Takuto Ikuta
96fdf7cbe6 [ninja] collect build configs 
This is to know what build configs are popular among chromium developer.

Bug: 900161
Change-Id: Id07722e70fc407b3f8668080d49033da6e1a7f34
Reviewed-on: https://chromium-review.googlesource.com/c/1358034
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
 2018-12-03 09:18:39 +00:00
Takuto Ikuta
9af233a508 introduce ninjalog_uploader to autoninja 
This CL introduces ninjalog_uploader to autoninja for posix environment.
This is to collect build statistics from googler to find user side build performance bottleneck.

ninjalog_uploader_wrapper is used to notify user and manage small config of upload script.

Bug: 900161
Change-Id: I48ac8cd1d52f64e8fdafaec43636d2d79ef9040d
Reviewed-on: https://chromium-review.googlesource.com/c/1345255
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2018-11-29 03:53:53 +00:00