InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ninjalog_uploader] add tests

Browse Source 
Use unittest module instead of doctest.

Bug: 900161
Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3
Reviewed-on: https://chromium-review.googlesource.com/c/1379441
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
This commit is contained in:
Takuto Ikuta
2018-12-17 23:45:49 +00:00
committed by Commit Bot
parent fb8c1a203d
commit 61cb9d6ba7
3 changed files with 71 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
ninjalog_uploader.py
View File

@@ -39,16 +39,7 @@ def IsGoogler(server):
return False
def ParseGNArgs(gn_args):
"""Parse gn_args as json and return config dictionary.
>>> ParseGNArgs("[]")
{}
>>> ParseGNArgs('[{\
"current": {"value": "true"}, \
"default": {"value": "false"}, \
"name": "is_component_build"}]')
{u'is_component_build': u'true'}
"""
"""Parse gn_args as json and return config dictionary."""
configs = json.loads(gn_args)
build_configs = {}
for config in configs:
@@ -92,19 +83,7 @@ def GetMetadata(cmdline, ninjalog):
return metadata
def GetNinjalog(cmdline):
"""GetNinjalog returns the path to ninjalog from cmdline.
>>> GetNinjalog(['ninja'])
'./.ninja_log'
>>> GetNinjalog(['ninja', '-C', 'out/Release'])
'out/Release/.ninja_log'
>>> GetNinjalog(['ninja', '-Cout/Release'])
'out/Release/.ninja_log'
>>> GetNinjalog(['ninja', '-C'])
'./.ninja_log'
>>> GetNinjalog(['ninja', '-C', 'out/Release', '-C', 'out/Debug'])
'out/Debug/.ninja_log'
"""
"""GetNinjalog returns the path to ninjalog from cmdline."""
# ninjalog is in current working directory by default.
ninjalog_dir = '.'