InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,752 Commits 6 Branches 0 Tags
276ae56a8e9c39f521ed617f0c11c05969d7bb1f
Commit Graph

11752 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jiewei Qian
276ae56a8e auth: add pinentry support fido2 plugin 
This CL adds pinentry support to ask for security key PIN.

Security key PINs may be required (by the manufacturer, or configured by
the user) to perform FIDO2 assertions.

PIN entry is done by calling pinentry command (or overridden by
LUCI_AUTH_PINENTRY environment variable), which we'll ask users to
install during onboarding.

Bug: 448235795
Change-Id: Ie87389330668dc5eaf8214699defec094757ca9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7004844
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
 2025-10-06 21:06:49 -07:00
recipe-roller
eda3b48f2e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8701990832612218721

recipe_engine:
2cbdab1507
  2cbdab1 (iannucci@chromium.org)
      Require explicit API/TEST_API exports.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1bdf243baa8492c2817d68bc95835312d4477d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7008972
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-10-03 15:58:28 -07:00
Jordan
e4185d003f Add dtoa license 
LICENSE is in use in webrtc for fft:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/modules/third_party/fft/LICENSE

go/lican shows it as dtoa, which is a 'notice' license.

It is also a valid spdx id https://spdx.org/licenses/dtoa

Change-Id: Id617e50068892b10e42433b525b74712698e113c
Bug: 421989416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7005870
Auto-Submit: Jordan Brown <rop@google.com>
Reviewed-by: Anne Redulla <aredulla@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
 2025-10-02 21:47:03 -07:00
recipe-roller
c1301a6574 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8702080171155576865

recipe_engine:
592b09d2c9
  592b09d (mohrr@google.com)
      [path] Have expanduser/expandvars return strs

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I46a5dcd76de018a11761c663acd1b4e61c055592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7006475
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-10-02 16:23:46 -07:00
recipe-roller
9fd9d31f94 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8702101561312627201

recipe_engine:
f7f5eec6d1
  f7f5eec (iannucci@chromium.org)
      [ide] Generate path directory with all protos and modules.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic9d6584b5418322ee2e72fe781252e6e7e10b77e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7006470
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-10-02 10:43:36 -07:00
recipe-roller
010d64273b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8702104700070838081

recipe_engine:
01968a1a84
  01968a1 (iannucci@chromium.org)
      [protobuf] Update to latest protobuf and protoc.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id550ad76599a073ccf13cb12d77a16acb94d0a5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7006616
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-10-02 09:51:55 -07:00
Jordan
3f15de2ac3 Add Update Mechanism: Autoroll.GoogleManaged 
Forked open-source projects stored in internal Google repos, which then
get pulled into ios_internal.

They have an external upstream, but we use the Google managed fork for
ios_internal

Change-Id: Ib2cd05414f31fd7e44f1222620880c2edbaac7e8
Bug: 448767146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7005823
Commit-Queue: Jordan Brown <rop@google.com>
Auto-Submit: Jordan Brown <rop@google.com>
Reviewed-by: Jiewei Qian <qjw@chromium.org>
 2025-10-01 21:52:54 -07:00
Junji Watanabe
6cac3e72ab ninjalog_uploader: Support new siso_metadata.json filename 
This follows up the filename change done by https://crrev.com/c/6998852.

Change-Id: Id3ca467aac2fd33296e646b948787bf19ab61717
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6999092
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2025-09-30 21:16:18 -07:00
Jordan Brown
49ffe22ecd Add a warning for insufficient metadata for vulnerability scanning. 
This change introduces a `ValidationWarning` when a dependency lacks
sufficient metadata for vulnerability scanning. The warning asks
developers to provide one of the following combinations:
- 'CPEPrefix' with a version.
- A git clonable 'URL' and a 'Revision'.
- A git clonable 'URL' and a 'Version' matching the git tag.
- A package manager 'URL' and a 'Version'.

To reduce noise, this initial change is limited to dependencies that
meet the following criteria:
* Shipped; and
* Security Critical; and
* Do not provide 'Update Mechanism'

It is expected to affect about a dozen dependencies.

This change also updates some tests to be more specific to their test
cases so they don't fail for unrelated changes (like this one).

Bug: 438384123
Bug: 448003595
Change-Id: Ib1c562230b530a183e882efb1b23238b0ce0587c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6999547
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Rachael Newitt <renewitt@google.com>
Auto-Submit: Jordan Brown <rop@google.com>
 2025-09-30 16:23:58 -07:00
recipe-roller
7ec31c2e66 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8702290304193240529

recipe_engine:
cd144bceae
  cd144bc (mohrr@google.com)
      [path] Add expandvars()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I08e1e2e22c8837ce67241a06a2332f2bc1f55d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7000907
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-30 08:38:51 -07:00
Jordan Brown
675a3a9ccd Add Maven as identifiable package manager 
These are the same identifiers used to identify Maven repositories in
internal scanners.
Bug: 438383466, 446990546
Change-Id: Ic00be8f96d28a63efaa09352007adb39a0328bae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6976602
Commit-Queue: Jordan Brown <rop@google.com>
Reviewed-by: Rachael Newitt <renewitt@google.com>
 2025-09-28 23:14:23 -07:00
Jiewei Qian
73e46667ed Reland "git-cl: make SetReview ReAuth capable" 
This is a reland of commit 6da6aecbb4

There's no change from the original CL and this reland. The revert was
addressed by adding ReAuth support to machine / bot authenticators,
namely GceAuthenticator (https://crrev.com/c/6965527) and
LuciContextAuthenticator (https://crrev.com/c/6967915).

The above changes should stop gerrit_util.SetReview from raising ReAuthRequired errors.

Bug: 442666611

Original change's description:
> git-cl: make SetReview ReAuth capable
>
> This CL changes SetReview to be ReAuth capable.
>
> This is a potential breaking change if an downstream script relies on
> gerrit_util.SetReview but hasn't implemented ReAuth.
>
> If this caused breakage, please refer to https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/gerrit_reauth.md#Troubleshooting for troubleshooting instructions.
>
> If the above doesn't work, please report a bug, then add `LUCI_BYPASS_REAUTH=1` to the environment to disable ReAuth for now.
>
> Bug: 442666611
> Change-Id: I7724f15f166f9975fc88be5d8e1c93be4e1ec302
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939308
> Reviewed-by: Allen Li <ayatane@chromium.org>
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Commit-Queue: Jiewei Qian <qjw@chromium.org>

Bug: 442666611
Change-Id: I53636e54c732ec399b053500d664097ebacca05e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6967916
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2025-09-24 20:59:02 -07:00
Allen Li
1c23880345 git_auth: Delete Configure functions 
Has been unused for a while, remove it now

Bug: 446999231
Change-Id: I54bcac7effe0c97d8ec3daa833338a8301a4b1fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6981221
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-09-24 17:42:51 -07:00
Jiewei Qian
e028bec84c reauth: add LuciContextAuthenticator support 
This CL implements attempt_authenticate_with_reauth in LuciContextAuthenticator according to the base _Authenticator's
interface definition.

This allows LuciContextAuthenticator to be used where an action that needs to meet ReAuth requirement (instead of raising an exception
saying "ReAuth
is required").

Luci context access tokens should already satisfy ReAuth requirement.

Bug: 442666611
Change-Id: I2e4d43a75b230932fc779c805f75b5828c9d0980
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6967915
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2025-09-24 16:45:20 -07:00
Robert Iannucci
b723b89856 Switch to single-line API/TEST_API definitions. 
R=mohrr@google.com

Bug: b/446916327
Change-Id: I4fc651325566ffe67956750e35363a6718d9a15b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6981222
Reviewed-by: Rob Mohr <mohrr@google.com>
Commit-Queue: Robbie Iannucci <iannucci@google.com>
 2025-09-24 16:36:06 -07:00
Jiewei Qian
dfd4523a42 reauth: add GceAuthenticator support 
This CL implements attempt_authenticate_with_reauth in GceAuthenticator
according to the base _Authenticator's interface definition.

This allows GceAuthenticator to be used where an action that needs to
meet ReAuth requirement (instead of raising an exception saying "ReAuth
is required").

GceAuthenticator's credential already satisfies ReAuth requirement.
ReAuth is satisfied if the GCE bot is trusted (controlled by Gerrit
server side config).

Bug:442666611
Change-Id: I9a801e3fd6ab9fb446e7842a93bcd9ee1ff953c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6965527
Reviewed-by: Allen Li <ayatane@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2025-09-24 16:31:36 -07:00
Allen Li
06da8b2a8f git_cl: Delete usages of AutoConfigure 
Has been no-op for a while, remove it now

Bug: 446999231
Change-Id: I9f4e5b9cbd6a5cb8e84fba2f0ebb949b2a88d9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6981220
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
 2025-09-24 16:06:55 -07:00
recipe-roller
a115a3973b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8702808721279143809

recipe_engine:
7c52a644fb
  7c52a64 (iannucci@chromium.org)
      Switch to single-line API/TEST_API definitions.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9cdd01b9915966ebe9d4521996572773cea4c90d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6981316
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-24 15:20:06 -07:00
Rob Mohr
a3fa818db8 recipes: Add API and TEST_API variables 
These will eventually be required.

Change-Id: If7be1c111c6f9760c38aa512dfa88260379a751f
Bug: b/446916327
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6976649
Reviewed-by: Robbie Iannucci <iannucci@google.com>
Commit-Queue: Rob Mohr <mohrr@google.com>
 2025-09-24 09:09:35 -07:00
Allen Li
838e4c6aa7 [git_cl] Remove the auto cleanup from disabled new auth 
This is in preparation for removing the old auto config code.  New
auth has been rolled out stably for a long time now, and in any case
the auto config/cleanup code isn't super reliable (hence why we're
removing it).

We remove this final callsite before deleting all of the relevant
code, and leave a message of assistance in case anyone needs it.

Bug: 446999231
Change-Id: Ia13e5d75a89a4ddfb178ee9e4fe2090596493218
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6976601
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-09-23 19:52:53 -07:00
Rachael Newitt
813b6f7588 Delete the README.chromium from depot_tools/repo. 
This is not a third party dependency and should not be
tracked as part of third party inventory.

Bug: 422059297
Change-Id: Iaf1801d2af376cb58e3b4d2f1d8ed746aa01f500
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6964657
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Rachael Newitt <renewitt@google.com>
 2025-09-23 17:04:26 -07:00
Riley
6be1145103 [lucicfg] Update v1.45.8 -> v1.45.9 
Most notable change is adding gardened only filter for builder health
notifiers.

Bug: 407539622
Change-Id: Ied811bcc25f9ff3ea8dba69aaed4b046ab40db92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6974850
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 2025-09-23 09:53:06 -07:00
recipe-roller
6c58dbde8a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8702928887524525793

recipe_engine:
caad8510cc
  caad851 (mohrr@google.com)
      Add 'API' and 'TEST_API' to '__init__.py'

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I957f90389d952c01b39e7e19b284de0c8f51e4a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6976475
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-23 07:31:27 -07:00
Jiewei Qian
9b361d9c09 git-cl: catch "ReAuth is required" error and re-raise is properly 
This CL updates _RunGitPushWithTraces to detect git credential-luci
"ReAuth is required" error and propagate it nicely to the caller.

Previously, the error is uncaught, and re-raised with nested exception
stacktrace. The result was an unhelpful traceback, where the true error
is at the top (part of git push stdout/stderr).

This CL now propagate the error with a clear GitPushError printed last
(which hopefully gets developer's attention).

Fixed: 445532843
Change-Id: I789a6902b59af2c9df92fc7d013829afc4154dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6954695
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
Auto-Submit: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2025-09-22 15:06:26 -07:00
Jordan
8ab2a5350f Add 'Update Mechanism: Manual' to README.chromium files 
R=ddoman@chromium.org

Bug: 445311061
Change-Id: Ic721217470317ed35e1506d7e79f13b5d2fb73f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6953483
Auto-Submit: Jordan Brown <rop@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2025-09-18 09:56:34 -07:00
recipe-roller
0d761e6db8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8703433460769875761

recipe_engine:
07e4e55ddf
  07e4e55 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8542fcedab33 to 6645da847edf

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I95e6803140638c18af69016e9a4177cad245d099
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6963197
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-17 17:55:06 -07:00
Steven Holte
a5397c7459 Refactor: Use f-strings for string formatting 
Change-Id: I369fb3af4395b28ca840c9b9d4a5a5e0497da51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6945150
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
 2025-09-17 15:56:03 -07:00
Andrew Grieve
9d57bd01e8 git cl comments: Add --unresolved & improve --json-file 
* Don't output to non-json format when --json-file is passed
* Format individual comments as JSON when --json-file is used
* Add "unresolved" field to comments
* --unresolved flag will show only unresolved comments
* Better error message when no issue is associated with the branch

I intend to use this to have gemini-cli fix comments:
https://chromium-review.googlesource.com/c/chromium/src/+/6944524

Change-Id: I3b4d594b065751a600661a89925c69ffbf22aed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6944465
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
 2025-09-17 11:28:23 -07:00
Jacek Dobrowolski
c932af8f97 Revert "git-cl: make SetReview ReAuth capable" 
This reverts commit 6da6aecbb4.

Reason for revert: Breaks official chrome release.

Original change's description:
> git-cl: make SetReview ReAuth capable
>
> This CL changes SetReview to be ReAuth capable.
>
> This is a potential breaking change if an downstream script relies on
> gerrit_util.SetReview but hasn't implemented ReAuth.
>
> If this caused breakage, please refer to https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/gerrit_reauth.md#Troubleshooting for troubleshooting instructions.
>
> If the above doesn't work, please report a bug, then add `LUCI_BYPASS_REAUTH=1` to the environment to disable ReAuth for now.
>
> Bug: 442666611
> Change-Id: I7724f15f166f9975fc88be5d8e1c93be4e1ec302
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939308
> Reviewed-by: Allen Li <ayatane@chromium.org>
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Commit-Queue: Jiewei Qian <qjw@chromium.org>

Bug: 442666611
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7b7e769b5a8011d45e976e471d0f2e43f186e0c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6955930
Commit-Queue: Alex Kravchuk <alexanderkr@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Ben Mason <benmason@chromium.org>
 2025-09-17 03:52:50 -07:00
Jiewei Qian
6da6aecbb4 git-cl: make SetReview ReAuth capable 
This CL changes SetReview to be ReAuth capable.

This is a potential breaking change if an downstream script relies on
gerrit_util.SetReview but hasn't implemented ReAuth.

If this caused breakage, please refer to https://chromium.googlesource.com/chromium/src.git/+/HEAD/docs/gerrit_reauth.md#Troubleshooting for troubleshooting instructions.

If the above doesn't work, please report a bug, then add `LUCI_BYPASS_REAUTH=1` to the environment to disable ReAuth for now.

Bug: 442666611
Change-Id: I7724f15f166f9975fc88be5d8e1c93be4e1ec302
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939308
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
 2025-09-16 17:00:01 -07:00
Jiewei Qian
b6ec488e5e Roll git-credential-luci to support ReAuth on webrtc host 
Bug: 443140587
Change-Id: I5f4ff4b9ed3e7841fca8314cc18fb6d5e7f04a5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6952195
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
 2025-09-16 16:50:21 -07:00
Scott Lee
927f7dad38 presubmit: use git diff -U0 for CheckPatchFormatted() 
git cl format uses `git diff -U0` when it has to find the files
and ranges to format. Similarly, CiderG generates diffs with
-U0 and run presubmits for the checks.

However, the scm.py:GenerateDiff(), which CheckPatchFormatted() uses,
doesn't specify -U and it defaults to -U3.

This CL updates CheckPatchFormatted() to pass -U0 to
scm.py:GenerateDiff() so that Presubmit and git cl format are
always given diffs generated with -U0.

Bug: 386840832
Change-Id: I19479ab139b7dba8ba4e5e5fed89eca4d2e66412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6952890
Auto-Submit: Scott Lee <ddoman@chromium.org>
Commit-Queue: Brian Ryner <bryner@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2025-09-16 09:50:19 -07:00
Jiewei Qian
9d7425377e reauth: add reauth capabilities to HttpConn 
This CL makes it possible to create HttpConn RPC calls with ReAuth
credential.

Callers can specify whether they want to fail when ReAuth token isn't
available, or fallback to access token.

Bug: 442666611
Change-Id: I748a01634eea8ebe321779c8ae4f52d7beed3407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6938952
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
 2025-09-16 00:32:10 -07:00
Jiewei Qian
024aacb38b auth.py: add ReAuth support 
This CL adds ReAuth support to GerritAuthenticator. ReAuth token can be
obtained with a new get_authorization_header() call.

The task of obtaining such a token is delegated to different
authenticators to check if ReAuth is necessary, and if the existing
authentication token already satisfies ReAuth requirements.

Bug: 442666611
Change-Id: Ic661b868f1c61c653de0da43eb784ad5938342f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6914237
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
 2025-09-16 00:15:47 -07:00
Scott Lee
35982166cc Reland "presubmit: update CheckPatchFormatted to pass --input_diff_file" 
This reverts commit 3accee0833.

Reason for revert: Fixes have been made
- crrev.com/c/6939737
- crrev.com/c/6943433

Original change's description:
> Revert "presubmit: update CheckPatchFormatted to pass --input_diff_file"
>
> This reverts commit 4689d66abf.
>
> Reason for revert: causing issues in b/386840832
>
> Original change's description:
> > presubmit: update CheckPatchFormatted to pass --input_diff_file
> >
> > Once devs update depot_tools, this will take effect in both
> > terminal and CiderG
> >
> > TESTED: http://go/scrcast/NjM1MzE5NDc4NjQ4ODMyMHxmMzc3NGVlZi03Yg
> > Bug: 386840832
> > Change-Id: Ibb8f74bffd662eb330f61b9e82bcd75c09bbc232
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6937365
> > Commit-Queue: Scott Lee <ddoman@chromium.org>
> > Reviewed-by: Gavin Mak <gavinmak@google.com>
>
> Bug: 386840832
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I0bb79952aab4e0fa29607c79ea14f13f2a2a7bb3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939736
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Scott Lee <ddoman@chromium.org>

Bug: 386840832
Change-Id: I699e87ab7c2543b835a0cb94062ee2225b88af28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6944257
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2025-09-15 07:26:12 -07:00
recipe-roller
150db33178 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8703898401963231233

recipe_engine:
af73739e9b
  af73739 (mark@chromium.org)
      Revert "Add cert pinning to `url` recipe_module"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9c93144733e930bc5c6842fb5bf88294fa93874c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6944568
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-12 14:38:25 -07:00
Scott Lee
077e02a769 presubmit: generate a diff with prefix a/ and b/ 
Historically, git_cl.py and presubmit_support.py generated diffs
inconsistently.

==== git_cl.py ====
1) git_cl.py:_RunClangFormatDiff() assumed the input diff was
generated with --no-prefix. Therefore, it hard-coded -p0 as a param
for clang_format_diff.py. If the diff was generated without --no-prefix,
it would have to pass -p1 instead.

2) git_cl.py _RunYapf() and _RunGoogleJavaFormat assumed that
the input diff was generated with prefixes. Therefore,
it parsed the diffs, assuming that the diff was generated with
a/ and b/ prefixes.

This discrepancy wasn't an issue because each of the Run functions
generated and consumed the diffs within themselves. It became an issue
when https://crrev.com/c/6931775 was developed. The CL consolidated
the diff generation into a common function, so that all _Run functions
need to agree with the presence of the prefixes.

The CL changed _RunClangFormatDiff() to use -p1 instead of -p0,
mainly because
- it's the p level for the default git-diff option
- it's the p level for the unix diff util
- CiderG Chromium also generates the diff with the prefixes to
emulate the default diff output.
- I highly believe that --no-prefix was chosen for no reasons.
It seems to be a random choice to work with -p0.
- Either Java/Python or Clang wrapper should be changed.

==== presubmit_support.py ====

presubmit_support.py can be given a diff_file via --diff_file.
Otherwise, it generates the diff based on --upstream_commit.

a) it doesn't enforce the presence of the prefixes in the input
diff_file. As stated above, the Chromium extension generates
a diff with prefixes.

b) in contrast, when it is not given --diff_file, it generates
the diff with --no-prefix, and I don't find any reasons for it.
I believe that it's from a copy-pasted random choice.

==== the problem ====

This discarepancy became a problem, when crrev.com/c/6937365
was landed. It enforces git_cl.py and presubmit_support.py to agree
for the format of the input diff. That is, the presence of
the prefixes must be agreed by all the following.
- presubmit_support.py with --diff_file /tmp/abc
- presubmit_suppory.py without --diff_file /tmp/abc
- git cl format
- git cl format --input_diff_file /tmp/abc

==== possible solutions ====
Obviously, there are 3 choices.

1) update the regex and parsers of git_cl.py to auto detect the best
-p{num}.
This was the least preferred option, as it can be fragile.

2) update Chromium extension and git_cl.py to use --no-prefix.
i.e.,
- update the Chromium CiderG to generate diffs without the prefix.
- update the regex used in _ComputeFormatDiffLineRanges() to assume
that the input is generated with --no-prefix.
- change _RunClangFormatDiff() to pass -p0 instead of -p1.

3) update presubmit_support.py to generate diff without --no-prefix.

==== What this CL does ====
It implements (3).
- That is the default option for git-diff.
- I don't find obvious reasons to use --no-prefix.
- CiderG has been generating diffs with prefixes for weeks.
- It implies that presubmit_support.py works fine with a prefixed diff.

Bug: 386840832
Change-Id: Iac8a4fc30f101e70e3ccc56f9f8ee48198dfa833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939737
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-09-12 10:34:21 -07:00
Ergun Erdogmus
6b4f0bfc22 [DevToolsGardener] Fix git cl format --js --full causing an error 
`RunGitDiffCmd` with `--name-only` returns the files separated
by a new line as a string and then `FindFilesToFormat` splits it
to convert it to a files list.

Previously, we were calling `keys()` on this list and it
was throwing an error. Simply returning the file names
should be enough.

See the failure in:
https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8703934325829680961/+/u/Scripted_rolls/Update_Browser_Protocol_deps/Run_Browser_Protocol_script/stdout

Bug: 386840832
Change-Id: I7bf54089726a66867c9126b1c398e8e57cc6eb26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6943433
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2025-09-12 08:41:52 -07:00
Scott Lee
3accee0833 Revert "presubmit: update CheckPatchFormatted to pass --input_diff_file" 
This reverts commit 4689d66abf.

Reason for revert: causing issues in b/386840832

Original change's description:
> presubmit: update CheckPatchFormatted to pass --input_diff_file
>
> Once devs update depot_tools, this will take effect in both
> terminal and CiderG
>
> TESTED: http://go/scrcast/NjM1MzE5NDc4NjQ4ODMyMHxmMzc3NGVlZi03Yg
> Bug: 386840832
> Change-Id: Ibb8f74bffd662eb330f61b9e82bcd75c09bbc232
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6937365
> Commit-Queue: Scott Lee <ddoman@chromium.org>
> Reviewed-by: Gavin Mak <gavinmak@google.com>

Bug: 386840832
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I0bb79952aab4e0fa29607c79ea14f13f2a2a7bb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939736
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2025-09-11 16:29:34 -07:00
Benedikt Meurer
106981b2c9 [DIR_METADATA] Migrate from Monorail to Buganizer. 
Bug: none
Change-Id: I6889f64ee04675b3da2c7f4c576d407cdb03d4d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6935512
Reviewed-by: Brian Ryner <bryner@google.com>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Brian Ryner <bryner@google.com>
 2025-09-11 14:03:58 -07:00
Scott Lee
4689d66abf presubmit: update CheckPatchFormatted to pass --input_diff_file 
Once devs update depot_tools, this will take effect in both
terminal and CiderG

TESTED: http://go/scrcast/NjM1MzE5NDc4NjQ4ODMyMHxmMzc3NGVlZi03Yg
Bug: 386840832
Change-Id: Ibb8f74bffd662eb330f61b9e82bcd75c09bbc232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6937365
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-09-11 10:40:14 -07:00
Scott Lee
363e910475 git_cl: update the clang, java, and yapf formatters to be git-free 
This makes the formatter runners to be git-free if --input_diff_file
is given. They still run `git diff`, if --diff is given. However,
for the purpose of making the presubmit check for format verification
git-free, it's ok as --diff is not used by the presubmit check.


Bug: 386840832
Change-Id: If5ab68fa4e2fec1aafa22e15ddeabb744993342b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6931775
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-09-11 10:28:39 -07:00
recipe-roller
f1e3fbdf09 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8704032409770896913

recipe_engine:
d66b5b6a0c
  d66b5b6 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 43ec34cde4f8 to 49b2e707cefe

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I50610b41674c18b55c850ec3cec943836600d562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6939733
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-11 03:09:17 -07:00
Scott Lee
5ed7fd0ea5 git_cl: add --input_diff_file for git cl format 
If the option is given, git cl format uses the input diff file to
determine the files and sections to format instead of git-diff.

The intended use case is to remove git dependencies in case
presubmit_support.py is executed with a diff file and it calls
presubmit_canned_checks.CheckPatchFormatted().

Bug: 386840832
Change-Id: Ia1eacd1bdb81731e07753df19ebf1d2470c9f1aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6912693
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2025-09-10 14:38:11 -07:00
recipe-roller
88e06ae96e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8704153205978475953

recipe_engine:
61cd6d7ffe
  61cd6d7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from fa42cfa51170 to 7b865aedb415

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I92aa31b64b88aec18202cc91d70378dbc362b807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6933960
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-09 19:09:18 -07:00
Jiewei Qian
958e89cc41 git-cl: disable git ASKPASS and TERMINAL_PROMPT 
Disable interactive authentication so that git won't prompt for username
/ password when the LUCI access token or ReAuth token expired.

Bug: 443632112
Change-Id: Ie347042178facd113df0d96b1909097cebdbb400
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6918922
Reviewed-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
 2025-09-09 16:42:12 -07:00
Jiewei Qian
3ca8f4784d Roll git-credential-luci 
Rolls git-credential-luci to fix a few CLI UX issues.

Bug: 440438534
Change-Id: I440c4df28b2e657a0b924a1a77a380bbb824026c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6918923
Reviewed-by: Chenlin Fan <fancl@chromium.org>
Commit-Queue: Jiewei Qian <qjw@chromium.org>
Auto-Submit: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>
 2025-09-08 17:38:49 -07:00
recipe-roller
1eec93f8bf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8704260788248835889

recipe_engine:
bd938f90e1
  bd938f9 (mohrr@google.com)
      [buildbucket] Add created_by arguments in test APIs

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie0f93c4269a14126e78cfe220bc3b4c11328f760
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6927110
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2025-09-08 14:44:47 -07:00
Gregg Tavares
424bd24d29 Change the PRESUBMIT TODO warning to ask for an issue # 
An issue # is the preferred format. See
https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++-dos-and-donts.md#comment-style
so the warning should suggest an issue #

Note: the check remains the same so just an owner will pass the check
even though owners leave the team making such TODOs useless.

Bug: 440305604
Change-Id: Id107ccb104437201e873d96670c595b84fd90ab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6917466
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Gregg Tavares <gman@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2025-09-08 11:40:50 -07:00
Scott Lee
9c3171ffea git_cl: rename params and reduce indent 
Cosmetic changes for consistent param names and unnecessary indents.

Bug: 400759419
Change-Id: I7845f0b059c66f4d6ceb8c4055d71b8704ff29fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6918336
Auto-Submit: Scott Lee <ddoman@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2025-09-05 11:26:00 -07:00