Olivier Robin
0a6b544e20
Support git cl formatting for swift files
...
swift format is only available on mac hosts.
Swift formatting is disabled by default. It will be
enabled by default on mac host in another CL.
Change-Id: Id603be203edd44b6419d545027c249111abe1baf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3550197
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Olivier Robin <olivierrobin@chromium.org >
2022-04-07 07:25:04 +00:00
Josip Sokcevic
ba94bbeaa8
Use python3 for gsutil bootstrapping
...
R=gavinmak@google.com
Change-Id: I6aaac69c9712e4d639e8804ab603bc18190d88be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3570169
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-04-06 20:40:24 +00:00
recipe-roller
52d64c5ec3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8817601997489655649
recipe_engine:
a6fd0d2d3cchanli@chromium.org )
[time] set the step to canceled if GLOBAL_SHUTDOWN is triggered
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1a2adbaa82f833cb68fd730c213070c6c41adda2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3574982
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-04-06 20:31:34 +00:00
recipe-roller
228634647e
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8817656104304350081
recipe_engine:
1d661d383echromium-autoroll@skia-public.iam.gserviceaccount.com )
Roll CAS Client from b927ccff49e4 to b2aa2d72c22b
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I920282b36284e0cbb2cf5c738d7919c7d4f8ae0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3574164
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-04-06 06:13:44 +00:00
Takuto Ikuta
ffeef9001e
bot_update: change set_output_commit to True by default
...
This is for https://crbug.com/1310066#c7
Bug: 1310066
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Change-Id: I874e1a4c2ca53a7da04d6c24533429d7508088a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3565259
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Takuto Ikuta <tikuta@chromium.org >
Auto-Submit: Takuto Ikuta <tikuta@chromium.org >
2022-04-06 01:33:23 +00:00
Brian Ryner
b8a4c0ba65
The python3 bin directory no longer needs to be added to PATH.
...
Bug: 1003139
Change-Id: Iaa288b8b4b2090ac055f53b6b0e116a7874e8bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3570881
Reviewed-by: Chenlin Fan <fancl@chromium.org >
Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Brian Ryner <bryner@google.com >
2022-04-06 00:27:23 +00:00
recipe-roller
2ca0f52443
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8817693841019893569
recipe_engine:
b4882c1f08chanli@chromium.org )
[time] make sleep a timed wait on global_shutdown
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib394d2eaa1e1971bb605fa662270c46df7e01dae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3573167
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-04-05 20:10:13 +00:00
Chloe Pelling
e515e5d22e
Make the "mark branch dormant" instructions simpler to copy+paste.
...
I regularly run into this error for local branches corresponding to
merged CLs. Before, I had to manually type `git rebase --abort`
before copy-pasting the `git config branch.[...].dormant true` line
into my terminal. With this change, I can just copy-paste once to
execute both steps, then press up+up+enter to retry.
As a side benefit, Git newcomers won't have to look up how to abort
a rebase.
Anyone preferring the previous workflow can still elect to copy
just the `git config` line.
Bug: none
Change-Id: I516d4ed12c5111936cc65460ce119a43e5f86a8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3570882
Auto-Submit: Chloe Pelling <cpelling@google.com >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-04-05 16:37:53 +00:00
recipe-roller
b785ebb82f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8817710211334862417
recipe_engine:
2522322621gbeaty@chromium.org )
Rewrite candidate_algorithm.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie4dd2d0489a727019f87534b88547472999a160c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3569809
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-04-05 15:49:33 +00:00
Yannic Bonenberger
10898d51d1
[autoninja] Respect user-provided AUTONINJA_BUILD_ID
...
Change-Id: I2e1b14827e7ff4c1e88a211f5ae0d7a3322b6f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3569027
Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com >
2022-04-05 09:22:14 +00:00
recipe-roller
ceefb8e588
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8817758027096105281
recipe_engine:
9e3ca47425chromium-autoroll@skia-public.iam.gserviceaccount.com )
Roll CAS Client from a0672c27eaaa to 5fa853f88d79
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78dca1cc94bf4703e2d6538e5ee10d69c8a0dadf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3571024
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-04-05 03:09:23 +00:00
recipe-roller
4dfba2e9e3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8817768722746959889
recipe_engine:
d3504b5106mohrr@google.com )
[path] Add __lt__ to Path
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I050abe5bb1c648767aa8376a24f25921d4624ee6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3569593
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-04-05 00:25:32 +00:00
Bruce Dawson
c4b1b772bc
Prevent path-pollution from vpython3.bat
...
vpython3.bat adds an entry to the path. Unfortunately that modification
persists after the batch file returns. Repeated running of vpython3.bat
will eventually grow the path so long that the command to update the
path exceeds the 8191 character cmd.exe command-length limit. This can
most easily be seen by repeatedly running this command:
vpython3 -c "print('Hello world!')" && set path | wc
After about 35 invocations (dependent on exact system setup) this
happens:
>vpython3 -c "print('Hello world!')" && set path | wc
The input line is too long.
The syntax of the command is incorrect.
This batch also (but less critically) leaks the PYTHON3_BIN_RELDIR
environment variable.
The fix is to add a setlocal command to keep environment changes local.
Bug: 1003139
Change-Id: I11a31e1013017da702299bfe8eb4888985c228f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3566378
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Reviewed-by: Brian Ryner <bryner@google.com >
Commit-Queue: Bruce Dawson <brucedawson@chromium.org >
2022-04-05 00:11:33 +00:00
Fumitoshi Ukai
a9c548efd6
Roll out goma client VERSION=244
...
Bug: b/223292635
Change-Id: I7347c16be3dd70ef0c4fcc22334b4e1b1b3f7e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3566337
Reviewed-by: Takuto Ikuta <tikuta@chromium.org >
Commit-Queue: Fumitoshi Ukai <ukai@google.com >
2022-04-04 04:52:42 +00:00
Bruce Dawson
db8622bc6b
Ensure _PresubmitResult._message is text
...
It is easy to get type confusion and end up passing a list as the
message parameter to _PresubmitResult. This error will not be detected
until the end of the run - perhaps hours later - when all evidence of
where the list came from is lost.
This change ensures that the message parameter is a string. If it is not
then the exception that is thrown should allow quick identification of
the problematic code.
This also fixes a presubmit unit test that passed None as the message.
We could support that but I don't think that we should.
Bug: 1309977
Change-Id: Ifb1d5100d47922b0ebd8bb834caa6fbba690b43c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3566436
Reviewed-by: Jochen Eisinger <jochen@chromium.org >
Commit-Queue: Bruce Dawson <brucedawson@chromium.org >
2022-04-03 15:38:12 +00:00
Josip Sokcevic
017544dc14
Add git cl presubmit --files
...
Chromium's presubmits contain a lot of latent errors - presubmit errors
that will trigger the next time a file is modified, but have been
waiting for years. Flushing those out with "git cl presubmit --all"
works poorly because it exercises all presubmits simultaneously, which
is too slow and triggers too many failures. Adding a --files option lets
small areas of the tree or specific file types to be exercised in a
controlled manner.
Bug: 1311697
Change-Id: I36ec6a759a80000d6ed4a8cc218ece327d45f8d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3559174
Auto-Submit: Bruce Dawson <brucedawson@chromium.org >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2022-03-31 23:47:53 +00:00
Matt Mueller
7f02c0d981
Add *.ts (typescript files) to git-gs
...
Change-Id: I8fc0161d01caf7adb9298f3ef76cd4e7cd69d771
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3561270
Auto-Submit: Matt Mueller <mattm@chromium.org >
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
2022-03-31 01:01:46 +00:00
Andrey Kosyakov
c0169f32a3
Skip depot_tools update for gclient recurse
...
update_depot_tools has become chatty since https://crrev.com/c/3556588 ,
which interfers with processing output from commands being recursed.
Change-Id: I47ea49fbe2b1c196562ef8389d981abe8eb5788b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3561658
Commit-Queue: Andrey Kosyakov <caseq@chromium.org >
Auto-Submit: Andrey Kosyakov <caseq@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-30 18:21:57 +00:00
Josip Sokcevic
0213e4b2d8
Print updating depot_tools in stderr
...
stdout print statement may interfere with automated tooling. Instead,
this prints the warning to stderr. See: https://crrev.com/c/3556588
R=gavinmak@google.com
Change-Id: I3fb72b7ab4afe42cb83ea5e506292f3e6e5ea8d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3561445
Auto-Submit: Josip Sokcevic <sokcevic@google.com >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2022-03-30 17:45:56 +00:00
recipe-roller
575321a239
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8818269521590158689
recipe_engine:
83eab4616ewhesse@google.com )
[buildbucket] Relax type check on buildbucket ids
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic7ead94e12af6cfb42488815ef55e90bd67865e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3560081
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-30 11:40:38 +00:00
Chan Li
8dd5e6278f
[depot_tools] roll dirmd
...
To release https://chromium-review.googlesource.com/c/infra/infra/+/3558516
Bug: 1285078
Change-Id: If7e00c21ffb5945f04e130a2c4bb28a6da862211
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3558021
Auto-Submit: Chan Li <chanli@chromium.org >
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
2022-03-29 22:24:06 +00:00
Bruce Dawson
028f4615ad
Fix CheckDirMetadataFormat for Windows command limits
...
CheckDirMetadataFormat executes dirmd on all applicable files. When
running "git cl presubmit --all" that ends up being ~7,500 files and
the command line that is generated is ~500,000 characters. Windows does
not like that.
This change breaks up the check into multiple invocations of dirmd in
order to avoid these limits. This is important because running all
presubmits is the only way to systematically find bugs, and avoid being
surprised by them when submitting a change.
Bug: 1309977
Change-Id: I24fbc340cdb975dbe7f6a2132e516d6f7e2f9165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3554633
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Bruce Dawson <brucedawson@chromium.org >
2022-03-29 21:18:27 +00:00
Bruce Dawson
8fa42e2b5c
Improve git cl presubmit --all output
...
When running git cl presubmit --all which is handy for finding
latent presubmit bugs, the 'No diff found for %s' gets printed many
thousands of times, making actual issues difficult to find. This change
suppresses that message, to make actual issues easier to find.
The message for slow presubmits prints the name of the slow presubmit,
but there are 243 different CheckChangeOnCommit functions, so the name
is actually not sufficient. Therefore this change plumbs through the
path to the script containing the presubmit and prints it.
Similarly, the cpplint message "Done processing %s" doesn't add enough
value.
These changes will make it easier to find the signal in the presubmit
noise.
Bug: 1309977
Change-Id: Iba40b5748266e3296eeb530bb00182db4814aa5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3556594
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Bruce Dawson <brucedawson@chromium.org >
2022-03-29 17:05:38 +00:00
Josip Sokcevic
f560d36bba
Let user know when depot_tools is being updated.
...
R=gavinmak@google.com
Change-Id: Ieacc0cbe21a5b7216bb8057b3a81139f2d2c608e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3556588
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
Auto-Submit: Josip Sokcevic <sokcevic@google.com >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Gavin Mak <gavinmak@google.com >
2022-03-28 23:17:46 +00:00
Chan Li
5ce78e1a3f
Roll dirmd
...
Bug: 1285078
Change-Id: I9dd8b94ecf3b9c936474d5447ec2f3a27e66ff0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3555575
Auto-Submit: Chan Li <chanli@chromium.org >
Reviewed-by: Yuanjun Huang <yuanjunh@google.com >
Commit-Queue: Yuanjun Huang <yuanjunh@google.com >
2022-03-28 19:00:52 +00:00
recipe-roller
6445e79ff5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8818423030123458017
recipe_engine:
f15df273f1chanli@chromium.org )
Extend placeholder.py to schedule child builds
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1ea7e4e3ef5e08d186699652e868e943aa785992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3554910
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-28 18:59:32 +00:00
recipe-roller
01a4536ff8
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8818784791056569841
recipe_engine:
826d446ec1kimstephanie@google.com )
Add new post_process.PropertiesContain to check that key exists
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idbdcabdf3492aa6feb63000e42704645f16a46d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3550128
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-24 19:16:05 +00:00
recipe-roller
62396c5a83
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8818837640083038065
recipe_engine:
14202da142chromium-autoroll@skia-public.iam.gserviceaccount.com )
Roll CAS Client from addd54e4fcef to 6da0608e4fa8
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1cff6d3699af311d2cad63203b4e68ea7e5c1d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3547312
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-24 05:11:15 +00:00
recipe-roller
2bb5737a65
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8818859027517432961
recipe_engine:
6d2e271e26gredelston@google.com )
walkthrough.md: Fix incorrect kwarg "output"
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4eb64c382f0425421442b5f2e061fb9d0d709618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3547302
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-23 23:31:25 +00:00
recipe-roller
b7f4890531
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8818861546960423089
recipe_engine:
b788d0a7f9vadimsh@chromium.org )
[scheduler] Expose job ID and invocation ID.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I84414ae0738ec657d7c04b6c85c4b827211a85f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3546041
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-23 22:51:53 +00:00
Josip Sokcevic
4de5deacd4
Explicitly run everything with python3
...
R=aravindvasudev@google.com , gavinmak@google.com
Change-Id: Iaa5e960c6226dea3a0814c7cb778d952eafb1502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3525960
Reviewed-by: Gavin Mak <gavinmak@google.com >
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-23 21:15:14 +00:00
Aravind Vasudevan
075cd76fe6
Update argument parsing to use argparse
...
This CL updates argument parsing mechanism from using a custom implementation + optparse to argparse. It is intended to clear tech debt for future changes.
Change-Id: I06ba5d3c532638a7970be960e02ebbafbea9dcb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3541479
Reviewed-by: Gavin Mak <gavinmak@google.com >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com >
2022-03-23 21:13:13 +00:00
Robert Iannucci
e7eb3eb81a
Roll lucicfg to v1.30.11
...
This is to pick up
6a48964ed4https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3543152
Auto-Submit: Robbie Iannucci <iannucci@chromium.org >
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org >
Commit-Queue: Robbie Iannucci <iannucci@chromium.org >
2022-03-23 06:02:36 +00:00
Ryan Heise
d8464b8528
Update Pinpoint CLI to remove some useless prints
...
Bug:1281693
Change-Id: Ia0a721b42f71aab1ea728c5ae8c5975c3f50267c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3543680
Commit-Queue: Ryan Heise <heiserya@google.com >
Auto-Submit: Ryan Heise <heiserya@google.com >
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org >
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org >
2022-03-22 21:57:32 +00:00
Chris Blume
bd68291e20
Reland "Support multiple VS installations" (with fix)
...
This reverts commit 9ce8be333936d41ceff8https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3458722
> > Reviewed-by: Gavin Mak <gavinmak@google.com >
> > Reviewed-by: Chris Blume <cblume@chromium.org >
> > Commit-Queue: Chris Blume <cblume@chromium.org >
> > Auto-Submit: Chris Blume <cblume@chromium.org >
>
> Change-Id: I3d9147a7786f7f54f861087d16967b75d4afe2c5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3504193
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org >
Change-Id: Ica90cb8d5ce08b8b127da64969401cb40d4aee63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497899
Reviewed-by: Bruce Dawson <brucedawson@chromium.org >
Commit-Queue: Chris Blume <cblume@chromium.org >
2022-03-22 13:23:33 +00:00
recipe-roller
57629303a2
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8819037709122726049
recipe_engine:
3db9e1bd1echanli@chromium.org )
Reland "[recipe-py] buildbucket: enable buildbucket tracking pa...
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I47c4f5d549c3ba93fd7b788fe3f8cd860d638f82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3541481
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-22 00:14:11 +00:00
Josip Sokcevic
0399e1762c
Add a basic depot_tools version information
...
depot_tools has no versioning. It's hard to know if reported issues were
caused due to outdated depot_tools or actual unresolved bug.
This CL adds basic information about depot_tools version and it's
included in presubmit failure.
R=aravindvasudev@google.com , gavinmak@google.com
Change-Id: If8577c0826063693a7278a57a0cce629d4b1325f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3541061
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com >
Reviewed-by: Gavin Mak <gavinmak@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-21 23:11:51 +00:00
Ryan Macnak
fd032192ed
Update cpplint.py's interpreter directive to python3.
...
Change-Id: Ic6c1ebd049350348cdd0cd4db717bda8c6f3dc34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3540610
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com >
Commit-Queue: Ryan Macnak <rmacnak@google.com >
2022-03-21 20:45:12 +00:00
Aleksey Khoroshilov
df3228656a
Set errorlevel in .bat wrappers on exit /b where appropriate.
...
Fixed goma_auth/ctl return code on Windows which was always zero.
Fixed other places where exit /b was used without %errorlevel%.
Change-Id: Ib0a647818c595f843a95762db023b111a447a66a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3532153
Reviewed-by: Takuto Ikuta <tikuta@chromium.org >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-21 20:05:31 +00:00
Josip Sokcevic
6ec83a2426
Revert "Add VPYTHON_BYPASS support for vpython on Windows"
...
This reverts commit bc93924b3bhttps://crbug.com/1308393
Original change's description:
> Add VPYTHON_BYPASS support for vpython on Windows
>
> At Postman, we use a custom build of Electron which is built using a set
> of tools that are managed by us. Till now, we were using the
> VPYTHON_BYPASS environment variable to use our own managed version of
> Python on macOS but unfortunately, on Windows, depot_tools doesn't
> respect the value of this variable, so this change adds support for that
> on Windows too.
>
> Signed-off-by: Darshan Sen <raisinten@gmail.com >
> Change-Id: I63da0495463ace87d34c3c6fad1c03dee108d14b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3525642
> Reviewed-by: Josip Sokcevic <sokcevic@google.com >
> Commit-Queue: Josip Sokcevic <sokcevic@google.com >
Bug: 1308393
Change-Id: I8cea8827e185d516b8f860b2aa8a8f21a75a8b1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3539039
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-21 15:42:41 +00:00
Chenlin Fan
f0bc2d2404
New vpython in depot_tools
...
This is a reland of crrev/c/3461263 with fix for crbug/1298289
This change includes commits:
0a242ce3e02a0e7d9c519601ed4fafb073fc98da Update vpython tests to use py3
fc06fd6815873bc40819476f88808b61ac447739 Change vpython spec search order
c6a2eb6ed31e0c815d7f28a42d7f12ee4cb47119 Update to latest virtualenv package.
038156fc1ffffa56b19c2c60674415eceb95f6bc New virtualenv to vpython.
ef44f81748a55c3aaf028ccfa2ee11876cee1285 Fix vpython filelock
275c4196540e1ca41384031b292ad0b89393a5dc Revert "Fix vpython filelock"
8aadd8b60a6d3801f62c7e5cebdfe3dc828a1546 Fix vpython filelock
43c99d88a24870240c9ca50d67dcfade40b516cc Use resolved path when searching spec
ffda9381bc01fd33e3c5a889e2ed374312c64ec6 Don't eval python symbol link on windows
30a66930f4037fff949d36c45b12f60a40ec524b Include GOARCH to verify cached environment
748dcd23529b6b138424914f1e6e265ed70d377b [vpython] Add period to log
Bug:1279621,1158462,1278132,1279684
Change-Id: I224d6abf6e106116da83aa2c34447e8601e48c67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3530470
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Chenlin Fan <fancl@chromium.org >
2022-03-20 23:32:41 +00:00
Chan Li
fbb927599f
[depot_tools] roll led
...
This is to release below changes to get led ready for bbagent get-build mode
crrev.com/c/3511002
crrev.com/c/3507137
Bug: 1219018
Change-Id: I05b383f527f30e4caa0b2d399b8c5c8123470a64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3536929
Reviewed-by: Robbie Iannucci <iannucci@chromium.org >
Commit-Queue: Chan Li <chanli@chromium.org >
2022-03-18 18:13:16 +00:00
Darshan Sen
bc93924b3b
Add VPYTHON_BYPASS support for vpython on Windows
...
At Postman, we use a custom build of Electron which is built using a set
of tools that are managed by us. Till now, we were using the
VPYTHON_BYPASS environment variable to use our own managed version of
Python on macOS but unfortunately, on Windows, depot_tools doesn't
respect the value of this variable, so this change adds support for that
on Windows too.
Signed-off-by: Darshan Sen <raisinten@gmail.com >
Change-Id: I63da0495463ace87d34c3c6fad1c03dee108d14b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3525642
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-18 17:27:36 +00:00
recipe-roller
76979dae56
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8819395691922433665
recipe_engine:
9eef3210f8gbeaty@chromium.org )
Prevent creation of candidates for dependencies of dependencies.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3c6990049765208e9f11a3e3115fb96fad895ac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3534725
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-18 01:25:45 +00:00
recipe-roller
950a6b4225
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8819498242767688273
recipe_engine:
c827c1b6bbchanli@chromium.org )
Revert "[recipe-py] buildbucket: enable buildbucket tracking pa...
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8420e3748e71b20d3b8164b7b1d9207a6c6beb33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3530536
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-16 22:11:04 +00:00
recipe-roller
b199f54926
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8819602052226167377
recipe_engine:
087afb884achanli@chromium.org )
[recipe-py] buildbucket: enable buildbucket tracking parent/chi...
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I903b335f31dbb9da87162590824c332e4034778f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3527073
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-15 18:43:33 +00:00
recipe-roller
79b4bab70c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
The build that created this CL was
https://ci.chromium.org/b/8819641688027070305
recipe_engine:
cde011f97cmachenbach@chromium.org )
[led] Add common logic to trigger a builder
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I719569bd59dc779ee75b3150dcbbc9096eafb9c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3524133
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com >
2022-03-15 08:17:38 +00:00
Stephanie Kim
3481645827
Check if json exists in ensure_checkout's finally block
...
The step_result json can currently be empty if the orchestrator build
is canceled while running bot_update. Trying to do
step_result.json.output in the finally block raises an "Uncaught
exception AttributeError".
Ex: https://ci.chromium.org/ui/p/chromium/builders/try/win10_chromium_x64_rel_ng/1121568/overview
This change checks for the json attr before trying to read json.output.
Bug: 1305332
Change-Id: I1dc277642ece1b96144be6381a7c4b8426cb2bc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3518372
Reviewed-by: Garrett Beaty <gbeaty@google.com >
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Stephanie Kim <kimstephanie@google.com >
2022-03-14 21:04:02 +00:00
Ravi Mistry
c848a4ed33
Fix host and repo parsing for download-topics
...
Previous code was incorrectly assuming that the repo name always matched the host name.
Bug: chromium:1298922
Change-Id: Ic90ed585503d721f4d771b4f390a04c7f5b26622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3507359
Reviewed-by: Josip Sokcevic <sokcevic@google.com >
Commit-Queue: Ravi Mistry <rmistry@chromium.org >
2022-03-10 18:19:59 +00:00
Josip Sokcevic
1909696991
Reland "Update gsutil to use gsutil version 4.68"
...
This is a reland of commit 8edc960e9aR=gavinmak@google.com
>
> Bug: 1184108
> Change-Id: I002cc3625a2184ab42383b88a014c0631d1a33ee
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3508516
> Reviewed-by: Gavin Mak <gavinmak@google.com >
> Commit-Queue: Josip Sokcevic <sokcevic@google.com >
Bug: 1184108
Change-Id: I8f4b726c203ed12d415deeec249972fe855b59c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3514940
Reviewed-by: Brian Ryner <bryner@google.com >
Commit-Queue: Josip Sokcevic <sokcevic@google.com >
2022-03-10 17:56:09 +00:00
