InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make the freeze check Chromium-specific and update dates

Browse Source 
Bug: 381098374
Change-Id: I52456322481e546f48175e33ef330dfd8306c28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6048214
Auto-Submit: Gary Tong <gatong@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Gary Tong <gatong@chromium.org>
This commit is contained in:
Gary Tong
2024-11-27 18:44:48 +00:00
committed by LUCI CQ
parent 297f5a341c
commit bd7f36598e
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
presubmit_canned_checks.py
View File

@@ -907,14 +907,21 @@ def CheckChromiumDependencyMetadata(input_api, output_api, file_filter=None):
_IGNORE_FREEZE_FOOTER = 'Ignore-Freeze'
_FREEZE_TZ = datetime.timezone(-datetime.timedelta(hours=8), 'PST')
_FREEZE_START = datetime.datetime(2024, 10, 12, 0, 0, tzinfo=_FREEZE_TZ)
_FREEZE_END = datetime.datetime(2024, 10, 19, 0, 0, tzinfo=_FREEZE_TZ)
_FREEZE_DETAILS = 'Internal infra conference'
_CHROMIUM_FREEZE_START = datetime.datetime(2024, 12, 13, 0, 0, tzinfo=_FREEZE_TZ)
_CHROMIUM_FREEZE_END = datetime.datetime(2025, 1, 2, 0, 0, tzinfo=_FREEZE_TZ)
_CHROMIUM_FREEZE_DETAILS = 'Holiday freeze'
def CheckInfraFreeze(input_api,
output_api,
files_to_include=None,
files_to_exclude=None):
return CheckChromiumInfraFreeze(input_api, output_api, files_to_include,
files_to_exclude)
def CheckChromiumInfraFreeze(input_api,
output_api,
files_to_include=None,
files_to_exclude=None):
"""Prevent modifications during infra code freeze.
Args:
@@ -936,7 +943,7 @@ def CheckInfraFreeze(input_api,
"""
# Not in the freeze time range
now = datetime.datetime.now(_FREEZE_TZ)
if now < _FREEZE_START or now >= _FREEZE_END:
if now < _CHROMIUM_FREEZE_START or now >= _CHROMIUM_FREEZE_END:
input_api.logging.info('No freeze is in effect')
return []
@@ -975,8 +982,9 @@ def CheckInfraFreeze(input_api,
'\t{}\n\n'
'The following files cannot be modified:\n {}.\n\n'
'Add "{}: <reason>" to the end of your commit message to override.'.
format(_FREEZE_START, _FREEZE_END, _FREEZE_DETAILS,
'\n '.join(files), _IGNORE_FREEZE_FOOTER))
format(_CHROMIUM_FREEZE_START, _CHROMIUM_FREEZE_END,
_CHROMIUM_FREEZE_DETAILS, '\n '.join(files),
_IGNORE_FREEZE_FOOTER))
]