InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Gerrit: Enable overriding step_test_data

Browse Source 
Bug: v8:7419
Change-Id: I49ad9358b9487b76503c3c1f4d6838aa0dd42736
Reviewed-on: https://chromium-review.googlesource.com/938969
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
This commit is contained in:
Michael Achenbach
2018-02-26 17:58:14 -08:00
committed by Commit Bot
parent 6f83031f3d
commit 9b4d0c7715
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
recipes/README.recipes.md
View File

@@ -353,7 +353,7 @@ Args:
Returns:
the name of the branch
&mdash; **def [get\_changes](/recipes/recipe_modules/gerrit/api.py#122)(self, host, query_params, start=None, limit=None, o_params=None, \*\*kwargs):**
&mdash; **def [get\_changes](/recipes/recipe_modules/gerrit/api.py#122)(self, host, query_params, start=None, limit=None, o_params=None, step_test_data=None, \*\*kwargs):**
Query changes for the given host.
@@ -366,6 +366,7 @@ Args:
limit: Maximum number of results to return.
o_params: A list of additional output specifiers, as documented here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
step_test_data: Optional mock test data for the underlying gerrit client.
Returns:
A list of change dicts as documented here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes

7
recipes/recipe_modules/gerrit/api.py
View File

@@ -120,7 +120,7 @@ class GerritApi(recipe_api.RecipeApi):
host, change, patchset))
def get_changes(self, host, query_params, start=None, limit=None,
o_params=None, **kwargs):
o_params=None, step_test_data=None, **kwargs):
"""
Query changes for the given host.
@@ -133,6 +133,7 @@ class GerritApi(recipe_api.RecipeApi):
limit: Maximum number of results to return.
o_params: A list of additional output specifiers, as documented here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
step_test_data: Optional mock test data for the underlying gerrit client.
Returns:
A list of change dicts as documented here:
https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#list-changes
@@ -150,10 +151,12 @@ class GerritApi(recipe_api.RecipeApi):
args += ['-p', '%s=%s' % (k, v)]
for v in (o_params or []):
args += ['-o', v]
if not step_test_data:
step_test_data = lambda: self.test_api.get_one_change_response_data()
return self(
kwargs.pop('name', 'changes'),
args,
step_test_data=lambda: self.test_api.get_one_change_response_data(),
step_test_data=step_test_data,
**kwargs
).json.output