InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Edit warning in split_cl.py

Browse Source 
Per https://groups.google.com/a/google.com/g/mchristoff-team/c/U_4MKQwnJcU/m/3V4zgTiABQAJ,
a given user's CQ+1 and CQ+2 runs have a global throttle limit, to
avoid straining the build infrastructure too much. We can therefore
adjust the warning in `git cl split`.

Change-Id: I9f07c93bd428e70b49d13b4cbf085da024c78210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5748984
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Chris Fredrickson <cfredric@chromium.org>
Auto-Submit: Chris Fredrickson <cfredric@chromium.org>
This commit is contained in:
Chris Fredrickson
2024-07-30 17:34:18 +00:00
committed by LUCI CQ
parent 0d1d311024
commit 8893866bf7
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
split_cl.py
View File

@@ -272,16 +272,17 @@ def SplitCl(description_file, comment_file, changelist, cmd_upload, dry_run,
print('Will split current branch (' + refactor_branch + ') into ' +
str(num_cls) + ' CLs.\n')
if not dry_run and num_cls > CL_SPLIT_FORCE_LIMIT:
print(
'This will generate "%r" CLs. This many CLs can potentially'
' generate too much load on the build infrastructure.\n\n'
'Please email infra-dev@chromium.org to ensure that this won\'t'
' break anything. The infra team reserves the right to cancel'
' your jobs if they are overloading the CQ.\n\n'
'(Alternatively, you can reduce the number of CLs created by'
' using the --max-depth option. Pass --dry-run to examine the'
' CLs which will be created until you are happy with the'
' results.)' % num_cls)
print('This will generate "%r" CLs. This many CLs may potentially'
' reach the limit of concurrent runs, imposed on you by the '
'build infrastructure. Your runs may be throttled as a '
'result.\n\nPlease email infra-dev@chromium.org if you '
'have any questions. '
'The infra team reserves the right to cancel'
' your jobs if they are overloading the CQ.\n\n'
'(Alternatively, you can reduce the number of CLs created by'
' using the --max-depth option. Pass --dry-run to examine the'
' CLs which will be created until you are happy with the'
' results.)' % num_cls)
answer = gclient_utils.AskForData('Proceed? (y/n):')
if answer.lower() != 'y':
return 0