InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update the freeze checks to support multiple freeze periods.

Browse Source 
This updates the CheckInfraFreeze/CheckChromiumInfraFreeze functions to
operate on the _CHROMIUM_FREEZES list of tuples with start, end and
details that define freeze periods rather than a single freeze period
defined by the _CHROMIUM_FREEZE_START, _CHROMIUM_FREEZE_END and
_CHROMIUM_FREEZE_DETAILS values. This will enable defining the freeze
periods for end-of-year all at once rather than requiring an update
between the November and December/January periods.

The periods have been set to match the announced end-of-year freeze
dates.

Change-Id: I7ea9d19fad71d086cef3de0e02ea40fda35460ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/7090808
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
This commit is contained in:
Garrett Beaty
2025-11-13 10:57:54 -08:00
committed by LUCI CQ
parent 9c69e0d573
commit 8257337edc
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
presubmit_canned_checks.py
View File

@@ -943,10 +943,20 @@ def CheckChromiumDependencyMetadata(input_api, output_api, file_filter=None):
_IGNORE_FREEZE_FOOTER = 'Ignore-Freeze'
_FREEZE_TZ = datetime.timezone(-datetime.timedelta(hours=8), 'PST')
_CHROMIUM_FREEZE_START = datetime.datetime(
2024, 12, 20, 17, 1, tzinfo=_FREEZE_TZ)
_CHROMIUM_FREEZE_END = datetime.datetime(2025, 1, 5, 17, 0, tzinfo=_FREEZE_TZ)
_CHROMIUM_FREEZE_DETAILS = 'Holiday freeze'
# (freeze start, freeze end, freeze details)
_CHROMIUM_FREEZES = [
(
datetime.datetime(2025, 11, 21, 17, 1, tzinfo=_FREEZE_TZ),
datetime.datetime(2025, 11, 30, 17, 0, tzinfo=_FREEZE_TZ),
'Holiday freeze',
),
(
datetime.datetime(2025, 12, 19, 17, 1, tzinfo=_FREEZE_TZ),
datetime.datetime(2026, 1, 4, 17, 0, tzinfo=_FREEZE_TZ),
'Holiday freeze',
),
]
def CheckInfraFreeze(input_api,
output_api,
@@ -980,7 +990,10 @@ def CheckChromiumInfraFreeze(input_api,
"""
# Not in the freeze time range
now = datetime.datetime.now(_FREEZE_TZ)
if now < _CHROMIUM_FREEZE_START or now >= _CHROMIUM_FREEZE_END:
for start, end, details in _CHROMIUM_FREEZES:
if start <= now < end:
break
else:
input_api.logging.info('No freeze is in effect')
return []
@@ -1002,7 +1015,7 @@ def CheckChromiumInfraFreeze(input_api,
for af in input_api.AffectedFiles(file_filter=file_filter)
]
# The Cl does not touch ny files covered by the freeze
# The Cl does not touch any files covered by the freeze
if not files:
input_api.logging.info('No affected files are covered by freeze')
return []
@@ -1019,8 +1032,7 @@ def CheckChromiumInfraFreeze(input_api,
'\t{}\n\n'
'The following files cannot be modified:\n {}.\n\n'
'Add "{}: <reason>" to the end of your commit message to override.'.
format(_CHROMIUM_FREEZE_START, _CHROMIUM_FREEZE_END,
_CHROMIUM_FREEZE_DETAILS, '\n '.join(files),
format(start, end, details, '\n '.join(files),
_IGNORE_FREEZE_FOOTER))
]