InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 10:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

presubmit: support checking new TODO format

Browse Source 
R=sokcevic

Bug: 1479023
Change-Id: I6eabb16447526fbc8de83b823763888aff1a8249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4847314
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
This commit is contained in:
Yiwei Zhang
2023-09-08 20:10:51 +00:00
committed by LUCI CQ
parent c56d8196e1
commit 7a69b031d5
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
presubmit_canned_checks.py
View File

@@ -539,12 +539,16 @@ def CheckChangeHasNoTabs(input_api, output_api, source_file_filter=None):
def CheckChangeTodoHasOwner(input_api, output_api, source_file_filter=None):
"""Checks that the user didn't add TODO(name) without an owner."""
unowned_todo = input_api.re.compile('TO' 'DO[^(]')
"""Checks that the user didn't add `TODO(name)` or `TODO: name -` without
an owner.
"""
legacyTODO = '\\s*\\(.+\\)\\s*:'
modernTODO = ':\\s*[^\\s]+\\s*\\-'
unowned_todo = input_api.re.compile('TODO(?!(%s|%s))' %
(legacyTODO, modernTODO))
errors = _FindNewViolationsOfRule(lambda _, x: not unowned_todo.search(x),
input_api, source_file_filter)
errors = ['Found TO' 'DO with no owner in ' + x for x in errors]
errors = ['Found TODO with no owner in ' + x for x in errors]
if errors:
return [output_api.PresubmitPromptWarning('\n'.join(errors))]
return []

3
tests/presubmit_unittest.py
View File

@@ -2049,6 +2049,9 @@ class CannedChecksUnittest(PresubmitTestsBase):
presubmit.OutputApi.PresubmitPromptWarning)
def testCheckChangeTodoHasOwner(self):
self.ContentTest(presubmit_canned_checks.CheckChangeTodoHasOwner,
"TODO: foo - bar", None, "TODO: bar", None,
presubmit.OutputApi.PresubmitPromptWarning)
self.ContentTest(presubmit_canned_checks.CheckChangeTodoHasOwner,
"TODO(foo): bar", None, "TODO: bar", None,
presubmit.OutputApi.PresubmitPromptWarning)