mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 18:51:29 +00:00
Create patch set 2
Change has been successfully rebased and submitted as6f577a0fc5Patch-set: 2 Patch-set-description: Rebase Subject: Revert "siso: clean up _start_collector function to not modify the env dict." Status: merged Commit:6f577a0fc5Tag: autogenerated:gerrit:merged Groups:9b50920464Label: Auto-Submit=+1, 0b22375690c274a8944ef9c9ef61dc862a4752e0 Gerrit User 1366072 <1366072@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Label: Commit-Queue=+2, 41c8370cd21d707941a7806949333704300680e9 Gerrit User 1471321 <1471321@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Label: Bot-Commit=+1, dfe6cb5fa5f2df27650f9dab2de1b4d3ac3713ef Gerrit User 1471321 <1471321@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Label: SUBM=+1, 0f1e5634f8a86dca6363704a49ab08e2c0218eb3 Submission-id: 7407117 Submitted-with: OK Submitted-with: Rule-Name: gerrit~DefaultSubmitRule Submitted-with: MAY: Auto-Submit: Gerrit User 1366072 <1366072@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Submitted-with: MAY: Code-Coverage Submitted-with: MAY: Code-Review Submitted-with: MAY: Commit-Queue: Gerrit User 1471321 <1471321@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Submitted-with: MAY: Feels Submitted-with: MAY: Owners-Override Submitted-with: MAY: Lint Submitted-with: MAY: Bot-Commit: Gerrit User 1471321 <1471321@3ce6091f-6c88-37e8-8c75-72f92ae8dfba> Submitted-with: OK Submitted-with: Rule-Name: Code-Owners Base:02da7602fbOurs:9b50920464Theirs:02da7602fbMerge-Strategy: recursive Contains-Conflicts: false Attention: {"person_ident":"Gerrit User 1552902 \u003c1552902@3ce6091f-6c88-37e8-8c75-72f92ae8dfba\u003e","operation":"REMOVE","reason":"Change was submitted"}
This commit is contained in:
committed by
Gerrit Code Review
parent
1aae821d79
commit
59451962bc
172
9b50920464c4d64850bb8260e89c60f0cb401348
Normal file
172
9b50920464c4d64850bb8260e89c60f0cb401348
Normal file
@@ -0,0 +1,172 @@
|
||||
{
|
||||
"comments": [],
|
||||
"submitRequirementResults": [
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Admin-Approval",
|
||||
"description": {
|
||||
"value": "Changes to refs/meta/config must be approved by a git admin."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "branch:refs/meta/config"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "(uploaderin:mdb/chrome-git-admins OR label:Code-Review\u003dMAX,group\u003dmdb/chrome-git-admins) AND label:Code-Review\u003dMAX,user\u003dnon_uploader AND -label:Code-Review\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"branch:refs/meta/config"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["branch:refs/meta/config"],"atomExplanations":{"value":{"branch:refs/meta/config":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"(uploaderin:mdb/chrome-git-admins OR label:Code-Review=MAX,group=mdb/chrome-git-admins) AND label:Code-Review=MAX,user=non_uploader AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"patchSetCommitId": "9b50920464c4d64850bb8260e89c60f0cb401348",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Code-Review",
|
||||
"description": {
|
||||
"value": "Submit requirement for the \u0027Code-Review\u0027 label"
|
||||
},
|
||||
"applicabilityExpression": {},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "label:Code-Review\u003dMAX,user\u003dnon_uploader -label:Code-Review\u003dMIN"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "label:Bot-Commit\u003d+1 AND -label:Code-Review\u003dMIN"
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Code-Review=MAX,user=non_uploader -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX,user=non_uploader","label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Code-Review=MAX,user=non_uploader":"","label:Code-Review=MIN":""}}}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"label:Bot-Commit=+1 AND -label:Code-Review=MIN"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["label:Bot-Commit=+1"],"failingAtoms":["label:Code-Review=MIN"],"atomExplanations":{"value":{"label:Bot-Commit=+1":"","label:Code-Review=MIN":""}}}
|
||||
},
|
||||
"patchSetCommitId": "9b50920464c4d64850bb8260e89c60f0cb401348",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "No-Unresolved-Comments",
|
||||
"description": {
|
||||
"value": "Changes that have unresolved comments are not submittable. Unless overridden with Unresolved-Comment-Reason: \u003creason\u003e line in change message."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "has:unresolved"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "-has:unresolved"
|
||||
},
|
||||
"overrideExpression": {
|
||||
"value": {
|
||||
"expressionString": "message:\"^.*Unresolved-Comment-Reason:.*\""
|
||||
}
|
||||
},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"has:unresolved"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["has:unresolved"],"atomExplanations":{"value":{"has:unresolved":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"-has:unresolved"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"overrideExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"message:\"^.*Unresolved-Comment-Reason:.*\""},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"patchSetCommitId": "9b50920464c4d64850bb8260e89c60f0cb401348",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Review-Enforcement",
|
||||
"description": {
|
||||
"value": "Two trusted contributors must approve the change. Uploading the change or voting positively on Code-Review count as approval. For Google employees, using a trusted device is required (http://go/gerrit-onboarding#review-enforcement). For non-Google employees, ReAuth is required (https://chromium.googlesource.com/chromium/src/+/HEAD/docs/gerrit_reauth.md)."
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "is:review-enforced_gerrit"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "is:review-enforcement-satisfied_gerrit"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": false
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforced_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforced_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforced_gerrit":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:review-enforcement-satisfied_gerrit"},"status":"PASS","errorMessage":{"value":null},"passingAtoms":["is:review-enforcement-satisfied_gerrit"],"failingAtoms":[],"atomExplanations":{"value":{"is:review-enforcement-satisfied_gerrit":"Change is approved by trusted account"}}}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "9b50920464c4d64850bb8260e89c60f0cb401348",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
},
|
||||
{
|
||||
"submitRequirement": {
|
||||
"name": "Verified",
|
||||
"description": {
|
||||
"value": "Submit requirement for the \u0027Verified\u0027 label"
|
||||
},
|
||||
"applicabilityExpression": {
|
||||
"value": {
|
||||
"expressionString": "is:false"
|
||||
}
|
||||
},
|
||||
"submittabilityExpression": {
|
||||
"expressionString": "is:true"
|
||||
},
|
||||
"overrideExpression": {},
|
||||
"allowOverrideInChildProjects": true
|
||||
},
|
||||
"applicabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"],"atomExplanations":{"value":{"is:false":""}}}
|
||||
},
|
||||
"submittabilityExpressionResult": {
|
||||
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[],"atomExplanations":{"value":null}}
|
||||
},
|
||||
"overrideExpressionResult": {},
|
||||
"patchSetCommitId": "9b50920464c4d64850bb8260e89c60f0cb401348",
|
||||
"legacy": {
|
||||
"value": false
|
||||
},
|
||||
"forced": {},
|
||||
"hidden": {}
|
||||
}
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user