InTheForest/chromium_depot_tools
1
0
Fork 0
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools.git synced 2026-01-11 18:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix get_files_affected_by_patch to work with spaces in file names.

Browse Source 
Bug: 1288604
Change-Id: Ie116316062e50138668299538a5e0759a1dd3fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3459466
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
This commit is contained in:
Garrett Beaty
2022-02-15 00:17:45 +00:00
committed by LUCI CQ
parent 9ae2169b63
commit 4e4a2b865b
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
recipes/recipe_modules/tryserver/api.py
View File

@@ -253,7 +253,7 @@ class TryserverApi(recipe_api.RecipeApi):
self.m.raw_io.test_api.stream_output('foo.cc'),
**kwargs)
paths = [self.m.path.join(patch_root, p.decode('utf-8')) for p in
step_result.stdout.split()]
step_result.stdout.splitlines()]
paths.sort()
if self.m.platform.is_win:
# Looks like "analyze" wants POSIX slashes even on Windows (since git

11
recipes/recipe_modules/tryserver/tests/get_files_affected_by_patch.py
View File

@@ -90,3 +90,14 @@ def GenTests(api):
api.post_check(post_process.StatusSuccess),
api.post_process(post_process.DropExpectation),
)
yield api.test(
'file-with-spaces',
api.tryserver.get_files_affected_by_patch(['file with spaces.txt']),
api.properties(
patch_root='',
expected_files=['file with spaces.txt'],
),
api.post_check(post_process.StatusSuccess),
api.post_process(post_process.DropExpectation),
)