mirror of
https://chromium.googlesource.com/chromium/tools/depot_tools.git
synced 2026-01-11 10:41:31 +00:00
Revert "reclient: Enable racing for chrome developers"
This reverts commit 24ac2543c7.
Reason for revert: hard links dont work on tmpfs b/288997481
Original change's description:
> reclient: Enable racing for chrome developers
>
> racing_bias=0.95 is a best guess based on benchmarks on my glinux and gwindows cloudtops, and my gmac laptop. I will monitor build performance data and adjust the bias based on that.
>
> Bug: b/288285261
> Change-Id: Ie8652281f7bc815e64978bcd56a75e5ec28e2132
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4633180
> Commit-Queue: Ben Segall <bentekkie@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Bug: b/288285261
Change-Id: I7b262f63d4edd68447fcec0a781ef55923635d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4651968
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
This commit is contained in:
@@ -165,12 +165,6 @@ def set_reproxy_path_flags(out_dir, make_dirs=True):
|
||||
hashlib.sha256(tmp_dir.encode()).hexdigest())
|
||||
|
||||
|
||||
def enable_racing():
|
||||
os.environ.setdefault("RBE_exec_strategy", "racing")
|
||||
# TODO(b/288285261) Tune bias once latency data has been gathered.
|
||||
os.environ.setdefault("RBE_racing_bias", "0.95")
|
||||
|
||||
|
||||
@contextlib.contextmanager
|
||||
def build_context(argv, tool):
|
||||
# If use_remoteexec is set, but the reclient binaries or configs don't
|
||||
@@ -204,8 +198,6 @@ def build_context(argv, tool):
|
||||
print('WARNING: Using RBE_instance=%s\n' %
|
||||
os.environ.get('RBE_instance', ''))
|
||||
|
||||
enable_racing()
|
||||
|
||||
reproxy_ret_code = start_reproxy(reclient_cfg, reclient_bin_dir)
|
||||
if reproxy_ret_code != 0:
|
||||
yield reproxy_ret_code
|
||||
|
||||
Reference in New Issue
Block a user