Albin Kerouanton 40adb4317b api: Remove duplicated check on CheckDuplicate ...

Partially revert commit 94b880f.

The CheckDuplicate field has been introduced in commit 2ab94e1. At that
time, this check was done in the network router. It was then moved to
the daemon package in commit 3ca2982. However, commit 94b880f duplicated
the logic into the network router for no apparent reason. Finally,
commit ab18718 made sure a 409 would be returned instead of a 500.

As this logic is first done by the daemon, the error -> warning
conversion can't happen because CheckDuplicate has to be true for the
daemon package to return an error. If it's false, the daemon proceed
with the network creation, set the Warning field of its return value and
return no error.

Thus, the CheckDuplicate logic in the api is removed and
libnetwork.NetworkNameError now implements the ErrConflict interface.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>

2023-08-08 10:00:02 +02:00

..

backend/build

api/server: format code with gofumpt

2023-06-29 00:25:20 +02:00

httpstatus

swap logrus types for their containerd/logs aliases

2023-08-01 13:02:55 +02:00

httputils

chore: use http constants to replace numbers

2023-02-21 23:02:56 +08:00

middleware

Switch all logging to use containerd log pkg

2023-06-24 00:23:44 +00:00

router

api: Remove duplicated check on CheckDuplicate

2023-08-08 10:00:02 +02:00

errorhandler.go

errdefs: move GetHTTPErrorStatusCode to api/server/httpstatus

2022-03-21 12:22:39 +01:00

middleware.go

swap logrus types for their containerd/logs aliases

2023-08-01 13:02:55 +02:00

server_test.go

api/server: drop unused Config struct

2023-02-28 13:49:53 -05:00

server.go

Switch all logging to use containerd log pkg

2023-06-24 00:23:44 +00:00