Cory Snider be39be87f6 api/server: delete Wait method ...

It's surprising that the method to begin serving requests is named Wait.
And it is unidiomatic: it is a synchronous call, but it sends its return
value to the channel passed in as an argument instead of just returning
the value. And ultimately it is just a trivial wrapper around serveAPI.
Export the ServeAPI method instead so callers can decide how to call and
synchronize around it.

Call ServeAPI synchronously on the main goroutine in cmd/dockerd. The
goroutine and channel which the Wait() API demanded are superfluous
after all. The notifyReady() call was always concurrent and asynchronous
with respect to serving the API (its implementation spawns a goroutine)
so it makes no difference whether it is called before ServeAPI() or
after `go ServeAPI()`.

Signed-off-by: Cory Snider <csnider@mirantis.com>

2023-03-01 09:03:34 -05:00

..

docker-proxy

cmd/docker-proxy: add "-v / --version" flag

2022-12-27 22:26:57 +01:00

dockerd

api/server: delete Wait method

2023-03-01 09:03:34 -05:00