Albin Kerouanton ac8b4e3e75 daemon: handleContainerExit: ignore networking errors ...

Prior to commit fe856b9, containers' network sandbox and interfaces were
created before the containerd task. Now, it's created after.

If this step fails, the containerd task is forcefully deleted, and an
event is sent to the c8d event monitor, which triggers `handleContainerExit`.
Then this method tries to restart the faulty container.

This leads to containers with a published port already in use to be
stuck in a tight restart loop (if they're started with
`--restart=always`) until the port is available. This is needlessly
spamming the daemon logs.

Prior to that commit, a published port already in use wouldn't trigger
the restart process.

This commit adds a check to `handleContainerExit` to ignore exit events
if the latest container error is related to networking setup.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>

2025-02-20 18:03:20 +01:00

..

cluster

daemon/cluster/executor/container: make switches exhaustive (exhaustive)

2025-02-09 13:22:52 +01:00

config

daemon: use structured logs for printing reloaded config, move to cli

2025-02-14 12:22:10 +01:00

containerd

c8d/list: Fix panic when listing images

2025-02-18 12:23:50 +01:00

events

daemon/events: make switches exhaustive (exhaustive)

2025-02-09 13:22:52 +01:00

graphdriver

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

images

Implement mount from image

2025-01-31 10:34:27 -05:00

initlayer

remove some remaining pre-go1.17 build-tags

2023-08-24 17:51:07 +02:00

internal

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

links

daemon/links: fix duplicate env-vars and cleanup range-detection

2025-01-20 11:52:41 +01:00

listeners

Update internal use of idtools to usergroup

2025-01-07 11:18:46 -08:00

logger

daemon/logger/splunk: New(): combine switches for format validation

2025-02-15 20:52:49 +01:00

names

daemon/names: use lazyregexp

2025-01-02 21:37:35 +01:00

network

runconfig: deprecate IsPreDefinedNetwork

2024-06-20 11:10:54 +02:00

snapshotter

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

stats

api/types: move stats-types to api/types/container

2024-06-20 10:21:42 +02:00

testdata

…

apparmor_default_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

apparmor_default.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

archive_tarcopyoptions_unix.go

Fix parsing of user/group during copy operation

2025-01-20 12:45:29 +01:00

archive_tarcopyoptions.go

Finish refactor of UID/GID usage to a new struct

2022-03-14 16:28:57 -04:00

archive_unix.go

daemon: containerExtractToDir: combine checks for read-only target

2025-01-16 20:58:10 +01:00

archive_windows.go

daemon: containerExtractToDir: remove handling for read-only paths on windows

2025-01-16 20:58:15 +01:00

archive.go

daemon: don't discard "invalid parameter" errors for archive endpoints

2025-01-16 20:58:32 +01:00

attach.go

Logfile: Add tracing spans

2024-07-22 19:20:12 +00:00

auth.go

daemon: use types/registry.AuthConfig

2022-07-29 23:05:18 +02:00

build.go

daemon: ImageService.LogImageEvent: pass through context

2025-01-08 15:43:17 +01:00

cdi.go

Merge pull request #48771 from thaJeztah/cdi_noshadow

2024-10-28 10:30:23 +01:00

changes.go

daemon/metrics: Move out to internal/metrics

2025-01-07 14:13:06 +01:00

checkpoint.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

cluster.go

api/types: migrate NetworkResource to api/types/network

2024-06-04 17:44:46 +02:00

commit.go

daemon/metrics: Move out to internal/metrics

2025-01-07 14:13:06 +01:00

configs.go

daemon: remove configsSupported utility

2024-10-20 14:04:07 +02:00

container_linux.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

container_operations_test.go

Unconditionally update NetworkSettings

2024-11-05 10:00:10 +00:00

container_operations_unix.go

daemon: remove Daemon.children(), Daemon.parents() wrappers

2025-01-30 14:23:10 +01:00

container_operations_windows.go

Remove function isLinkable

2024-11-05 14:22:53 +00:00

container_operations.go

daemon: handleContainerExit: ignore networking errors

2025-02-20 18:03:20 +01:00

container_unix_test.go

remove more direct uses of logrus

2023-09-15 20:12:27 +02:00

container_windows.go

daemon: fix capitalization of some functions

2020-04-14 17:22:19 +02:00

container.go

Add experimental feature warning for image mount

2025-02-12 09:59:59 -05:00

containerfs_linux.go

Fix typos

2024-09-06 21:53:09 +10:00

content.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

create_unix.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

create_windows.go

volumes/subpath: Plumb context

2024-01-19 17:32:21 +01:00

create.go

c8d: Implement RWLayer and remove PrepareSnapshot

2025-01-09 17:31:20 +01:00

daemon_linux_test.go

Separate IPv4 IPAM conf from the rest of default bridge conf

2024-11-25 18:28:37 +00:00

daemon_linux.go

daemon/daemon_linux.go: Fix a minor typo

2024-12-03 08:59:00 +08:00

daemon_test.go

daemon: add ULA prefix by default

2024-05-29 22:38:27 +02:00

daemon_unix_test.go

daemon/&container/: enable --security-opt writable-cgroups=true as an option

2025-01-16 12:58:17 -08:00

daemon_unix.go

daemon: configureMaxThreads: remove unused arg

2025-02-07 02:24:31 +01:00

daemon_unsupported.go

Revert "Internal resolver for default bridge network"

2024-06-17 20:19:20 +01:00

daemon_windows_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

daemon_windows.go

daemon: configureMaxThreads: remove unused arg

2025-02-07 02:24:31 +01:00

daemon.go

daemon: configureMaxThreads: remove unused arg

2025-02-07 02:24:31 +01:00

debugtrap_unix.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

debugtrap_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

debugtrap_windows.go

migrate to github.com/containerd/log v0.1.0

2023-10-11 17:52:23 +02:00

delete_test.go

daemon: remove redundant capturing of loop vars (copyloopvar)

2024-11-12 14:02:15 +01:00

delete.go

daemon: Daemon.rmLink: don't fuzzy-match container when using ID

2025-01-30 11:39:19 +01:00

dependency.go

Bump swarmkit to v2

2022-04-21 17:33:07 -04:00

devices.go

remove redundant alias for runtime-spec

2024-10-26 18:31:39 +02:00

disk_usage.go

API: add Platform (OS and Architecture) to /containers/json

2025-02-13 14:52:21 -06:00

errors_test.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

errors.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

events_test.go

api/types/events: define "Action" type and consts

2023-08-29 00:38:08 +02:00

events.go

daemon: eventTimestamp: make switch exhaustive (exhaustive)

2025-02-09 13:22:51 +01:00

exec_linux_test.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

exec_linux.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

exec_windows.go

container: Add ImagePlatform field and deprecate OS

2024-11-19 13:55:54 +01:00

exec.go

daemon: make daemon.getEntrypointAndArgs a regular function

2025-01-26 14:37:08 +01:00

export.go

daemon/export: Stop when context is canceled

2025-01-13 16:34:41 +01:00

health_test.go

api/types: move container Health types to api/types/container

2024-07-02 12:46:47 +02:00

health.go

Merge pull request #49337 from thaJeztah/simplify_health_getshell

2025-01-27 15:55:56 +00:00

hosts_test.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

hosts.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

id.go

pkg/ioutils: move atomic file-writers to a separate (pkg/atomicwriter) package

2025-01-08 10:36:32 +01:00

image_service.go

Implement mount from image

2025-01-31 10:34:27 -05:00

info_unix_test.go

daemon: remove redundant capturing of loop vars (copyloopvar)

2024-11-12 14:02:15 +01:00

info_unix.go

Revert "libnet/d/bridge: port mappings: filter by input iface"

2025-01-20 14:11:51 +01:00

info_windows.go

Remove feature flag "windows-dns-proxy"

2024-10-24 11:19:42 +01:00

info.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

inspect_linux.go

api/types/container: InspectResponse: keep old name for embedded type

2024-07-03 17:14:03 +02:00

inspect_test.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

inspect_windows.go

api/types/container: InspectResponse: keep old name for embedded type

2024-07-03 17:14:03 +02:00

inspect.go

daemon: remove Daemon.children(), Daemon.parents() wrappers

2025-01-30 14:23:10 +01:00

keys_unsupported.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

keys.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

kill.go

daemon: killWithSignal: use more structured logs

2024-10-15 22:40:39 +02:00

licensing_test.go

api/types: move system info types to api/types/system

2023-07-07 13:01:36 +02:00

licensing.go

api/types: move system info types to api/types/system

2023-07-07 13:01:36 +02:00

links.go

…

list_test.go

tests: migrate away from assert.Assert(err == nil)

2024-11-22 23:59:20 +11:00

list_unix.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

list_windows.go

pkg/containerfs: alias ContainerFS to string

2022-09-23 16:56:52 -04:00

list.go

daemon: Daemon.Containers: make switches exhaustive (exhaustive)

2025-02-09 13:22:53 +01:00

logdrivers_linux.go

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

logdrivers_windows.go

logger: remove logentries driver

2023-12-12 22:51:23 +01:00

logs_test.go

…

logs.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

migration_test.go

daemon: gofumpt code

2024-11-28 10:03:46 +01:00

migration.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

monitor.go

daemon: handleContainerExit: ignore networking errors

2025-02-20 18:03:20 +01:00

mounts.go

Implement image mount for the snapshotter

2025-01-31 10:34:27 -05:00

names.go

Merge pull request #48669 from thaJeztah/daemon_fix_restore

2024-10-18 12:59:08 +02:00

network_windows.go

libnetwork: remove Network interface

2023-07-22 11:56:41 +02:00

network.go

Create bridge veth in container netns

2025-01-24 18:43:51 +00:00

nvidia_linux.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

oci_linux_test.go

libnetwork: share a single datastore with drivers

2024-01-31 21:08:34 -05:00

oci_linux.go

Error on invalid requests for writable-cgroups

2025-01-16 15:59:06 -08:00

oci_opts.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

oci_utils.go

remove redundant alias for runtime-spec

2024-10-26 18:31:39 +02:00

oci_windows_test.go

tests: migrate away from assert.Assert(v == nil)

2024-11-22 23:59:20 +11:00

oci_windows.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

pause.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

prune.go

daemon: use lazyregexp to compile regexes on first use

2025-01-02 21:37:33 +01:00

reload_test.go

remove support for non-distributable artifacts and deprecate API fields and config

2024-12-11 20:29:46 +01:00

reload_unix.go

daemon: consolidate runtimes config validation

2023-06-01 14:45:25 -04:00

reload_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

reload.go

daemon: use structured logs for printing reloaded config, move to cli

2025-02-14 12:22:10 +01:00

rename.go

daemon: rename some inconsistent import aliases

2024-06-17 14:50:09 +02:00

resize_test.go

api: backend.ContainerExecResize: pass context and use uint32 for width, height

2024-10-17 14:04:37 +02:00

resize.go

api: backend.ContainerExecResize: pass context and use uint32 for width, height

2024-10-17 14:04:37 +02:00

restart.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

runtime_unix_test.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

runtime_unix.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

runtime_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

seccomp_linux_test.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

seccomp_linux.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

seccomp_unsupported.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

secrets.go

daemon: remove secretsSupported utility

2024-10-20 14:10:17 +02:00

start_linux.go

daemon: handleContainerExit: ignore networking errors

2025-02-20 18:03:20 +01:00

start_notlinux.go

Configure network endpoints after creating a container

2024-11-05 10:01:49 +00:00

start_unix.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

start_windows.go

Windows: Run containerd as managed process

2024-11-06 21:04:31 +03:00

start.go

Update to containerd v2.0.2, buildkit v0.19.0-rc2

2025-01-15 14:09:30 +01:00

stats_collector.go

pkg/sysinfo: move MemInfo and ReadMemInfo to a separate package

2023-03-15 17:52:45 +01:00

stats_unix.go

api/types/container: merge Stats and StatsResponse

2025-01-16 19:47:40 +01:00

stats_windows.go

api/types/container: merge Stats and StatsResponse

2025-01-16 19:47:40 +01:00

stats.go

api/types: move stats-types to api/types/container

2024-06-20 10:21:42 +02:00

stop.go

remove internal/compatcontext and use context instead

2024-06-13 13:29:39 +02:00

top_unix_test.go

daemon: remove redundant capturing of loop vars (copyloopvar)

2024-11-12 14:02:15 +01:00

top_unix.go

api/types/container: rename ContainerTopOKBody to TopResponse

2025-02-10 18:58:31 +01:00

top_windows.go

api/types/container: rename ContainerTopOKBody to TopResponse

2025-02-10 18:58:31 +01:00

unpause.go

container: add a span to CheckpointTo

2024-06-14 15:25:07 +02:00

update_linux_test.go

daemon: stop setting container resources to zero

2023-06-06 12:13:05 -04:00

update_linux.go

remove redundant alias for runtime-spec

2024-10-26 18:31:39 +02:00

update_windows.go

Windows: Experimental: Allow containerd for runtime

2019-03-12 18:41:55 -07:00

update.go

api/types/container: rename ContainerUpdateOKBody to UpdateResponse

2025-02-10 18:35:35 +01:00

volumes_linux_test.go

daemon: rename variables that collide with imported package names

2020-04-14 17:22:23 +02:00

volumes_linux.go

Fix the several typos detected by github.com/client9/misspell

2018-08-09 00:45:00 +09:00

volumes_unit_test.go

volume/mounts: remove "containerOS" argument from NewParser (LCOW code)

2021-07-02 13:51:55 +02:00

volumes_unix.go

daemon: setupMounts: rename var that shadowed import

2024-07-26 13:50:45 +02:00

volumes_windows.go

daemon: move sortMounts to a platform-agnostic file

2024-07-26 13:50:13 +02:00

volumes.go

Implement mount from image

2025-01-31 10:34:27 -05:00

wait.go

Switch from x/net/context -> context

2018-04-23 13:52:44 -07:00

workdir.go

Add ADD/COPY --chown flag support to Windows

2018-08-13 21:59:11 -07:00