Sebastiaan van Stijn a327a9f341 integration-cli: fix flaky TestRestartStoppedContainer ...

This test was failing frequently on Windows, waiting for the state
of the container to be "running" after restarting, however, this
would race because the command of the container was very short-lived;

    === Failed
    === FAIL: github.com/docker/docker/integration-cli TestDockerCLIRestartSuite/TestRestartStoppedContainer (37.00s)
        docker_cli_restart_test.go:42: assertion failed: error is not nil: condition ""true" == "false"" not true in time (20s)

Ironically, that check was added in 48ccdd46ae
to make the test less flaky.

This patch takes the approach from TestRestartRunningContainer, which had
similar issues on Windows that were addressed in bae22d167c

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2025-07-12 17:45:27 +02:00

..

checker

integration-cli: remove // import comments

2025-05-30 15:59:13 +02:00

cli

integration-cli: remove // import comments

2025-05-30 15:59:13 +02:00

daemon

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

environment

integration-cli: remove // import comments

2025-05-30 15:59:13 +02:00

fixtures

integration-cli: fix test rogue certs

2022-05-19 10:54:31 +02:00

requirement

integration-cli: remove // import comments

2025-05-30 15:59:13 +02:00

testdata

Clean some integration-cli/fixtures package/files

2018-04-16 10:48:58 +02:00

benchmark_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

check_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

daemon_swarm_hack_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_attach_test.go

integration-cli: fix some unhandled errors

2025-03-20 20:20:22 +01:00

docker_api_build_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_build_windows_test.go

Wire up tests to support otel tracing

2023-09-07 18:38:22 +00:00

docker_api_containers_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_api_containers_unix_test.go

fix some leaking mounts in tests

2024-01-22 21:43:23 +01:00

docker_api_containers_windows_test.go

all: remove redundant import-aliases for "go-winio"

2025-06-05 12:11:30 +02:00

docker_api_exec_resize_test.go

fix comparison rule from errorlint

2025-06-13 08:26:56 +00:00

docker_api_exec_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_images_test.go

fix stringsCompare and stringConcatSimplify from go-critic

2025-06-07 09:57:59 +02:00

docker_api_inspect_test.go

fix emptyStringTest from go-critic

2025-06-07 09:57:59 +02:00

docker_api_logs_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_network_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_stats_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_swarm_node_test.go

Wire up tests to support otel tracing

2023-09-07 18:38:22 +00:00

docker_api_swarm_service_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_swarm_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_api_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_attach_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_cli_attach_unix_test.go

integration-cli: avoid allocations with (*os.File).WriteString (mirror)

2025-02-09 13:22:46 +01:00

docker_cli_build_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_cli_build_unix_test.go

api/types/container: provide alias for github.com/docker/go-units.Ulimit

2024-06-18 13:18:20 +02:00

docker_cli_by_digest_test.go

integration-cli: TestPullFailsWithAlteredLayer: use OCI manifest

2025-07-05 17:56:35 +02:00

docker_cli_commit_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_cp_from_container_test.go

integration-cli: format code with gofumpt

2023-06-29 00:08:27 +02:00

docker_cli_cp_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_cp_to_container_test.go

integration-cli: remove isCpCannotCopyReadOnly utility

2022-09-27 22:15:19 +02:00

docker_cli_cp_to_container_unix_test.go

integration-cli: DockerCLICpSuite: replace dockerCmd

2023-10-19 17:52:44 +02:00

docker_cli_cp_utils_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_create_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_daemon_plugins_test.go

fix comparison rule from errorlint

2025-06-13 08:26:56 +00:00

docker_cli_daemon_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_events_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_events_unix_test.go

integration-cli: remove uses of deprecated dockerCmdWithResult utility

2025-06-30 13:21:30 +02:00

docker_cli_exec_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_cli_exec_unix_test.go

integration-cli: avoid allocations with (*os.File).WriteString (mirror)

2025-02-09 13:22:46 +01:00

docker_cli_external_volume_driver_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_cli_health_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_history_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_images_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_import_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_info_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_info_unix_test.go

Wire up tests to support otel tracing

2023-09-07 18:38:22 +00:00

docker_cli_inspect_test.go

integration-cli: remove uses of deprecated dockerCmdWithResult utility

2025-06-30 13:21:30 +02:00

docker_cli_links_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_login_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_logout_test.go

fix sprintfQuotedString from go-critic

2025-06-07 09:57:59 +02:00

docker_cli_logs_test.go

fix emptyStringTest from go-critic

2025-06-07 09:57:59 +02:00

docker_cli_netmode_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_network_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_network_unix_test.go

integration-cli: remove uses of deprecated dockerCmdWithResult utility

2025-06-30 13:21:30 +02:00

docker_cli_plugins_logdriver_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_plugins_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_port_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_cli_proxy_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_prune_test.go

integration-cli: split DockerSuite into subsequent build suites

2022-06-17 10:59:04 +02:00

docker_cli_prune_unix_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_ps_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_pull_local_test.go

integration-cli: TestPullManifestList: use OCI media-types

2025-07-05 17:48:48 +02:00

docker_cli_pull_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_push_test.go

integration-cli: debug TestPushToCentralRegistryUnauthorized

2025-06-30 15:44:52 +02:00

docker_cli_registry_user_agent_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_restart_test.go

integration-cli: fix flaky TestRestartStoppedContainer

2025-07-12 17:45:27 +02:00

docker_cli_rmi_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_run_test.go

integration-cli: remove uses of deprecated dockerCmdWithResult utility

2025-06-30 13:21:30 +02:00

docker_cli_run_unix_test.go

fix(QF1001): Apply De Morgan’s law

2025-05-01 14:16:44 +02:00

docker_cli_save_load_test.go

image/tarexport: remove suport for loading v0/v1 images

2025-07-04 11:48:52 +02:00

docker_cli_save_load_unix_test.go

tests: migrate strings.Contains -> is.Contains in assertions

2024-11-22 23:59:20 +11:00

docker_cli_search_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_service_create_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_service_health_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_service_logs_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_service_scale_test.go

Wire up tests to support otel tracing

2023-09-07 18:38:22 +00:00

docker_cli_sni_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_start_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_stats_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_swarm_test.go

fix use-errors-new from revive

2025-06-26 12:07:38 +00:00

docker_cli_swarm_unix_test.go

rename "image" vars to prevent conflicts with imports

2024-01-19 12:49:53 +01:00

docker_cli_top_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_update_test.go

integration-cli: split DockerSuite into subsequent build suites

2022-06-17 10:59:04 +02:00

docker_cli_update_unix_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_userns_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_cli_v2_only_test.go

fix usestdlibvars

2025-05-15 18:24:58 +02:00

docker_cli_volume_test.go

integration-cli: remove uses of deprecated dockerCmdWithResult utility

2025-06-30 13:21:30 +02:00

docker_hub_pull_suite_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

docker_utils_test.go

integration-cli: remove uses of deprecated dockerCmdWithResult utility

2025-06-30 13:21:30 +02:00

events_utils_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

fixtures_linux_daemon_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

requirements_test.go

Remove DockerSchema1RegistrySuite schema 2 version 1 tests

2025-05-16 18:00:06 +02:00

requirements_unix_test.go

Remove/replace integration-cli tests that use iptables directly

2025-05-12 17:51:59 +01:00

requirements_windows_test.go

Run CLI tests with cgroups v2

2025-04-09 11:05:14 -07:00

test_vars_test.go

testutil/environment: remove Execution.OSType field

2023-06-26 11:18:09 +02:00

test_vars_unix_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

test_vars_windows_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

utils_test.go

fix thelper linter

2025-06-05 21:42:05 +00:00

utils_unix_test.go

remove pre-go1.17 build-tags

2023-05-19 20:38:51 +02:00

utils_windows_test.go

pkg/system: move GetLongPathName to integration-cli

2022-11-29 17:02:53 +01:00