mirror of
https://github.com/moby/moby.git
synced 2026-01-11 10:41:43 +00:00
9b749d7c85
Migrate TestAPIStatsContainerNotFound from the deprecated integration-cli test suite to the modern integration test framework in integration/container. The test verifies that the container stats API returns a NotFound error for non-existent containers, testing both streaming and non-streaming modes. Changes made: - Migrated test to integration/container/stats_test.go using standard Go testing patterns - Refactored to use test array pattern for better test organization - Removed test from integration-cli/docker_api_stats_test.go - Removed unused imports from integration-cli file - Removed Windows skip as it may not be necessary Signed-off-by: Salim Dohri <dohri.salim@gmail.com>
96 lines
2.5 KiB
Go
96 lines
2.5 KiB
Go
package container
|
|
|
|
import (
|
|
"encoding/json"
|
|
"io"
|
|
"reflect"
|
|
"testing"
|
|
|
|
cerrdefs "github.com/containerd/errdefs"
|
|
containertypes "github.com/moby/moby/api/types/container"
|
|
"github.com/moby/moby/client"
|
|
"github.com/moby/moby/v2/integration/internal/container"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
"gotest.tools/v3/skip"
|
|
)
|
|
|
|
func TestStats(t *testing.T) {
|
|
skip.If(t, testEnv.DaemonInfo.CgroupDriver == "none")
|
|
skip.If(t, !testEnv.DaemonInfo.MemoryLimit)
|
|
|
|
ctx := setupTest(t)
|
|
apiClient := testEnv.APIClient()
|
|
|
|
result, err := apiClient.Info(ctx, client.InfoOptions{})
|
|
assert.NilError(t, err)
|
|
|
|
info := result.Info
|
|
cID := container.Run(ctx, t, apiClient)
|
|
t.Run("no-stream", func(t *testing.T) {
|
|
resp, err := apiClient.ContainerStats(ctx, cID, client.ContainerStatsOptions{
|
|
Stream: false,
|
|
IncludePreviousSample: true,
|
|
})
|
|
assert.NilError(t, err)
|
|
defer func() { _ = resp.Body.Close() }()
|
|
|
|
var v containertypes.StatsResponse
|
|
err = json.NewDecoder(resp.Body).Decode(&v)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(int64(v.MemoryStats.Limit), info.MemTotal))
|
|
assert.Check(t, !reflect.DeepEqual(v.PreCPUStats, containertypes.CPUStats{}))
|
|
err = json.NewDecoder(resp.Body).Decode(&v)
|
|
assert.Assert(t, is.ErrorIs(err, io.EOF))
|
|
})
|
|
|
|
t.Run("one-shot", func(t *testing.T) {
|
|
resp, err := apiClient.ContainerStats(ctx, cID, client.ContainerStatsOptions{
|
|
Stream: false,
|
|
IncludePreviousSample: false,
|
|
})
|
|
assert.NilError(t, err)
|
|
defer func() { _ = resp.Body.Close() }()
|
|
|
|
var v containertypes.StatsResponse
|
|
err = json.NewDecoder(resp.Body).Decode(&v)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(int64(v.MemoryStats.Limit), info.MemTotal))
|
|
assert.Check(t, reflect.DeepEqual(v.PreCPUStats, containertypes.CPUStats{}))
|
|
err = json.NewDecoder(resp.Body).Decode(&v)
|
|
assert.Assert(t, is.ErrorIs(err, io.EOF))
|
|
})
|
|
}
|
|
|
|
func TestStatsContainerNotFound(t *testing.T) {
|
|
ctx := setupTest(t)
|
|
apiClient := testEnv.APIClient()
|
|
|
|
tests := []struct {
|
|
name string
|
|
options client.ContainerStatsOptions
|
|
}{
|
|
{
|
|
name: "with stream",
|
|
options: client.ContainerStatsOptions{
|
|
Stream: true,
|
|
},
|
|
},
|
|
{
|
|
name: "without stream",
|
|
options: client.ContainerStatsOptions{
|
|
Stream: false,
|
|
IncludePreviousSample: true,
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
_, err := apiClient.ContainerStats(ctx, "no-such-container", tc.options)
|
|
assert.ErrorType(t, err, cerrdefs.IsNotFound)
|
|
assert.ErrorContains(t, err, "no-such-container")
|
|
})
|
|
}
|
|
}
|