InTheForest/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2026-01-11 18:51:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
70004549fbfa2e1c7ac43e79ffe89f8d0cb416fd
moby/daemon
History
Jan Scheffler 70004549fb layer: Fix orphan creation in registerWithDescriptor 
Start the metadata transaction before creating the overlay2 directory.
This ensures that if driver.Create() fails, we can properly cancel the
transaction. Previously, if StartTransaction() failed after driver.Create()
succeeded, the defer cleanup would not run (not registered yet), leaving
an orphaned overlay2 directory.

The fix reorders operations so that:
1. Transaction is started first (no filesystem changes yet)
2. Overlay2 directory is created second (transaction ready for cleanup)
3. Defer is registered after both succeed (tx is guaranteed non-nil)

If driver.Create() fails, the transaction is explicitly cancelled before
returning. The nil check for tx in the defer is no longer needed since
tx is guaranteed to exist when the defer runs.

Related to moby/moby#45939

Signed-off-by: Jan Scheffler <jan.scheffler@qodev.ai>
2025-12-12 09:44:04 +00:00
..
builder
api/pkg/progress: move to client and daemon/internal
2025-10-24 07:56:57 -05:00
cluster
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
command
NRI: add daemon.json/command line options
2025-12-05 15:19:33 +00:00
config
NRI: add daemon.json/command line options
2025-12-05 15:19:33 +00:00
container
api/types/container: make HealthStatus a concrete type
2025-11-10 16:08:15 +01:00
containerd
Merge pull request #51423 from thaJeztah/cleanup_token_errs
2025-12-03 12:29:18 +01:00
events
daemon: close EventsService on shutdown
2025-11-09 22:38:59 +01:00
graphdriver
graphdriver/windows: Potential fix for access denied
2025-09-01 16:16:28 +02:00
images
system: df: fix SharedUsage on non-containerd
2025-12-01 16:45:38 +01:00
initlayer
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
internal
layer: Fix orphan creation in registerWithDescriptor
2025-12-12 09:44:04 +00:00
libnetwork
libnetwork/options: GenerateFromModel: use generics
2025-12-10 01:48:48 +01:00
links
api: move container port type to network package
2025-10-03 17:30:42 -05:00
listeners
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
logger
fix some faulty defers in tests
2025-10-27 12:39:21 +01:00
names
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
network
api/t/network: represent MAC addrs as byte slices
2025-10-30 17:11:38 -04:00
pkg
NRI: add daemon.json/command line options
2025-12-05 15:19:33 +00:00
server
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
snapshotter
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
stats
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
testdata
Improve CPU usage parsing and error reporting
2025-04-07 16:19:02 +02:00
volume
api/types/volume: change ListResponse.Volumes to a non-pointer slice
2025-11-10 13:13:22 +01:00
apparmor_default_unsupported.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
apparmor_default.go
profiles/apparmor, seccomp: migrate to separate module
2025-07-22 18:48:39 +02:00
archive_tarcopyoptions_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
archive_tarcopyoptions.go
daemon: ContainerExtractToDir: make AllowOverwriteDirWithFile opt-in
2025-07-13 16:37:36 +02:00
archive_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
archive_windows.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
archive.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
attach.go
api/pkg/stdcopy: move stdWriter to daemon/internal
2025-10-09 20:13:26 -04:00
auth.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
build.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
cdi.go
chore: use errors.Join instead of github.com/hashicorp/go-multierror
2025-08-08 19:19:21 +02:00
changes.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
checkpoint.go
api/types/checkpoint: move checkpoint options to client
2025-09-05 10:20:06 +02:00
cluster.go
daemon: report IPAM status for Swarm networks
2025-09-11 15:25:14 -04:00
commit.go
client: add option and output structs for various container methods
2025-10-27 23:46:28 +01:00
configs.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
container_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
container_operations_test.go
Allow configured address with no configured subnet
2025-11-24 14:14:27 +00:00
container_operations_unix.go
api/types/network: use netip types as appropriate
2025-10-03 21:39:14 +02:00
container_operations_windows.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
container_operations.go
Allow configured address with no configured subnet
2025-11-24 14:14:27 +00:00
container_unix_test.go
api: move container port type to network package
2025-10-03 17:30:42 -05:00
container_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
container.go
Daemon.setSecurityOptions: remove redundant param
2025-11-16 18:25:06 +00:00
containerfs_linux_test.go
pkg/fileutils: move ReadSymlinkedDirectory internal to daemon
2025-07-29 11:16:25 +02:00
containerfs_linux.go
chore: use errors.Join instead of github.com/hashicorp/go-multierror
2025-08-08 19:19:21 +02:00
content.go
fix duplicate import, and force consistent alias for bolt
2025-04-22 11:31:10 +02:00
create_unix.go
Daemon.createContainerOSSpecificSettings - remove redundant param
2025-11-16 18:25:42 +00:00
create_windows.go
Daemon.createContainerOSSpecificSettings - remove redundant param
2025-11-16 18:25:42 +00:00
create.go
NRI: add ContainerCreate hook, allow env-var adjustments
2025-12-10 10:30:44 +00:00
daemon_linux_test.go
internal/testutils: merge with internal/testutil
2025-09-08 10:08:35 +02:00
daemon_linux.go
daemon/libnetwork/resolvconf: remove unused code
2025-08-01 14:48:05 +02:00
daemon_test.go
api: move container port type to network package
2025-10-03 17:30:42 -05:00
daemon_unix_test.go
daemon: use errdefs instead of string-matching in some places
2025-10-25 16:13:30 +02:00
daemon_unix.go
Merge pull request #51587 from robmry/unmap_ipv6_addr
2025-11-25 19:30:27 +00:00
daemon_unsupported.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
daemon_windows_test.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
daemon_windows.go
Move call to Daemon.registerLinks out of Daemon.setHostConfig
2025-11-16 18:20:12 +00:00
daemon.go
NRI: instantiate and start/stop NRI adaptation
2025-12-08 16:11:59 +00:00
debugtrap_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
debugtrap_unsupported.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
debugtrap_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
delete_test.go
daemon/container: remove NewState() constructor
2025-09-19 15:33:36 +01:00
delete.go
api/types/container: make ContainerState a concrete type
2025-11-10 16:08:12 +01:00
dependency.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
devices_amd_linux.go
Added support for AMD GPUs in "docker run --gpus".
2025-06-05 14:44:18 +00:00
devices_nvidia_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
devices.go
Match device driver on name and ignore capabilities
2025-08-13 16:59:39 +02:00
disk_usage.go
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
errors_test.go
daemon: cleanupContainer: don't fail if container is already stopped
2023-08-23 15:47:43 +02:00
errors.go
daemon: use errdefs instead of string-matching in some places
2025-10-25 16:13:30 +02:00
events_test.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
events.go
api/types/filters: move to daemon/internal
2025-10-08 12:06:26 -04:00
exec_linux_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
exec_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
exec_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
exec.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
export.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
health_test.go
explicitly access Container.State.Health.Health
2025-09-19 15:33:36 +01:00
health.go
api/types/container: make HealthStatus a concrete type
2025-11-10 16:08:15 +01:00
hosts_test.go
image: pull/load/save attestation manifest and signatures with image
2025-11-12 07:53:46 -08:00
hosts.go
image: pull/load/save attestation manifest and signatures with image
2025-11-12 07:53:46 -08:00
id.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
image_service.go
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
image_store_choice_test.go
daemon: Fix image store choice priority for prior graphdriver state
2025-11-13 10:05:49 +01:00
image_store_choice.go
daemon: Fix image store choice priority for prior graphdriver state
2025-11-13 10:05:49 +01:00
info_unix_test.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
info_unix.go
Deprecate cgroup v1
2025-10-31 17:00:33 +09:00
info_windows.go
api/types: move Version to api/types/system
2025-10-31 02:09:38 +01:00
info.go
api/types: move Version to api/types/system
2025-10-31 02:09:38 +01:00
inspect_linux.go
api/types/container: merge InspectResponse and ContainerJSONBase
2025-08-26 20:18:57 +02:00
inspect_test.go
daemon: Daemon.getInspectData: move migration code to router
2025-10-21 09:15:18 +02:00
inspect_windows.go
api/types/container: merge InspectResponse and ContainerJSONBase
2025-08-26 20:18:57 +02:00
inspect.go
api/types/container: make ContainerState a concrete type
2025-11-10 16:08:12 +01:00
keys_unsupported.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
keys.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
kill.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
licensing_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
licensing.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
links.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
list_test.go
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
list_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
list_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
list.go
daemon: reduce use of pointer-slices in backend
2025-11-13 20:52:15 +01:00
logdrivers_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
logdrivers_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
logs_test.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
logs.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
migration_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
migration.go
daemon/server: move GetImageOpts, ImageInspectOpts to imagebackend
2025-10-05 13:41:22 +02:00
monitor.go
api/types/container: make ContainerState a concrete type
2025-11-10 16:08:12 +01:00
mounts.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
names.go
Move namesgenerator to internal
2025-10-30 19:41:58 +01:00
network_test.go
api/types/network: use netip types as appropriate
2025-10-03 21:39:14 +02:00
network_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
network.go
Merge pull request #51587 from robmry/unmap_ipv6_addr
2025-11-25 19:30:27 +00:00
oci_linux_test.go
daemon: use t.Context() in tests
2025-09-25 22:53:48 +02:00
oci_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_opts.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_utils.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_windows_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
oci_windows.go
daemon/server: move GetImageOpts, ImageInspectOpts to imagebackend
2025-10-05 13:41:22 +02:00
pause.go
daemon: use errdefs instead of string-matching in some places
2025-10-25 16:13:30 +02:00
prune.go
client: singularize prune methods
2025-11-05 15:48:02 +01:00
reload_test.go
daemon: use t.Context() in tests
2025-09-25 22:53:48 +02:00
reload_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
reload_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
reload.go
chore: use errors.Join instead of github.com/hashicorp/go-multierror
2025-08-08 19:19:21 +02:00
rename.go
daemon: improve validation for container rename
2025-10-29 18:42:36 +01:00
resize_test.go
daemon: use t.Context() in tests
2025-09-25 22:53:48 +02:00
resize.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
restart.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
runtime_unix_test.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
runtime_unix.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
runtime_windows.go
chore: enable use-any rule from revive
2025-08-08 17:07:07 +02:00
seccomp_linux_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
seccomp_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
seccomp_unsupported.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
secrets.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
start_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
start_notlinux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
start_unix.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
start_windows.go
Fix custom runtimes handling on Windows
2025-08-08 21:41:17 +02:00
start.go
daemon/container: remove State.ExitCode() method
2025-09-19 15:33:36 +01:00
stats_collector.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
stats_unix_test.go
Refactor CPU usage stats test to use go:embed
2025-05-16 10:23:49 -04:00
stats_unix.go
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
stats_windows.go
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
stats.go
api/types/container: StatsResponse: add OSType field
2025-10-27 16:39:32 +01:00
stop.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
top_unix_test.go
daemon: remove // import comments
2025-05-30 15:59:13 +02:00
top_unix.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
top_windows.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
unpause.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
update_linux_test.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
update_linux.go
remove support for deprecated kernel memory limit
2025-09-16 13:08:36 +02:00
update_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
update.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
volumes_linux_test.go
Create github.com/moby/moby/api module
2025-07-21 09:30:05 -07:00
volumes_linux.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes_unit_test.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes_unix.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes_windows.go
Create github.com/moby/moby/v2 module
2025-07-31 10:13:29 -07:00
volumes.go
Move Daemon.registerMountPoints out of Daemon.setHostConfig
2025-11-16 18:25:06 +00:00
wait.go
explicitly access Container.State instead of through embedded struct
2025-09-19 16:02:14 +02:00
workdir.go
update github links to moby/moby
2025-08-01 01:48:55 +02:00