Sebastiaan van Stijn 5bbf3af980 daemon: fix linting S1016 (staticcheck) false positive ...

Staticcheck is suggesting to cast the type or to directly copy, but
doesn't account for nat.SortPortMap mutating the second argument, so
mutating the HostConfig.PortBindings. From the code, it looks like the
intent here was to prevent that (creating a deep copy), so let's keep
that.

    daemon/container_operations.go:109:39: S1016: should convert bb (type github.com/docker/docker/vendor/github.com/docker/go-connections/nat.PortBinding) to github.com/docker/docker/vendor/github.com/moby/moby/api/types/container.PortBinding instead of using struct literal (staticcheck)
                    bindings[p] = append(bindings[p], containertypes.PortBinding{
                                                      ^
    daemon/network.go:952:39: S1016: should convert bb (type github.com/docker/docker/vendor/github.com/docker/go-connections/nat.PortBinding) to github.com/docker/docker/vendor/github.com/moby/moby/api/types/container.PortBinding instead of using struct literal (staticcheck)
                    bindings[p] = append(bindings[p], containertypes.PortBinding{
                                                      ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2025-07-31 02:57:39 +02:00

..

builder

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

cluster

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

command

pkg/rootless: move to daemon/internal

2025-07-28 22:04:39 +02:00

config

pkg/rootless: move to daemon/internal

2025-07-28 22:04:39 +02:00

container

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

containerd

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

events

Move internal/lazyregexp to daemon/internal/lazyregexp

2025-07-24 12:12:38 -07:00

graphdriver

pkg/system: move to daemon/internal

2025-07-29 11:48:57 +02:00

images

Move pkg/streamformatter to api/pkg/streamformatter

2025-07-30 14:22:31 +02:00

initlayer

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

internal

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

libnetwork

pkg/rootless: move to daemon/internal

2025-07-28 22:04:39 +02:00

links

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

listeners

Merge pull request #50294 from thaJeztah/listeners_doc_permissions

2025-07-02 11:47:02 +02:00

logger

Move logdriver to internal under daemon/logger

2025-07-28 23:05:19 -07:00

names

Move internal/lazyregexp to daemon/internal/lazyregexp

2025-07-24 12:12:38 -07:00

network

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

pkg

Move pkg/progress to api/pkg/progress

2025-07-30 14:22:31 +02:00

server

Move pkg/streamformatter to api/pkg/streamformatter

2025-07-30 14:22:31 +02:00

snapshotter

Update to use github.com/moby/go-archive

2025-04-08 17:35:05 -07:00

stats

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

testdata

Improve CPU usage parsing and error reporting

2025-04-07 16:19:02 +02:00

volume

pkg/stringid: move to daemon, and provide copy in client

2025-07-25 13:39:32 +02:00

apparmor_default_unsupported.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

apparmor_default.go

profiles/apparmor, seccomp: migrate to separate module

2025-07-22 18:48:39 +02:00

archive_tarcopyoptions_unix.go

daemon: ContainerExtractToDir: make AllowOverwriteDirWithFile opt-in

2025-07-13 16:37:36 +02:00

archive_tarcopyoptions.go

daemon: ContainerExtractToDir: make AllowOverwriteDirWithFile opt-in

2025-07-13 16:37:36 +02:00

archive_unix.go

Merge pull request #50404 from thaJeztah/saner_copy_defaults

2025-07-24 12:35:25 +02:00

archive_windows.go

Merge pull request #50404 from thaJeztah/saner_copy_defaults

2025-07-24 12:35:25 +02:00

archive.go

Merge pull request #50404 from thaJeztah/saner_copy_defaults

2025-07-24 12:35:25 +02:00

attach.go

Move api/stdcopy to api/pkg/stdcopy

2025-07-30 14:22:30 +02:00

auth.go

daemon/pkg/registry: Service.Auth: remove unused statusMessage return

2025-07-29 10:26:12 +02:00

build.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

cdi.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

changes.go

Move internal/metrics to daemon/internal/metrics

2025-06-27 14:25:45 -07:00

checkpoint.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

cluster.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

commit.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

configs.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

container_linux.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

container_operations_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

container_operations_unix.go

pkg/stringid: move to daemon, and provide copy in client

2025-07-25 13:39:32 +02:00

container_operations_windows.go

pkg/system: move to daemon/internal

2025-07-29 11:48:57 +02:00

container_operations.go

daemon: fix linting S1016 (staticcheck) false positive

2025-07-31 02:57:39 +02:00

container_unix_test.go

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

container_windows.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

container.go

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

containerfs_linux_test.go

pkg/fileutils: move ReadSymlinkedDirectory internal to daemon

2025-07-29 11:16:25 +02:00

containerfs_linux.go

pkg/fileutils: move ReadSymlinkedDirectory internal to daemon

2025-07-29 11:16:25 +02:00

content.go

fix duplicate import, and force consistent alias for bolt

2025-04-22 11:31:10 +02:00

create_unix.go

Move pkg/idtools to daemon/internal/idtools

2025-07-24 12:12:07 -07:00

create_windows.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

create.go

runconfig: remove exported errors

2025-07-28 11:46:19 +02:00

daemon_linux_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

daemon_linux.go

Move libnetwork to daemon/libnetwork

2025-07-14 09:25:23 -07:00

daemon_test.go

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

daemon_unix_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

daemon_unix.go

runconfig: remove exported errors

2025-07-28 11:46:19 +02:00

daemon_unsupported.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

daemon_windows_test.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

daemon_windows.go

pkg/system: move to daemon/internal

2025-07-29 11:48:57 +02:00

daemon.go

pkg/fileutils: move ReadSymlinkedDirectory to daemon

2025-07-29 11:17:32 +02:00

debugtrap_unix.go

pkg/stack: move to daemon/internal

2025-07-28 18:39:22 +02:00

debugtrap_unsupported.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

debugtrap_windows.go

pkg/stack: move to daemon/internal

2025-07-28 18:39:22 +02:00

delete_test.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

delete.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

dependency.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

devices_amd_linux.go

Added support for AMD GPUs in "docker run --gpus".

2025-06-05 14:44:18 +00:00

devices_nvidia_linux.go

Added support for AMD GPUs in "docker run --gpus".

2025-06-05 14:44:18 +00:00

devices.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

disk_usage.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

errors_test.go

daemon: cleanupContainer: don't fail if container is already stopped

2023-08-23 15:47:43 +02:00

errors.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

events_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

events.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

exec_linux_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

exec_linux.go

Move oci to daemon/pkg/oci

2025-07-24 12:11:19 -07:00

exec_windows.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

exec.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

export.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

health_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

health.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

hosts_test.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

hosts.go

Move registry to daemon/pkg/registry

2025-07-24 12:11:51 -07:00

id.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

image_service.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

info_unix_test.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

info_unix.go

pkg/rootless: move to daemon/internal

2025-07-28 22:04:39 +02:00

info_windows.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

info.go

Move internal/platform to daemon/internal/platform

2025-07-24 12:14:46 -07:00

inspect_linux.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

inspect_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

inspect_windows.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

inspect.go

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

keys_unsupported.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

keys.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

kill.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

licensing_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

licensing.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

links.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

list_test.go

Move image to daemon/internal/image

2025-07-24 12:11:02 -07:00

list_unix.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

list_windows.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

list.go

replace direct uses of nat types for api/types/container aliases

2025-07-31 02:57:39 +02:00

logdrivers_linux.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

logdrivers_windows.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

logs_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

logs.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

migration_test.go

Move image to daemon/internal/image

2025-07-24 12:11:02 -07:00

migration.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

monitor.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

mounts.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

names.go

pkg/stringid: move to daemon, and provide copy in client

2025-07-25 13:39:32 +02:00

network_windows.go

Move libnetwork to daemon/libnetwork

2025-07-14 09:25:23 -07:00

network.go

daemon: fix linting S1016 (staticcheck) false positive

2025-07-31 02:57:39 +02:00

oci_linux_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

oci_linux.go

Move internal/rootless to daemon/internal/rootless

2025-07-24 12:15:02 -07:00

oci_opts.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

oci_utils.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

oci_windows_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

oci_windows.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

pause.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

prune.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

reload_test.go

Move registry to daemon/pkg/registry

2025-07-24 12:11:51 -07:00

reload_unix.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

reload_windows.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

reload.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

rename.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

resize_test.go

Move libcontainerd/types to daemon/internal/libcontainerd/types

2025-06-27 14:28:56 -07:00

resize.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

restart.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

runtime_unix_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

runtime_unix.go

Move libcontainerd/shimopts to daemon/internal/libcontainerd/shimopts

2025-06-27 14:28:24 -07:00

runtime_windows.go

daemon: reload runtimes w/o breaking containers

2023-06-01 14:45:25 -04:00

seccomp_linux_test.go

Move oci to daemon/pkg/oci

2025-07-24 12:11:19 -07:00

seccomp_linux.go

profiles/apparmor, seccomp: migrate to separate module

2025-07-22 18:48:39 +02:00

seccomp_unsupported.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

secrets.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

start_linux.go

Move oci to daemon/pkg/oci

2025-07-24 12:11:19 -07:00

start_notlinux.go

Move libcontainerd/types to daemon/internal/libcontainerd/types

2025-06-27 14:28:56 -07:00

start_unix.go

Move container to daemon/container

2025-06-27 14:27:21 -07:00

start_windows.go

pkg/system: remove EnableContainerdRuntime, ContainerdRuntimeSupported

2025-07-12 19:16:30 +02:00

start.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

stats_collector.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

stats_unix_test.go

Refactor CPU usage stats test to use go:embed

2025-05-16 10:23:49 -04:00

stats_unix.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

stats_windows.go

Move internal/platform to daemon/internal/platform

2025-07-24 12:14:46 -07:00

stats.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

stop.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

top_unix_test.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00

top_unix.go

Move internal/lazyregexp to daemon/internal/lazyregexp

2025-07-24 12:12:38 -07:00

top_windows.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

unpause.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

update_linux_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

update_linux.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

update_windows.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

update.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

volumes_linux_test.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

volumes_linux.go

Create github.com/moby/moby/api module

2025-07-21 09:30:05 -07:00

volumes_unit_test.go

Move volume to daemon/volume

2025-07-15 10:44:44 -07:00

volumes_unix.go

Move internal/cleanups to daemon/internal/cleanups

2025-07-24 12:12:54 -07:00

volumes_windows.go

Move internal/cleanups to daemon/internal/cleanups

2025-07-24 12:12:54 -07:00

volumes.go

api/types: move backend types to daemon/server

2025-07-28 00:03:04 +02:00

wait.go

api/types/container: move StateStatus, NewStateStatus internal again

2025-07-28 13:57:10 +02:00

workdir.go

daemon: remove // import comments

2025-05-30 15:59:13 +02:00