Sebastiaan van Stijn cddaa84777 pkg/archive: remove backward compat hack for go < 1.9 ...

The fillGo18FileTypeBits func was added in 1a451d9a7b
to keep the tar headers consistent with headers created with go1.8 and older.

go1.8 and older incorrectly preserved all file-mode bits, including file-type,
instead of stripping those bits and only preserving the _permission_ bits, as
defined in;

- the GNU tar spec: https://www.gnu.org/software/tar/manual/html_node/Standard.html
- and POSIX: http://pubs.opengroup.org/onlinepubs/009695399/basedefs/tar.h.html

We decided at the time to copy the "wrong" behavior to prevent a cache-bust and
to keep the archives identical, however:

- It's not matching the standards, which causes differences between our tar
  implementation and the standard tar implementations, as well as implementations
  in other languages, such as Python (see docker/compose#883).
- BuildKit does not implement this hack.
- We don't _need_ this extra information (as it's already preserved in the
  type header; https://pkg.go.dev/archive/tar#pkg-constants

In short; let's remove this hack.

This reverts commit 1a451d9a7b.
This reverts commit 41eb61d5c2.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

2022-09-04 21:44:02 +02:00

..

builder-next

api: add BuildCache.Parents for API >= v1.42

2022-08-04 09:30:06 +02:00

dockerfile

daemon, builder: rename variables that collided with imports

2022-08-08 13:16:10 +02:00

remotecontext

pkg/archive: remove backward compat hack for go < 1.9

2022-09-04 21:44:02 +02:00

builder.go

daemon: daemon.ContainerKill() accept stop-signal as string

2022-05-05 11:27:47 +02:00