mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
1c34ff94bc
ensureReaderClosed was designed to be usable regardless if a response was nil (error) or non-nil (success). Some code-paths were optimized to avoid using a defer (which used to have an overhead), but the overhead of defer is neglectable in current versions of Go, and some of these optimizations made the logic more complicated (and err-prone). This patch switches to use a defer for all places. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
27 lines
630 B
Go
27 lines
630 B
Go
package client
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"net/http"
|
|
"net/url"
|
|
)
|
|
|
|
// PluginCreateOptions hold all options to plugin create.
|
|
type PluginCreateOptions struct {
|
|
RepoName string
|
|
}
|
|
|
|
// PluginCreate creates a plugin
|
|
func (cli *Client) PluginCreate(ctx context.Context, createContext io.Reader, createOptions PluginCreateOptions) error {
|
|
headers := http.Header(make(map[string][]string))
|
|
headers.Set("Content-Type", "application/x-tar")
|
|
|
|
query := url.Values{}
|
|
query.Set("name", createOptions.RepoName)
|
|
|
|
resp, err := cli.postRaw(ctx, "/plugins/create", query, createContext, headers)
|
|
defer ensureReaderClosed(resp)
|
|
return err
|
|
}
|