mirror of
https://github.com/moby/moby.git
synced 2026-01-11 18:51:37 +00:00
ensureReaderClosed was designed to be usable regardless if a response was nil (error) or non-nil (success). Some code-paths were optimized to avoid using a defer (which used to have an overhead), but the overhead of defer is neglectable in current versions of Go, and some of these optimizations made the logic more complicated (and err-prone). This patch switches to use a defer for all places. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
18 lines
367 B
Go
18 lines
367 B
Go
package client
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
)
|
|
|
|
// BuildCancel requests the daemon to cancel the ongoing build request
|
|
// with the given id.
|
|
func (cli *Client) BuildCancel(ctx context.Context, id string) error {
|
|
query := url.Values{}
|
|
query.Set("id", id)
|
|
|
|
resp, err := cli.post(ctx, "/build/cancel", query, nil, nil)
|
|
defer ensureReaderClosed(resp)
|
|
return err
|
|
}
|