mirror of
https://github.com/moby/moby.git
synced 2026-01-11 10:41:43 +00:00
778e5bfad3
Most of the code in the filters package relates to the unmarshaling, validation and application of filters from client requests. None of this is necessary or particularly useful for Go SDK users. Move the full-fat filters package into daemon/internal and switch all the daemon code to import that package so we are free to iterate upon the code without worrying about source-code interface compatibility. Signed-off-by: Cory Snider <csnider@mirantis.com>
117 lines
4.3 KiB
Go
117 lines
4.3 KiB
Go
package config
|
|
|
|
import (
|
|
"encoding/json"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/moby/moby/v2/daemon/internal/filters"
|
|
"gotest.tools/v3/assert"
|
|
"gotest.tools/v3/fs"
|
|
)
|
|
|
|
func TestBuilderGC(t *testing.T) {
|
|
tempFile := fs.NewFile(t, "config", fs.WithContent(`{
|
|
"builder": {
|
|
"gc": {
|
|
"enabled": true,
|
|
"policy": [
|
|
{"reservedSpace": "10GB", "filter": ["unused-for=2200h"]},
|
|
{"reservedSpace": "50GB", "filter": {"unused-for": {"3300h": true}}},
|
|
{"reservedSpace": "100GB", "minFreeSpace": "10GB", "maxUsedSpace": "200GB", "all": true}
|
|
]
|
|
}
|
|
}
|
|
}`))
|
|
defer tempFile.Remove()
|
|
configFile := tempFile.Path()
|
|
|
|
cfg, err := MergeDaemonConfigurations(&Config{}, nil, configFile)
|
|
assert.NilError(t, err)
|
|
assert.Assert(t, cfg.Builder.GC.IsEnabled())
|
|
f1 := filters.NewArgs()
|
|
f1.Add("unused-for", "2200h")
|
|
f2 := filters.NewArgs()
|
|
f2.Add("unused-for", "3300h")
|
|
expectedPolicy := []BuilderGCRule{
|
|
{ReservedSpace: "10GB", Filter: BuilderGCFilter(f1)},
|
|
{ReservedSpace: "50GB", Filter: BuilderGCFilter(f2)}, /* parsed from deprecated form */
|
|
{ReservedSpace: "100GB", MinFreeSpace: "10GB", MaxUsedSpace: "200GB", All: true},
|
|
}
|
|
assert.DeepEqual(t, cfg.Builder.GC.Policy, expectedPolicy, cmp.AllowUnexported(BuilderGCFilter{}))
|
|
// double check to please the skeptics
|
|
assert.Assert(t, filters.Args(cfg.Builder.GC.Policy[0].Filter).UniqueExactMatch("unused-for", "2200h"))
|
|
assert.Assert(t, filters.Args(cfg.Builder.GC.Policy[1].Filter).UniqueExactMatch("unused-for", "3300h"))
|
|
}
|
|
|
|
func TestBuilderGC_DeprecatedKeepStorage(t *testing.T) {
|
|
tempFile := fs.NewFile(t, "config", fs.WithContent(`{
|
|
"builder": {
|
|
"gc": {
|
|
"enabled": true,
|
|
"policy": [
|
|
{"keepStorage": "10GB", "filter": ["unused-for=2200h"]},
|
|
{"keepStorage": "50GB", "filter": {"unused-for": {"3300h": true}}},
|
|
{"keepStorage": "100GB", "all": true}
|
|
]
|
|
}
|
|
}
|
|
}`))
|
|
configFile := tempFile.Path()
|
|
|
|
cfg, err := MergeDaemonConfigurations(&Config{}, nil, configFile)
|
|
assert.NilError(t, err)
|
|
assert.Assert(t, cfg.Builder.GC.IsEnabled())
|
|
f1 := filters.NewArgs()
|
|
f1.Add("unused-for", "2200h")
|
|
f2 := filters.NewArgs()
|
|
f2.Add("unused-for", "3300h")
|
|
expectedPolicy := []BuilderGCRule{
|
|
{ReservedSpace: "10GB", Filter: BuilderGCFilter(f1)},
|
|
{ReservedSpace: "50GB", Filter: BuilderGCFilter(f2)}, /* parsed from deprecated form */
|
|
{ReservedSpace: "100GB", All: true},
|
|
}
|
|
assert.DeepEqual(t, cfg.Builder.GC.Policy, expectedPolicy, cmp.AllowUnexported(BuilderGCFilter{}))
|
|
// double check to please the skeptics
|
|
assert.Assert(t, filters.Args(cfg.Builder.GC.Policy[0].Filter).UniqueExactMatch("unused-for", "2200h"))
|
|
assert.Assert(t, filters.Args(cfg.Builder.GC.Policy[1].Filter).UniqueExactMatch("unused-for", "3300h"))
|
|
}
|
|
|
|
// TestBuilderGCFilterUnmarshal is a regression test for https://github.com/moby/moby/issues/44361,
|
|
// where and incorrectly formatted gc filter option ("unused-for2200h",
|
|
// missing a "=" separator). resulted in a panic during unmarshal.
|
|
func TestBuilderGCFilterUnmarshal(t *testing.T) {
|
|
var cfg BuilderGCConfig
|
|
err := json.Unmarshal([]byte(`{"poliCy": [{"reservedSpace": "10GB", "filter": ["unused-for2200h"]}]}`), &cfg)
|
|
assert.Check(t, err)
|
|
expectedPolicy := []BuilderGCRule{{
|
|
ReservedSpace: "10GB", Filter: BuilderGCFilter(filters.NewArgs(filters.Arg("unused-for2200h", ""))),
|
|
}}
|
|
assert.DeepEqual(t, cfg.Policy, expectedPolicy, cmp.AllowUnexported(BuilderGCFilter{}))
|
|
}
|
|
|
|
func TestBuilderGC_Enabled(t *testing.T) {
|
|
tests := []struct {
|
|
doc, config string
|
|
expected bool
|
|
}{
|
|
{doc: "empty config", config: ``, expected: true},
|
|
{doc: "empty json", config: `{}`, expected: true},
|
|
{doc: "empty builder", config: `{"builder": {}}`, expected: true},
|
|
{doc: "empty gc", config: `{"builder": {"gc": {}}}`, expected: true},
|
|
{doc: "gc enabled", config: `{"builder": {"gc": {"enabled": true}}}`, expected: true},
|
|
{doc: "gc disabled", config: `{"builder": {"gc": {"enabled": false}}}`, expected: false},
|
|
{doc: "gc with policy", config: `{"builder": {"gc": {"policy": []}}}`, expected: true},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.doc, func(t *testing.T) {
|
|
tempFile := fs.NewFile(t, "config", fs.WithContent(tc.config))
|
|
configFile := tempFile.Path()
|
|
|
|
cfg, err := MergeDaemonConfigurations(&Config{}, nil, configFile)
|
|
assert.NilError(t, err)
|
|
assert.Equal(t, cfg.Builder.GC.IsEnabled(), tc.expected)
|
|
})
|
|
}
|
|
}
|